Florian Westphal
dad3bdeef4
netfilter: nf_tables: fix memory leak during stateful obj update
...
stateful objects can be updated from the control plane.
The transaction logic allocates a temporary object for this purpose.
The ->init function was called for this object, so plain kfree() leaks
resources. We must call ->destroy function of the object.
nft_obj_destroy does this, but it also decrements the module refcount,
but the update path doesn't increment it.
To avoid special-casing the update object release, do module_get for
the update case too and release it via nft_obj_destroy().
Fixes: d62d0ba97b58 ("netfilter: nf_tables: Introduce stateful object update operation")
Cc: Fernando Fernandez Mancera <ffmancera@riseup.net>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2022-02-22 08:28:04 +01:00
..
2021-09-14 00:50:01 +02:00
2021-11-30 22:46:08 +01:00
2022-01-09 23:30:13 +01:00
2021-12-23 01:07:35 +01:00
2021-12-23 01:07:35 +01:00
2019-05-21 10:50:45 +02:00
2021-03-28 17:31:14 -07:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2022-01-16 00:55:27 +01:00
2021-08-25 12:50:38 +02:00
2022-01-09 23:30:13 +01:00
2019-12-17 22:59:31 +01:00
2021-05-05 23:45:48 +02:00
2020-07-22 01:18:05 +02:00
2021-06-01 23:53:51 +02:00
2019-06-19 17:09:52 +02:00
2021-06-07 12:23:37 +02:00
2021-05-05 23:45:48 +02:00
2019-08-27 18:07:03 +02:00
2022-01-11 10:41:44 +01:00
2022-02-04 05:39:57 +01:00
2021-05-05 23:45:48 +02:00
2021-06-18 14:47:43 +02:00
2019-06-19 17:09:55 +02:00
2021-07-02 02:07:01 +02:00
2021-06-18 14:47:43 +02:00
2021-06-18 14:47:43 +02:00
2022-02-04 05:38:15 +01:00
2022-02-04 05:39:51 +01:00
2021-11-01 09:28:54 +01:00
2021-10-26 13:21:09 +01:00
2021-05-05 23:45:48 +02:00
2019-05-31 18:02:45 +02:00
2019-07-16 13:16:59 +02:00
2019-05-30 11:26:32 -07:00
2022-01-09 23:30:13 +01:00
2019-07-16 13:16:59 +02:00
2019-09-13 12:33:06 +02:00
2019-05-24 17:37:51 +02:00
2020-10-22 14:49:36 +02:00
2022-01-09 23:30:13 +01:00
2021-12-23 01:07:44 +01:00
2021-03-31 22:34:11 +02:00
2021-11-08 12:14:05 +01:00
2021-08-30 01:51:36 +02:00
2020-05-27 22:20:34 +02:00
2021-04-26 03:20:47 +02:00
2021-03-31 22:34:11 +02:00
2019-07-16 13:16:59 +02:00
2022-01-09 23:30:13 +01:00
2019-07-16 13:16:59 +02:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2021-12-16 12:49:34 +01:00
2021-04-26 03:20:07 +02:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2021-08-11 10:22:26 +01:00
2020-07-24 15:41:54 -07:00
2022-01-09 23:30:13 +01:00
2022-02-22 08:28:04 +01:00
2022-01-09 23:35:17 +01:00
2022-02-20 01:22:20 +01:00
2022-01-09 23:35:17 +01:00
2021-05-29 01:04:53 +02:00
2021-06-07 13:01:52 -07:00
2021-05-29 01:04:53 +02:00
2021-12-29 08:48:14 -08:00
2022-01-09 15:59:23 -08:00
2021-05-05 22:26:09 +02:00
2022-01-09 15:59:23 -08:00
2021-06-07 12:41:10 +02:00
2022-01-09 23:35:17 +01:00
2022-01-27 00:07:24 +01:00
2021-10-22 11:41:16 +01:00
2021-05-29 01:04:54 +02:00
2021-05-29 01:04:54 +02:00
2021-04-18 22:02:21 +02:00
2021-09-21 03:46:56 +02:00
2022-01-13 12:26:04 +01:00
2021-12-23 01:07:35 +01:00
2022-01-27 00:03:09 +01:00
2022-02-20 01:22:20 +01:00
2021-10-07 19:53:15 +02:00
2022-02-04 05:38:15 +01:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2021-01-27 23:16:02 +01:00
2021-05-29 01:04:54 +02:00
2022-02-20 01:22:20 +01:00
2021-01-27 23:16:02 +01:00
2022-02-20 01:22:20 +01:00
2022-01-10 21:09:43 -08:00
2022-02-21 15:52:14 +01:00
2021-03-31 22:34:11 +02:00
2021-05-29 01:04:27 +02:00
2021-01-27 22:53:29 +01:00
2022-01-09 23:35:17 +01:00
2021-07-23 14:18:03 +02:00
2022-01-09 23:35:16 +01:00
2021-05-28 21:11:41 +02:00
2021-06-16 20:51:50 +02:00
2022-02-04 05:38:15 +01:00
2021-01-27 22:53:29 +01:00
2022-01-10 21:09:43 -08:00
2021-01-27 22:53:29 +01:00
2021-01-27 22:53:29 +01:00
2021-05-29 01:04:53 +02:00
2021-12-29 08:48:14 -08:00
2020-10-31 10:40:42 +01:00
2021-01-27 23:16:02 +01:00
2021-05-29 01:04:27 +02:00
2021-05-29 01:04:27 +02:00
2021-12-24 16:58:17 +01:00
2021-05-29 01:04:27 +02:00
2022-01-06 10:43:24 +01:00
2021-05-29 01:04:27 +02:00
2021-05-29 01:04:27 +02:00
2021-04-27 22:34:05 +02:00
2022-02-10 16:33:57 +01:00
2021-06-29 15:45:27 -07:00
2021-01-27 23:16:02 +01:00
2021-01-27 23:16:02 +01:00
2020-10-30 12:57:39 +01:00
2022-01-22 08:33:37 +02:00
2019-06-19 17:09:55 +02:00
2021-06-01 23:53:51 +02:00
2021-08-17 00:45:07 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2018-02-14 21:05:38 +01:00
2019-06-19 17:09:55 +02:00
2019-09-13 12:33:06 +02:00
2020-07-29 20:09:18 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-01-09 23:30:13 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-01-22 08:33:37 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2021-11-08 12:14:05 +01:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:38 -07:00
2019-06-19 17:09:55 +02:00
2021-05-29 01:04:52 +02:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-12-01 09:45:29 +01:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 11:28:45 +02:00
2019-06-25 01:32:59 +02:00
2019-09-13 12:32:48 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2021-10-18 12:54:41 +01:00
2019-06-19 17:09:55 +02:00
2022-01-22 08:33:37 +02:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-05-03 23:02:44 +02:00
2019-08-13 12:14:26 +02:00
2022-02-13 23:55:48 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-22 08:59:24 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2021-04-26 03:20:07 +02:00
2021-03-31 22:34:10 +02:00
2019-05-21 10:50:45 +02:00