587dd448d9
The sprd_div_helper_round_rate() function calls divider_round_rate() which calls divider_round_rate_parent() which calls divider_determine_rate(). This call chain converts back and forth from the rate request structure to make a determine_rate clk_op fit with a round_rate clk_op. Simplify the code here by directly calling divider_determine_rate() instead. This fixes a smatch warning where an unsigned long is compared to less than zero, which is impossible. This makes sprd_div_helper_round_rate() unnecessary as well so simply remove it and fold it into the only caller left. Reported-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Closes: https://lore.kernel.org/r/45fdc54e-7ab6-edd6-d55a-473485608473@oracle.com Cc: Maxime Ripard <maxime@cerno.tech> Fixes: 302d2f836d78 ("clk: sprd: composite: Switch to determine_rate") Signed-off-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/20230613195443.1555132-1-sboyd@kernel.org Reviewed-by: Maxime Ripard <mripard@kernel.org>
79 lines
2.1 KiB
C
79 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
//
|
|
// Spreadtrum divider clock driver
|
|
//
|
|
// Copyright (C) 2017 Spreadtrum, Inc.
|
|
// Author: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
|
|
|
|
#ifndef _SPRD_DIV_H_
|
|
#define _SPRD_DIV_H_
|
|
|
|
#include "common.h"
|
|
|
|
/**
|
|
* struct sprd_div_internal - Internal divider description
|
|
* @shift: Bit offset of the divider in its register
|
|
* @width: Width of the divider field in its register
|
|
*
|
|
* That structure represents a single divider, and is meant to be
|
|
* embedded in other structures representing the various clock
|
|
* classes.
|
|
*/
|
|
struct sprd_div_internal {
|
|
u8 shift;
|
|
u8 width;
|
|
};
|
|
|
|
#define _SPRD_DIV_CLK(_shift, _width) \
|
|
{ \
|
|
.shift = _shift, \
|
|
.width = _width, \
|
|
}
|
|
|
|
struct sprd_div {
|
|
struct sprd_div_internal div;
|
|
struct sprd_clk_common common;
|
|
};
|
|
|
|
#define SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \
|
|
_shift, _width, _flags, _fn) \
|
|
struct sprd_div _struct = { \
|
|
.div = _SPRD_DIV_CLK(_shift, _width), \
|
|
.common = { \
|
|
.regmap = NULL, \
|
|
.reg = _reg, \
|
|
.hw.init = _fn(_name, _parent, \
|
|
&sprd_div_ops, _flags), \
|
|
} \
|
|
}
|
|
|
|
#define SPRD_DIV_CLK(_struct, _name, _parent, _reg, \
|
|
_shift, _width, _flags) \
|
|
SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \
|
|
_shift, _width, _flags, CLK_HW_INIT)
|
|
|
|
#define SPRD_DIV_CLK_HW(_struct, _name, _parent, _reg, \
|
|
_shift, _width, _flags) \
|
|
SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \
|
|
_shift, _width, _flags, CLK_HW_INIT_HW)
|
|
|
|
static inline struct sprd_div *hw_to_sprd_div(const struct clk_hw *hw)
|
|
{
|
|
struct sprd_clk_common *common = hw_to_sprd_clk_common(hw);
|
|
|
|
return container_of(common, struct sprd_div, common);
|
|
}
|
|
|
|
unsigned long sprd_div_helper_recalc_rate(struct sprd_clk_common *common,
|
|
const struct sprd_div_internal *div,
|
|
unsigned long parent_rate);
|
|
|
|
int sprd_div_helper_set_rate(const struct sprd_clk_common *common,
|
|
const struct sprd_div_internal *div,
|
|
unsigned long rate,
|
|
unsigned long parent_rate);
|
|
|
|
extern const struct clk_ops sprd_div_ops;
|
|
|
|
#endif /* _SPRD_DIV_H_ */
|