iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Eric Dumazet dbc3a0b917 kcm: annotate data-races around kcm->rx_wait 
[ Upstream commit 0c745b5141a45a076f1cb9772a399f7ebcb0948a ]

kcm->rx_psock can be read locklessly in kcm_rfree().
Annotate the read and writes accordingly.

syzbot reported:

BUG: KCSAN: data-race in kcm_rcv_strparser / kcm_rfree

write to 0xffff88810784e3d0 of 1 bytes by task 1823 on cpu 1:
reserve_rx_kcm net/kcm/kcmsock.c:283 [inline]
kcm_rcv_strparser+0x250/0x3a0 net/kcm/kcmsock.c:363
__strp_recv+0x64c/0xd20 net/strparser/strparser.c:301
strp_recv+0x6d/0x80 net/strparser/strparser.c:335
tcp_read_sock+0x13e/0x5a0 net/ipv4/tcp.c:1703
strp_read_sock net/strparser/strparser.c:358 [inline]
do_strp_work net/strparser/strparser.c:406 [inline]
strp_work+0xe8/0x180 net/strparser/strparser.c:415
process_one_work+0x3d3/0x720 kernel/workqueue.c:2289
worker_thread+0x618/0xa70 kernel/workqueue.c:2436
kthread+0x1a9/0x1e0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

read to 0xffff88810784e3d0 of 1 bytes by task 17869 on cpu 0:
kcm_rfree+0x121/0x220 net/kcm/kcmsock.c:181
skb_release_head_state+0x8e/0x160 net/core/skbuff.c:841
skb_release_all net/core/skbuff.c:852 [inline]
__kfree_skb net/core/skbuff.c:868 [inline]
kfree_skb_reason+0x5c/0x260 net/core/skbuff.c:891
kfree_skb include/linux/skbuff.h:1216 [inline]
kcm_recvmsg+0x226/0x2b0 net/kcm/kcmsock.c:1161
____sys_recvmsg+0x16c/0x2e0
___sys_recvmsg net/socket.c:2743 [inline]
do_recvmmsg+0x2f1/0x710 net/socket.c:2837
__sys_recvmmsg net/socket.c:2916 [inline]
__do_sys_recvmmsg net/socket.c:2939 [inline]
__se_sys_recvmmsg net/socket.c:2932 [inline]
__x64_sys_recvmmsg+0xde/0x160 net/socket.c:2932
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

value changed: 0x01 -> 0x00

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 17869 Comm: syz-executor.2 Not tainted 6.1.0-rc1-syzkaller-00010-gbb1a1146467a-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022

Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-03 23:49:18 +09:00
..
6lowpan
6lowpan: Off by one handling ->nexthdr
2020-01-29 10:24:22 +01:00
9p
net/9p: Initialize the iounit field during fid creation
2022-08-25 11:09:27 +02:00
802
net/802/garp: fix memleak in garp_request_join()
2021-08-04 11:58:02 +02:00
8021q
vlan: fix memory leak in vlan_dev_set_egress_priority
2020-01-12 11:24:27 +01:00
appletalk
appletalk: Fix skb allocation size in loopback case
2021-04-07 12:05:39 +02:00
atm
net/atm: fix proc_mpc_write incorrect return value
2022-11-03 23:49:15 +09:00
ax25
ax25: Fix NULL pointer dereference in ax25_kill_by_device
2022-03-16 12:49:00 +01:00
batman-adv
batman-adv: Don't expect inter-netns unique iflink indices
2022-03-16 12:49:01 +01:00
bluetooth
Bluetooth: L2CAP: Fix user-after-free
2022-10-26 13:15:46 +02:00
bridge
netfilter: br_netfilter: Drop dst references before setting.
2022-09-15 12:39:46 +02:00
caif
net-caif: avoid user-triggerable WARN_ON(1)
2021-09-22 11:43:09 +02:00
can
can: bcm: check the result of can_send() in bcm_can_tx()
2022-10-26 13:15:46 +02:00
ceph
libceph: clear con->out_msg on Policy::stateful_server faults
2020-11-10 10:23:59 +01:00
core
net: Fix a data-race around sysctl_net_busy_read.
2022-09-05 10:23:55 +02:00
dcb
net: dcb: disable softirqs in dcbnl_flush_dev()
2022-03-08 19:00:59 +01:00
dccp
dccp: don't duplicate ccid when cloning dccp sock
2021-09-22 11:43:09 +02:00
decnet
net: decnet: Fix sleeping inside in af_decnet
2021-07-28 09:14:27 +02:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:27:39 +02:00
dsa
net: dsa: tag_brcm: Fix skb->fwd_offload_mark location
2020-04-13 10:32:53 +02:00
ethernet
net: add annotations on hh->hh_len lockless accesses
2020-01-12 11:24:19 +01:00
hsr
hsr: use netdev_err() instead of WARN_ONCE()
2021-05-22 10:40:20 +02:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-11-03 23:49:17 +09:00
ipv4
inet: fully convert sk->sk_rx_dst to RCU rules
2022-10-26 13:15:48 +02:00
ipv6
inet: fully convert sk->sk_rx_dst to RCU rules
2022-10-26 13:15:48 +02:00
ipx
ipx: call ipxitf_put() in ioctl error path
2017-05-25 15:44:41 +02:00
irda
irda: Only insert new objects into the global database via setsockopt
2018-09-15 09:43:01 +02:00
iucv
net/af_iucv: set correct sk_protocol for child sockets
2020-12-11 13:37:56 +01:00
kcm
kcm: annotate data-races around kcm->rx_wait
2022-11-03 23:49:18 +09:00
key
af_key: Do not call xfrm_probe_algs in parallel
2022-09-05 10:23:54 +02:00
l2tp
l2tp: fix race in pppol2tp_release with session object destroy
2022-06-25 11:45:19 +02:00
l3mdev
…
lapb
net: lapb: Copy the skb before sending a packet
2021-02-10 09:09:25 +01:00
llc
llc: only change llc->dev when bind() succeeds
2022-03-28 08:06:06 +02:00
mac80211
wifi: mac80211: allow bw change during channel switch in mesh
2022-10-26 13:15:39 +02:00
mac802154
mac802154: Fix LQI recording
2022-11-03 23:49:16 +09:00
mpls
net: avoid infinite loop in mpls_gso_segment when mpls_hlen == 0
2021-03-17 16:10:13 +01:00
ncsi
net/ncsi: Use real net-device for response handler
2021-01-12 19:49:01 +01:00
netfilter
netfilter: nf_conntrack_irc: Tighten matching on DCC message
2022-09-28 10:55:45 +02:00
netlabel
cipso,calipso: resolve a number of problems with the DOI refcounts
2022-01-27 08:47:42 +01:00
netlink
netlink: do not reset transport header in netlink_recvmsg()
2022-05-18 09:15:43 +02:00
netrom
netrom: Decrease sock refcount when sock timers expire
2021-07-28 09:14:27 +02:00
nfc
NFC: NULL out the dev->rfkill to prevent UAF
2022-06-14 16:52:31 +02:00
openvswitch
openvswitch: Fix overreporting of drops in dropwatch
2022-10-26 13:15:45 +02:00
packet
net/packet: fix packet_sock xmit return value checking
2022-04-27 13:14:10 +02:00
phonet
phonet: refcount leak in pep_sock_accep
2022-01-11 13:38:12 +01:00
qrtr
net: qrtr: fix a kernel-infoleak in qrtr_recvmsg()
2021-03-30 14:41:42 +02:00
rds
net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
2022-10-26 13:15:40 +02:00
rfkill
rfkill: Fix incorrect check to avoid NULL pointer dereference
2020-01-12 11:24:23 +01:00
rose
rose: check NULL rose_loopback_neigh->loopback
2022-09-05 10:23:54 +02:00
rxrpc
rxrpc: Don't try to resend the request if we're receiving the reply
2022-06-14 16:52:33 +02:00
sched
sch_sfb: Also store skb len before calling child enqueue
2022-09-15 12:39:46 +02:00
sctp
sctp: read sk->sk_bound_dev_if once in sctp_rcv()
2022-06-14 16:52:32 +02:00
strparser
strparser: Fix incorrect strp->need_bytes value.
2018-04-29 11:32:02 +02:00
sunrpc
SUNRPC: use _bh spinlocking on ->transport_lock
2022-09-15 12:39:46 +02:00
switchdev
…
tipc
tipc: fix shift wrapping bug in map_get()
2022-09-15 12:39:46 +02:00
unix
af_unix: annote lockless accesses to unix_tot_inflight & gc_in_progress
2022-01-27 08:47:41 +01:00
vmw_vsock
vsock: Fix memory leak in vsock_connect()
2022-08-25 11:09:29 +02:00
wimax
…
wireless
wifi: cfg80211: debugfs: fix return type in ht40allow_map_read()
2022-09-15 12:39:44 +02:00
x25
net/x25: Fix null-ptr-deref caused by x25_disconnect
2022-04-20 09:06:38 +02:00
xfrm
xfrm: Update ipcomp_scratches with NULL when freed
2022-10-26 13:15:45 +02:00
compat.c
net: Return the correct errno code
2021-06-30 08:49:12 -04:00
Kconfig
…
Makefile
net: split out functions related to registering inflight socket files
2021-08-04 11:58:01 +02:00
socket.c
net: Fix a data-race around sysctl_somaxconn.
2022-09-05 10:23:55 +02:00
sysctl_net.c
…