Hans de Goede dbe954d8f1
regulator: core: Avoid debugfs: Directory ... already present! error
Sometimes regulator_get() gets called twice for the same supply on the
same device. This may happen e.g. when a framework / library is used
which uses the regulator; and the driver itself also needs to enable
the regulator in some cases where the framework will not enable it.

Commit ff268b56ce8c ("regulator: core: Don't spew backtraces on
duplicate sysfs") already takes care of the backtrace which would
trigger when creating a duplicate consumer symlink under
/sys/class/regulator/regulator.%d in this scenario.

Commit c33d442328f5 ("debugfs: make error message a bit more verbose")
causes a new error to get logged in this scenario:

[   26.938425] debugfs: Directory 'wm5102-codec-MICVDD' with parent 'spi-WM510204:00-MICVDD' already present!

There is no _nowarn variant of debugfs_create_dir(), but we can detect
and avoid this problem by checking the return value of the earlier
sysfs_create_link_nowarn() call.

Add a check for the earlier sysfs_create_link_nowarn() failing with
-EEXIST and skip the debugfs_create_dir() call in that case, avoiding
this error getting logged.

Fixes: c33d442328f5 ("debugfs: make error message a bit more verbose")
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210122183250.370571-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-25 14:20:11 +00:00
..
2020-12-16 16:38:41 -08:00
2020-12-18 12:38:28 -08:00
2020-12-16 16:38:41 -08:00
2020-12-24 12:18:11 -08:00
2020-12-07 10:08:14 +01:00
2020-12-15 16:06:14 -08:00
2021-01-08 10:39:18 +01:00
2020-12-02 22:35:44 +01:00
2020-12-16 11:49:46 -08:00
2021-01-01 12:58:07 -08:00
2020-12-20 10:44:05 -08:00
2021-01-05 15:50:36 -08:00
2021-01-03 14:54:44 -07:00
2020-12-09 19:26:02 -06:00
2021-01-10 12:53:08 -08:00
2020-12-16 16:38:41 -08:00
2020-12-16 13:34:31 -08:00
2020-12-15 15:57:25 -08:00
2021-01-07 19:13:30 -08:00
2020-12-15 14:02:26 -08:00
2020-12-25 20:17:40 -08:00
2020-12-23 15:06:22 -08:00
2020-12-15 22:50:12 +11:00
2020-12-19 11:51:32 -08:00
2020-12-16 16:38:41 -08:00
2020-12-16 16:38:41 -08:00
2020-12-20 10:12:06 -08:00
2020-12-17 13:41:27 -08:00
2020-12-10 10:45:36 +01:00
2020-12-16 13:34:31 -08:00
2020-12-16 16:38:41 -08:00
2020-12-20 10:44:05 -08:00
2021-01-05 13:30:28 -08:00
2020-12-18 12:38:28 -08:00
2020-12-09 19:44:34 +01:00
2020-12-23 15:01:49 -08:00