Eric Dumazet
dc21c6cc3d
netfilter: nfnetlink_queue: acquire rcu_read_lock() in instance_destroy_rcu() ...
syzbot reported that nf_reinject() could be called without rcu_read_lock() :
WARNING: suspicious RCU usage
6.9.0-rc7-syzkaller-02060-g5c1672705a1a #0 Not tainted
net/netfilter/nfnetlink_queue.c:263 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
2 locks held by syz-executor.4/13427:
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline]
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_do_batch kernel/rcu/tree.c:2190 [inline]
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_core+0xa86/0x1830 kernel/rcu/tree.c:2471
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: nfqnl_flush net/netfilter/nfnetlink_queue.c:405 [inline]
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: instance_destroy_rcu+0x30/0x220 net/netfilter/nfnetlink_queue.c:172
stack backtrace:
CPU: 0 PID: 13427 Comm: syz-executor.4 Not tainted 6.9.0-rc7-syzkaller-02060-g5c1672705a1a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
lockdep_rcu_suspicious+0x221/0x340 kernel/locking/lockdep.c:6712
nf_reinject net/netfilter/nfnetlink_queue.c:323 [inline]
nfqnl_reinject+0x6ec/0x1120 net/netfilter/nfnetlink_queue.c:397
nfqnl_flush net/netfilter/nfnetlink_queue.c:410 [inline]
instance_destroy_rcu+0x1ae/0x220 net/netfilter/nfnetlink_queue.c:172
rcu_do_batch kernel/rcu/tree.c:2196 [inline]
rcu_core+0xafd/0x1830 kernel/rcu/tree.c:2471
handle_softirqs+0x2d6/0x990 kernel/softirq.c:554
__do_softirq kernel/softirq.c:588 [inline]
invoke_softirq kernel/softirq.c:428 [inline]
__irq_exit_rcu+0xf4/0x1c0 kernel/softirq.c:637
irq_exit_rcu+0x9/0x30 kernel/softirq.c:649
instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1043 [inline]
sysvec_apic_timer_interrupt+0xa6/0xc0 arch/x86/kernel/apic/apic.c:1043
</IRQ>
<TASK>
Fixes: 9872bec773c2 ("[NETFILTER]: nfnetlink: use RCU for queue instances hash")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2024-05-20 11:38:42 +02:00
2024-02-09 14:12:01 -08:00
2024-05-01 18:07:37 +01:00
2024-05-07 16:19:14 -07:00
2024-05-09 10:01:01 -07:00
2024-04-30 18:32:38 -07:00
2024-05-14 10:53:19 -07:00
2024-05-07 16:19:14 -07:00
2024-05-14 10:56:37 -04:00
2024-04-25 12:42:43 -07:00
2024-05-15 07:30:49 -07:00
2024-04-02 18:20:00 -07:00
2024-02-20 15:32:45 +01:00
2024-03-06 12:43:01 +01:00
2024-05-13 18:35:02 -07:00
2024-05-07 16:15:08 -07:00
2024-04-22 13:05:19 -07:00
2024-01-11 10:07:29 -08:00
2024-05-08 10:35:10 +01:00
2024-04-25 08:20:54 -07:00
2024-05-13 18:35:02 -07:00
2024-04-16 17:14:55 -07:00
2024-05-09 10:01:01 -07:00
2024-05-03 13:29:41 +01:00
2024-05-14 10:53:19 -07:00
2024-05-16 19:31:15 -07:00
2024-04-02 18:19:09 -07:00
2024-03-11 09:53:22 +00:00
2024-02-09 14:12:01 -08:00
2024-05-17 12:15:22 -07:00
2024-05-03 13:29:42 +01:00
2024-05-03 10:18:19 +02:00
2024-03-06 21:01:26 +01:00
2024-02-29 14:24:56 -08:00
2024-05-03 13:29:41 +01:00
2024-05-13 18:29:23 -07:00
2024-05-20 11:38:42 +02:00
2024-05-13 14:58:12 -07:00
2024-04-23 10:09:49 -07:00
2024-05-16 19:35:44 -07:00
2024-05-09 10:01:01 -07:00
2024-04-26 12:20:01 +02:00
2024-05-14 10:53:19 -07:00
2024-05-16 19:38:05 -07:00
2024-05-09 10:01:01 -07:00
2024-04-01 10:49:28 +01:00
2024-05-16 09:47:45 +01:00
2024-05-03 13:29:42 +01:00
2024-03-25 15:40:22 +01:00
2024-05-03 13:29:42 +01:00
2024-05-09 10:01:01 -07:00
2024-05-09 20:24:13 -07:00
2024-05-03 13:29:42 +01:00
2024-05-09 10:01:01 -07:00
2024-05-03 13:29:42 +01:00
2024-05-08 12:19:12 +01:00
2024-05-03 13:29:42 +01:00
2024-05-03 16:05:53 -07:00
2024-05-14 10:53:19 -07:00
2024-04-02 18:00:24 -07:00
2024-05-06 16:32:51 +02:00
2024-05-03 13:29:43 +01:00
2024-04-05 22:47:22 -07:00
2024-05-09 10:01:01 -07:00
2024-05-08 10:35:09 +01:00
2024-01-31 16:41:16 -08:00
2024-04-15 08:10:26 -06:00
2024-04-24 09:43:54 +02:00
dc21c6cc3d