Daniel Walker dcd9637961 [PATCH] idetape gcc 4.1 warning fix
In both the read and write cases it will return an error if
copy_{from/to}_user faults.  However, I let the driver try to read/write as
much as it can just as it normally would , then finally it returns an error
if there was one.  This was the most straight forward way to handle the
error , since there isn't a clear way to clean up the buffers on error .

I moved retval in idetape_chrdev_write() down into the actual code blocks
since it's really once used there, and it conflicted with my ret variable.

Fixes the following warning,

drivers/ide/ide-tape.c: In function ‘idetape_copy_stage_from_user’:
drivers/ide/ide-tape.c:2662: warning: ignoring return value of ‘copy_from_user’, declared with attribute warn_unused_result
drivers/ide/ide-tape.c: In function ‘idetape_copy_stage_to_user’:
drivers/ide/ide-tape.c:2689: warning: ignoring return value of ‘copy_to_user’, declared with attribute warn_unused_result

Signed-off-by: Daniel Walker <dwalker@mvista.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-06-25 10:01:05 -07:00
..
2006-06-20 01:21:29 -07:00
2006-06-23 07:43:06 -07:00
2006-06-23 08:47:27 -07:00
2006-06-17 21:25:58 -07:00
2006-05-03 20:05:41 -07:00
2006-06-20 01:21:29 -07:00
2006-06-25 10:01:05 -07:00
2006-06-19 13:06:05 +01:00
2006-06-19 15:37:31 +01:00
2006-06-05 12:29:17 -07:00
2006-06-25 10:00:58 -07:00
2006-06-23 07:43:06 -07:00
2006-06-17 21:18:43 -07:00
2006-06-17 21:18:43 -07:00