Eric Dumazet
df4646250f
net_sched: reject silly cell_log in qdisc_get_rtab() ...
commit e4bedf48aaa5552bc1f49703abd17606e7e6e82a upstream.
iproute2 probably never goes beyond 8 for the cell exponent,
but stick to the max shift exponent for signed 32bit.
UBSAN reported:
UBSAN: shift-out-of-bounds in net/sched/sch_api.c:389:22
shift exponent 130 is too large for 32-bit type 'int'
CPU: 1 PID: 8450 Comm: syz-executor586 Not tainted 5.11.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x183/0x22e lib/dump_stack.c:120
ubsan_epilogue lib/ubsan.c:148 [inline]
__ubsan_handle_shift_out_of_bounds+0x432/0x4d0 lib/ubsan.c:395
__detect_linklayer+0x2a9/0x330 net/sched/sch_api.c:389
qdisc_get_rtab+0x2b5/0x410 net/sched/sch_api.c:435
cbq_init+0x28f/0x12c0 net/sched/sch_cbq.c:1180
qdisc_create+0x801/0x1470 net/sched/sch_api.c:1246
tc_modify_qdisc+0x9e3/0x1fc0 net/sched/sch_api.c:1662
rtnetlink_rcv_msg+0xb1d/0xe60 net/core/rtnetlink.c:5564
netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2494
netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1330
netlink_sendmsg+0xaa6/0xe90 net/netlink/af_netlink.c:1919
sock_sendmsg_nosec net/socket.c:652 [inline]
sock_sendmsg net/socket.c:672 [inline]
____sys_sendmsg+0x5a2/0x900 net/socket.c:2345
___sys_sendmsg net/socket.c:2399 [inline]
__sys_sendmsg+0x319/0x400 net/socket.c:2432
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/r/20210114160637.1660597-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-27 11:05:43 +01:00
2020-01-27 14:50:41 +01:00
2020-11-05 11:08:44 +01:00
2021-01-17 14:04:19 +01:00
2019-12-13 08:52:59 +01:00
2020-10-01 13:14:43 +02:00
2020-07-31 18:37:48 +02:00
2020-12-02 08:48:10 +01:00
2020-12-30 11:25:52 +01:00
2018-08-03 00:47:32 +02:00
2020-01-27 14:50:51 +01:00
2020-12-30 11:25:41 +01:00
2019-11-10 11:27:48 +01:00
2020-11-24 13:27:22 +01:00
2020-11-05 11:08:53 +01:00
2021-01-27 11:05:42 +01:00
2021-01-23 15:49:56 +01:00
2020-04-29 16:31:16 +02:00
2020-01-04 19:13:37 +01:00
2020-04-23 10:30:24 +02:00
2020-11-10 12:36:02 +01:00
2020-01-09 10:19:09 +01:00
2020-04-21 09:03:03 +02:00
2020-03-18 07:14:15 +01:00
2021-01-27 11:05:43 +01:00
2021-01-27 11:05:43 +01:00
2020-12-08 10:18:52 +01:00
2019-04-17 08:38:40 +02:00
2020-09-26 18:01:28 +02:00
2020-07-22 09:31:59 +02:00
2019-06-22 08:15:13 +02:00
2020-10-01 13:14:26 +02:00
2020-12-30 11:26:03 +01:00
2020-10-01 13:14:51 +02:00
2020-04-29 16:31:17 +02:00
2021-01-12 20:10:18 +01:00
2021-01-19 18:22:38 +01:00
2020-11-24 13:27:17 +01:00
2020-07-22 09:31:58 +02:00
2020-04-29 16:31:21 +02:00
2020-10-29 09:54:58 +01:00
2020-10-14 10:31:24 +02:00
2020-10-07 08:00:08 +02:00
2019-11-10 11:27:48 +01:00
2019-12-05 09:21:30 +01:00
2020-09-26 18:01:30 +02:00
2020-08-05 10:06:01 +02:00
2020-01-12 12:17:17 +01:00
2020-12-08 10:18:52 +01:00
2021-01-23 15:49:56 +01:00
2021-01-27 11:05:43 +01:00
2020-11-24 13:27:18 +01:00
2020-10-29 09:54:55 +01:00
2019-05-16 19:41:27 +02:00
2021-01-19 18:22:38 +01:00
2021-01-23 15:49:56 +01:00
2020-12-08 10:18:52 +01:00
2020-10-01 13:14:32 +02:00
2020-11-10 12:35:59 +01:00
2018-07-24 14:10:42 -07:00
2020-12-30 11:26:06 +01:00
2020-12-08 10:18:54 +01:00
2020-12-30 11:25:44 +01:00
2020-11-18 19:18:41 +01:00
2020-08-21 11:05:32 +02:00
2018-07-24 14:10:43 -07:00
2020-08-19 08:15:03 +02:00
df4646250f