Masahiro Yamada df8df5e4bc usb: get rid of 'choice' for legacy gadget drivers ... drivers/usb/gadget/legacy/Kconfig creates a 'choice' inside another 'choice'. The outer choice: line 17 "USB Gadget precomposed configurations" The inner choice: line 484 "EHCI Debug Device mode" I wondered why the whole legacy gadget drivers reside in such a big choice block. This dates back to 2003, "[PATCH] USB: fix for multiple definition of `usb_gadget_get_string'". [1] At that time, the global function, usb_gadget_get_string(), was linked into multiple drivers. That was why only one driver was able to become built-in at the same time. Later, commit a84d9e5361 ("usb: gadget: start with libcomposite") moved usb_gadget_get_string() to a separate module, libcomposite.ko instead of including usbstring.c from multiple modules. More and more refactoring was done, and after commit 1bcce93947 ("usb: gadget: multi: convert to new interface of f_mass_storage"), you can link multiple gadget drivers into vmlinux without causing multiple definition error. This is the only user of the nested choice structure ever. Removing this mess will make some Kconfig cleanups possible. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=fee4cf49a81381e072c063571d1aadbb29207408 Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Felipe Balbi <balbi@kernel.org> Link: https://lore.kernel.org/r/20200315154948.26569-1-masahiroy@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-03-16 08:36:35 +01:00
..
function	usb: gadget: f_phonet: Replace zero-length array with flexible-array member	2020-03-15 12:10:58 +02:00
legacy	usb: get rid of 'choice' for legacy gadget drivers	2020-03-16 08:36:35 +01:00
udc	USB: changes for v5.7 merge window	2020-03-16 08:22:49 +01:00
composite.c	usb: gadget: composite: Inform controller driver of self-powered	2020-03-15 12:10:14 +02:00
config.c
configfs.c	usb: gadget: configfs: Add max_speed setting	2020-01-15 10:39:21 +01:00
configfs.h
epautoconf.c	usb: gadget: move non-super speed code out of usb_ep_autoconfig_ss()	2019-02-07 13:14:51 +02:00
functions.c
Kconfig	usb: gadget: move choice ... endchoice to legacy/Kconfig	2019-12-17 16:24:13 +01:00
Makefile	Revert "usb:gadget Separated decoding functions from dwc3 driver."	2019-07-04 13:02:09 +02:00
u_f.c	usb: gadget: Change Andrzej Pietrasiewicz's e-mail address	2019-02-11 11:12:29 +02:00
u_f.h	usb: gadget: Change Andrzej Pietrasiewicz's e-mail address	2019-02-11 11:12:29 +02:00
u_os_desc.h	usb: gadget: Change Andrzej Pietrasiewicz's e-mail address	2019-02-11 11:12:29 +02:00
usbstring.c