linux/include/asm-generic
Steven Rostedt dfbf2897d0 bug: set warn variable before calling WARN()
This has hit me a couple of times already.  I would be debugging code
and the system would simply hang and then reboot.  Finally, I found that
the problem was caused by WARN_ON_ONCE() and friends.

The macro WARN_ON_ONCE(condition) is defined as:

	static bool __section(.data.unlikely) __warned;
	int __ret_warn_once = !!(condition);

	if (unlikely(__ret_warn_once))
		if (WARN_ON(!__warned))
			__warned = true;

	unlikely(__ret_warn_once);

Which looks great and all.  But what I have hit, is an issue when
WARN_ON() itself hits the same WARN_ON_ONCE() code.  Because, the
variable __warned is not yet set.  Then it too calls WARN_ON() and that
triggers the warning again.  It keeps doing this until the stack is
overflowed and the system crashes.

By setting __warned first before calling WARN_ON() makes the original
WARN_ON_ONCE() really only warn once, and not an infinite amount of
times if the WARN_ON() also triggers the warning.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-03-17 15:09:34 -07:00
..
2015-07-27 14:06:24 +02:00
2009-06-11 21:02:42 +02:00
2011-03-17 09:19:04 +08:00
2015-05-12 10:46:53 +02:00
2010-10-07 14:08:55 +01:00
2010-10-07 14:08:55 +01:00
2012-10-02 18:01:56 +01:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2012-12-09 23:14:14 +01:00
2014-11-23 13:01:47 +01:00
2013-01-03 15:57:16 -08:00
2015-08-25 09:59:45 +02:00
2014-06-17 19:12:40 -04:00
2014-05-15 00:32:09 +01:00
2015-09-05 13:19:09 +02:00
2013-11-09 00:16:29 -05:00
2012-11-29 00:01:23 -05:00
2013-02-14 09:21:15 -05:00
2015-11-23 09:44:58 +01:00
2009-06-11 21:02:42 +02:00