Jan Kara dfcbd407f8 ext4: fix ext4_empty_dir() for directories with holes
commit 64d4ce892383b2ad6d782e080d25502f91bf2a38 upstream.

Function ext4_empty_dir() doesn't correctly handle directories with
holes and crashes on bh->b_data dereference when bh is NULL. Reorganize
the loop to use 'offset' variable all the times instead of comparing
pointers to current direntry with bh->b_data pointer. Also add more
strict checking of '.' and '..' directory entries to avoid entering loop
in possibly invalid state on corrupted filesystems.

References: CVE-2019-19037
CC: stable@vger.kernel.org
Fixes: 4e19d6b65fb4 ("ext4: allow directory holes")
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191202170213.4761-2-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-04 13:40:22 +01:00
..
2016-10-15 12:09:13 -07:00
2019-08-06 18:29:38 +02:00
2019-12-21 10:41:21 +01:00
2019-12-21 10:42:09 +01:00
2019-12-21 10:41:30 +01:00
2017-11-30 08:39:04 +00:00
2019-03-13 14:04:52 -07:00
2018-12-21 14:11:31 +01:00
2018-02-17 13:21:15 +01:00
2017-06-14 15:06:01 +02:00