Eric Sandeen cb04d34762 ext4: do not commit super on read-only bdev
[ Upstream commit c96e2b8564adfb8ac14469ebc51ddc1bfecb3ae2 ]

Under some circumstances we may encounter a filesystem error on a
read-only block device, and if we try to save the error info to the
superblock and commit it, we'll wind up with a noisy error and
backtrace, i.e.:

[ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
------------[ cut here ]------------
generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
...

To avoid this, commit the error info in the superblock only if the
block device is writable.

Reported-by: Ritesh Harjani <riteshh@linux.ibm.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/4b6e774d-cc00-3469-7abb-108eb151071a@sandeen.net
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-04-24 07:59:12 +02:00
..
2020-01-29 10:24:34 +01:00
2016-10-15 12:09:13 -07:00
2019-08-06 18:29:38 +02:00
2019-12-21 10:41:21 +01:00
2020-01-23 08:19:37 +01:00
2019-12-21 10:41:30 +01:00
2017-11-30 08:39:04 +00:00
2019-03-13 14:04:52 -07:00
2018-12-21 14:11:31 +01:00
2016-09-27 21:20:53 -04:00
2020-04-24 07:58:54 +02:00
2020-04-02 17:20:27 +02:00
2018-02-17 13:21:15 +01:00
2017-06-14 15:06:01 +02:00