Eric Dumazet
e01065b339
netfilter: nfnetlink_queue: acquire rcu_read_lock() in instance_destroy_rcu() ...
[ Upstream commit dc21c6cc3d6986d938efbf95de62473982c98dec ]
syzbot reported that nf_reinject() could be called without rcu_read_lock() :
WARNING: suspicious RCU usage
6.9.0-rc7-syzkaller-02060-g5c1672705a1a #0 Not tainted
net/netfilter/nfnetlink_queue.c:263 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
2 locks held by syz-executor.4/13427:
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline]
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_do_batch kernel/rcu/tree.c:2190 [inline]
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_core+0xa86/0x1830 kernel/rcu/tree.c:2471
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: nfqnl_flush net/netfilter/nfnetlink_queue.c:405 [inline]
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: instance_destroy_rcu+0x30/0x220 net/netfilter/nfnetlink_queue.c:172
stack backtrace:
CPU: 0 PID: 13427 Comm: syz-executor.4 Not tainted 6.9.0-rc7-syzkaller-02060-g5c1672705a1a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
lockdep_rcu_suspicious+0x221/0x340 kernel/locking/lockdep.c:6712
nf_reinject net/netfilter/nfnetlink_queue.c:323 [inline]
nfqnl_reinject+0x6ec/0x1120 net/netfilter/nfnetlink_queue.c:397
nfqnl_flush net/netfilter/nfnetlink_queue.c:410 [inline]
instance_destroy_rcu+0x1ae/0x220 net/netfilter/nfnetlink_queue.c:172
rcu_do_batch kernel/rcu/tree.c:2196 [inline]
rcu_core+0xafd/0x1830 kernel/rcu/tree.c:2471
handle_softirqs+0x2d6/0x990 kernel/softirq.c:554
__do_softirq kernel/softirq.c:588 [inline]
invoke_softirq kernel/softirq.c:428 [inline]
__irq_exit_rcu+0xf4/0x1c0 kernel/softirq.c:637
irq_exit_rcu+0x9/0x30 kernel/softirq.c:649
instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1043 [inline]
sysvec_apic_timer_interrupt+0xa6/0xc0 arch/x86/kernel/apic/apic.c:1043
</IRQ>
<TASK>
Fixes: 9872bec773c2 ("[NETFILTER]: nfnetlink: use RCU for queue instances hash")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-16 13:32:28 +02:00
2024-01-05 15:12:29 +01:00
2023-01-14 10:16:18 +01:00
2024-02-23 08:41:55 +01:00
2023-12-20 15:44:29 +01:00
2023-12-20 15:44:28 +01:00
2022-06-22 14:13:17 +02:00
2024-05-02 16:23:33 +02:00
2024-05-17 11:48:06 +02:00
2023-01-14 10:15:31 +01:00
2024-05-17 11:48:07 +02:00
2023-03-17 08:45:11 +01:00
2024-02-23 08:42:29 +01:00
2023-10-25 11:54:15 +02:00
2024-06-16 13:32:07 +02:00
2023-08-11 11:57:50 +02:00
2023-11-20 11:06:55 +01:00
2023-06-21 15:45:38 +02:00
2024-01-25 14:37:50 -08:00
2023-07-27 08:44:10 +02:00
2024-05-02 16:23:44 +02:00
2024-01-25 14:37:56 -08:00
2024-03-26 18:22:03 -04:00
2022-11-03 23:57:51 +09:00
2024-01-05 15:12:24 +01:00
2024-06-16 13:32:27 +02:00
2024-06-16 13:32:26 +02:00
2024-03-26 18:21:46 -04:00
2024-03-26 18:21:54 -04:00
2023-08-26 15:26:51 +02:00
2024-05-17 11:48:00 +02:00
2022-04-27 13:53:50 +02:00
2024-02-23 08:42:17 +01:00
2024-05-17 11:48:07 +02:00
2024-04-13 12:58:25 +02:00
2023-02-22 12:55:58 +01:00
2024-05-25 16:19:06 +02:00
2024-01-25 14:37:44 -08:00
2024-06-16 13:32:28 +02:00
2024-01-25 14:37:40 -08:00
2024-05-25 16:19:06 +02:00
2024-06-16 13:32:15 +02:00
2024-06-16 13:32:27 +02:00
2024-05-17 11:48:00 +02:00
2024-06-16 13:32:27 +02:00
2024-06-16 13:32:15 +02:00
2024-05-17 11:48:07 +02:00
2023-12-13 18:27:06 +01:00
2024-06-16 13:32:15 +02:00
2024-04-13 12:59:19 +02:00
2024-01-05 15:12:28 +01:00
2024-01-05 15:12:24 +01:00
2024-02-23 08:42:20 +01:00
2024-04-13 12:59:26 +02:00
2023-10-10 21:53:39 +02:00
2024-04-13 12:59:43 +02:00
2021-11-18 14:04:27 +01:00
2024-06-16 13:32:26 +02:00
2024-05-17 11:48:10 +02:00
2024-06-16 13:32:27 +02:00
2024-06-16 13:32:09 +02:00
2024-01-25 14:37:45 -08:00
2024-06-16 13:32:00 +02:00
2024-03-26 18:21:54 -04:00
2024-05-02 16:23:33 +02:00
2024-05-17 11:48:06 +02:00
2023-06-21 15:45:38 +02:00
2023-06-21 15:45:38 +02:00
2024-01-15 18:48:04 +01:00
e01065b339