Liangyan
e04527fefb
ovl: fix dentry leak in ovl_get_redirect
...
We need to lock d_parent->d_lock before dget_dlock, or this may
have d_lockref updated parallelly like calltrace below which will
cause dentry->d_lockref leak and risk a crash.
CPU 0 CPU 1
ovl_set_redirect lookup_fast
ovl_get_redirect __d_lookup
dget_dlock
//no lock protection here spin_lock(&dentry->d_lock)
dentry->d_lockref.count++ dentry->d_lockref.count++
[ 49.799059] PGD 800000061fed7067 P4D 800000061fed7067 PUD 61fec5067 PMD 0
[ 49.799689] Oops: 0002 [#1 ] SMP PTI
[ 49.800019] CPU: 2 PID: 2332 Comm: node Not tainted 4.19.24-7.20.al7.x86_64 #1
[ 49.800678] Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS 8a46cfe 04/01/2014
[ 49.801380] RIP: 0010:_raw_spin_lock+0xc/0x20
[ 49.803470] RSP: 0018:ffffac6fc5417e98 EFLAGS: 00010246
[ 49.803949] RAX: 0000000000000000 RBX: ffff93b8da3446c0 RCX: 0000000a00000000
[ 49.804600] RDX: 0000000000000001 RSI: 000000000000000a RDI: 0000000000000088
[ 49.805252] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff993cf040
[ 49.805898] R10: ffff93b92292e580 R11: ffffd27f188a4b80 R12: 0000000000000000
[ 49.806548] R13: 00000000ffffff9c R14: 00000000fffffffe R15: ffff93b8da3446c0
[ 49.807200] FS: 00007ffbedffb700(0000) GS:ffff93b927880000(0000) knlGS:0000000000000000
[ 49.807935] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 49.808461] CR2: 0000000000000088 CR3: 00000005e3f74006 CR4: 00000000003606a0
[ 49.809113] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 49.809758] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 49.810410] Call Trace:
[ 49.810653] d_delete+0x2c/0xb0
[ 49.810951] vfs_rmdir+0xfd/0x120
[ 49.811264] do_rmdir+0x14f/0x1a0
[ 49.811573] do_syscall_64+0x5b/0x190
[ 49.811917] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 49.812385] RIP: 0033:0x7ffbf505ffd7
[ 49.814404] RSP: 002b:00007ffbedffada8 EFLAGS: 00000297 ORIG_RAX: 0000000000000054
[ 49.815098] RAX: ffffffffffffffda RBX: 00007ffbedffb640 RCX: 00007ffbf505ffd7
[ 49.815744] RDX: 0000000004449700 RSI: 0000000000000000 RDI: 0000000006c8cd50
[ 49.816394] RBP: 00007ffbedffaea0 R08: 0000000000000000 R09: 0000000000017d0b
[ 49.817038] R10: 0000000000000000 R11: 0000000000000297 R12: 0000000000000012
[ 49.817687] R13: 00000000072823d8 R14: 00007ffbedffb700 R15: 00000000072823d8
[ 49.818338] Modules linked in: pvpanic cirrusfb button qemu_fw_cfg atkbd libps2 i8042
[ 49.819052] CR2: 0000000000000088
[ 49.819368] ---[ end trace 4e652b8aa299aa2d ]---
[ 49.819796] RIP: 0010:_raw_spin_lock+0xc/0x20
[ 49.821880] RSP: 0018:ffffac6fc5417e98 EFLAGS: 00010246
[ 49.822363] RAX: 0000000000000000 RBX: ffff93b8da3446c0 RCX: 0000000a00000000
[ 49.823008] RDX: 0000000000000001 RSI: 000000000000000a RDI: 0000000000000088
[ 49.823658] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff993cf040
[ 49.825404] R10: ffff93b92292e580 R11: ffffd27f188a4b80 R12: 0000000000000000
[ 49.827147] R13: 00000000ffffff9c R14: 00000000fffffffe R15: ffff93b8da3446c0
[ 49.828890] FS: 00007ffbedffb700(0000) GS:ffff93b927880000(0000) knlGS:0000000000000000
[ 49.830725] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 49.832359] CR2: 0000000000000088 CR3: 00000005e3f74006 CR4: 00000000003606a0
[ 49.834085] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 49.835792] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Cc: <stable@vger.kernel.org>
Fixes: a6c606551141 ("ovl: redirect on rename-dir")
Signed-off-by: Liangyan <liangyan.peng@linux.alibaba.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
2021-01-28 10:22:48 +01:00
..
2020-12-21 10:28:02 -08:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2021-01-04 12:25:19 +00:00
2020-12-10 12:42:59 -06:00
2020-09-18 16:45:50 -04:00
2020-12-15 22:46:18 -08:00
2021-01-11 14:18:56 -08:00
2020-10-26 10:42:54 -07:00
2020-12-28 20:34:32 +01:00
2021-01-13 13:36:45 -06:00
2020-05-05 09:22:21 -06:00
2020-11-14 10:22:45 +01:00
2020-09-18 16:45:50 -04:00
2020-12-17 11:18:00 -08:00
2020-10-30 08:37:39 +01:00
2020-11-10 12:14:20 -06:00
2020-08-07 11:33:22 -07:00
2020-11-25 16:55:02 +01:00
2020-09-18 16:45:50 -04:00
2020-12-10 11:07:40 +08:00
2020-12-22 12:31:17 +09:00
2020-12-09 09:39:38 -05:00
2020-11-23 10:36:53 +01:00
2021-01-15 14:54:24 -08:00
2020-12-17 11:18:00 -08:00
2020-09-18 16:45:50 -04:00
2020-06-03 16:27:18 -07:00
2020-12-10 15:33:14 +01:00
2020-12-03 17:04:41 +01:00
2020-10-29 17:22:59 -05:00
2020-10-29 17:22:59 -05:00
2020-12-21 21:42:29 -05:00
2020-09-18 16:45:50 -04:00
2020-08-12 10:57:56 -07:00
2020-12-02 18:28:05 -08:00
2020-10-29 17:22:59 -05:00
2020-12-17 13:30:45 -05:00
2020-12-13 21:57:21 +01:00
2020-11-13 16:03:07 -06:00
2020-12-09 19:03:49 +01:00
2020-12-16 07:57:37 -05:00
2020-09-18 16:45:50 -04:00
2021-01-10 16:29:28 -05:00
2020-12-09 09:38:34 -05:00
2021-01-11 11:35:46 -08:00
2020-12-15 22:46:17 -08:00
2020-06-14 01:57:21 +09:00
2020-12-28 11:58:59 +01:00
2020-12-15 12:13:37 -08:00
2020-12-15 12:13:37 -08:00
2020-09-22 23:39:45 -04:00
2020-12-16 16:14:08 -05:00
2021-01-28 10:22:48 +01:00
2021-01-16 10:51:26 -08:00
2020-12-17 13:22:17 -08:00
2020-09-18 16:45:50 -04:00
2020-09-18 16:45:50 -04:00
2020-12-17 11:00:37 -08:00
2020-10-16 11:11:22 -07:00
2020-11-26 16:57:28 +01:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-02 12:02:30 +02:00
2020-09-18 16:45:50 -04:00
2020-12-17 17:46:34 -08:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-09-10 14:03:31 -07:00
2020-10-15 15:11:56 -07:00
2020-12-14 12:18:19 -08:00
2020-12-18 12:50:18 -08:00
2021-01-04 09:06:42 +09:00
2020-12-15 12:53:37 -08:00
2020-06-03 23:16:55 -04:00
2020-05-07 16:55:47 -05:00
2020-10-16 11:11:21 -07:00
2020-12-15 19:29:43 -08:00
2020-06-04 19:18:29 -07:00
2020-08-24 08:49:13 +10:00
2020-06-04 19:18:29 -07:00
2020-06-04 19:18:29 -07:00
2021-01-07 20:57:53 -07:00
2020-12-16 12:57:51 -08:00
2020-05-14 16:44:23 +02:00
2020-10-26 13:46:47 +01:00
2020-12-15 19:29:43 -08:00
2020-10-14 14:54:45 -07:00
2020-12-15 22:46:19 -08:00
2020-12-10 17:33:17 -05:00
2020-10-15 15:03:10 -07:00
2020-04-27 02:07:40 -04:00
2020-11-15 09:49:10 -05:00
2020-12-19 11:18:38 -08:00
2020-12-16 12:10:40 -08:00
2020-11-05 07:44:15 -05:00
2020-10-25 20:02:08 -04:00
2020-12-30 19:36:54 -07:00
2020-04-10 15:36:22 -07:00
2020-08-23 17:36:59 -05:00
2020-10-13 18:38:27 -07:00
2020-07-29 16:14:27 +02:00
2020-12-16 11:56:02 +01:00
2020-08-23 17:36:59 -05:00
2020-08-04 21:02:38 -04:00
2020-12-25 10:54:29 -08:00
2020-12-16 12:57:51 -08:00
2021-01-15 16:04:23 -07:00
2020-12-20 10:47:42 -07:00
2020-12-20 10:47:42 -07:00
2020-07-31 08:16:01 +02:00
2020-08-07 11:33:24 -07:00
2020-06-14 01:57:21 +09:00
2020-10-05 13:37:04 +02:00
2020-12-17 11:18:00 -08:00
2020-12-15 19:29:43 -08:00
2020-10-23 11:33:41 -07:00
2020-08-19 14:14:19 +02:00
2020-06-02 10:59:07 -07:00
2020-12-25 10:54:29 -08:00
2021-01-04 15:31:58 -05:00
2020-05-13 11:41:22 +02:00
2020-12-15 19:29:43 -08:00
2020-12-01 14:53:39 -07:00
2020-04-27 10:37:14 -04:00
2020-12-10 17:33:17 -05:00
2020-06-08 11:04:19 -07:00
2020-12-27 12:00:36 -08:00
2020-10-23 11:33:41 -07:00
2020-07-31 08:16:00 +02:00
2020-12-14 15:26:13 +01:00
2021-01-08 11:06:29 -08:00
2020-11-15 22:12:53 -05:00
2020-08-23 17:36:59 -05:00
2020-10-24 12:40:18 -07:00
2020-09-26 22:55:05 -04:00
2020-12-01 14:53:39 -07:00
2020-12-01 14:53:39 -07:00
2020-06-09 15:40:50 -07:00
2020-12-15 12:13:46 -08:00
2020-07-31 08:16:01 +02:00
2020-12-14 15:26:13 +01:00