Brian Foster 5f56aa0b1f xfs: fix inode allocation block res calculation precedence
[ Upstream commit b2a8864728683443f34a9fd33a2b78b860934cc1 ]

The block reservation calculation for inode allocation is supposed
to consist of the blocks required for the inode chunk plus
(maxlevels-1) of the inode btree multiplied by the number of inode
btrees in the fs (2 when finobt is enabled, 1 otherwise).

Instead, the macro returns (ialloc_blocks + 2) due to a precedence
error in the calculation logic. This leads to block reservation
overruns via generic/531 on small block filesystems with finobt
enabled. Add braces to fix the calculation and reserve the
appropriate number of blocks.

Fixes: 9d43b180af67 ("xfs: update inode allocation/free transaction reservations for finobt")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-19 08:16:17 +02:00
..
2019-08-26 17:43:15 -07:00
2019-08-26 17:43:15 -07:00
2018-06-06 14:17:53 -07:00
2019-08-30 22:43:57 -07:00
2018-06-06 14:17:53 -07:00
2019-07-15 21:20:52 -07:00
2019-06-28 19:30:43 -07:00
2019-06-28 19:30:43 -07:00
2018-06-06 14:17:53 -07:00
2019-09-25 09:01:43 -07:00
2018-06-06 14:17:53 -07:00
2019-06-28 19:30:43 -07:00
2018-06-06 14:17:53 -07:00
2019-06-28 19:30:43 -07:00
2019-07-03 08:21:58 -07:00
2019-07-03 08:21:58 -07:00
2019-06-28 19:30:43 -07:00
2019-04-23 08:36:23 -07:00
2019-06-28 19:30:43 -07:00
2019-06-28 19:30:43 -07:00
2019-06-28 19:30:43 -07:00
2018-06-06 14:17:53 -07:00
2019-06-28 19:30:43 -07:00
2019-08-26 17:43:15 -07:00