iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
valis b80b829e9e net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free 
When route4_change() is called on an existing filter, the whole
tcf_result struct is always copied into the new instance of the filter.

This causes a problem when updating a filter bound to a class,
as tcf_unbind_filter() is always called on the old instance in the
success path, decreasing filter_cnt of the still referenced class
and allowing it to be deleted, leading to a use-after-free.

Fix this by no longer copying the tcf_result struct from the old filter.

Fixes: 1109c00547fc ("net: sched: RCU cls_route")
Reported-by: valis <sec@valis.email>
Reported-by: Bing-Jhong Billy Jheng <billy@starlabs.sg>
Signed-off-by: valis <sec@valis.email>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: M A Ramdhan <ramdhan@starlabs.sg>
Link: https://lore.kernel.org/r/20230729123202.72406-4-jhs@mojatatu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-07-31 20:10:37 -07:00
..
act_api.c
net: sched: Replace strlcpy with strscpy
2023-07-10 08:23:53 +01:00
act_bpf.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_connmark.c
net/sched: act_connmark: handle errno on tcf_idr_check_alloc
2023-03-01 08:19:09 +00:00
act_csum.c
net: skbuff: hide csum_not_inet when CONFIG_IP_SCTP not set
2023-04-19 13:04:30 +01:00
act_ct.c
net/sched: act_ct: Fix promotion of offloaded unreplied tuple
2023-06-14 09:56:50 +02:00
act_ctinfo.c
net/sched: act_ctinfo: use percpu stats
2023-02-13 20:09:01 -08:00
act_gact.c
Networking changes for 6.2.
2022-12-13 15:47:48 -08:00
act_gate.c
net/sched: act_gate: use percpu stats
2023-02-16 10:39:28 +01:00
act_ife.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_ipt.c
net/sched: act_ipt: zero skb->cb before calling target
2023-06-29 12:10:37 +02:00
act_meta_mark.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_mirred.c
net/sched: act_mirred: Add carrier check
2023-05-01 07:26:10 +01:00
act_mpls.c
net/sched: remove two skb_mac_header() uses
2023-03-22 22:43:23 -07:00
act_nat.c
net/sched: act_nat: transition to percpu stats and rcu
2023-02-16 10:39:28 +01:00
act_pedit.c
net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX
2023-07-04 10:31:38 +02:00
act_police.c
net: move gso declarations and functions to their own files
2023-06-10 00:11:41 -07:00
act_sample.c
net/sched: act_sample: fix action bind logic
2023-02-26 18:27:45 +00:00
act_simple.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbedit.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbmod.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_tunnel_key.c
net/sched: act_tunnel_key: add support for "don't fragment"
2023-03-30 23:24:24 -07:00
act_vlan.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_api.c
net/sched: cls_api: Fix lockup on flushing explicitly created chain
2023-06-14 23:03:16 -07:00
cls_basic.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_bpf.c
net: sched: cls_bpf: Undo tcf_bind_filter in case of an error
2023-07-17 07:33:39 +01:00
cls_cgroup.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_flow.c
treewide: Convert del_timer*() to timer_shutdown*()
2022-12-25 13:38:09 -08:00
cls_flower.c
net: flower: fix stack-out-of-bounds in fl_set_key_cfm()
2023-07-27 20:01:29 -07:00
cls_fw.c
net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free
2023-07-31 20:10:36 -07:00
cls_matchall.c
net: sched: cls_matchall: Undo tcf_bind_filter in case of failure after mall_set_parms
2023-07-17 07:33:38 +01:00
cls_route.c
net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free
2023-07-31 20:10:37 -07:00
cls_u32.c
net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free
2023-07-31 20:10:36 -07:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
net: annotate data-races around sk->sk_{rcv|snd}timeo
2023-07-29 18:13:41 +01:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_u32.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ematch.c
net_sched: reject TCF_EM_SIMPLE case for complex ematch module
2022-12-19 09:43:18 +00:00
Kconfig
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
Makefile
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
sch_api.c
net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting
2023-06-14 10:31:39 +02:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
net: move gso declarations and functions to their own files
2023-06-10 00:11:41 -07:00
sch_cbs.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_choke.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
sch_codel.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_drr.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_etf.c
net: sched: etf: remove true check in etf_enable_offload()
2022-09-01 20:08:32 -07:00
sch_ets.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"
2022-10-19 13:47:09 +01:00
sch_fq_pie.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_fq.c
net/sched: sch_fq: fix integer overflow of "credit"
2023-04-21 20:24:29 -07:00
sch_frag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2021-12-31 14:35:40 +00:00
sch_generic.c
net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting
2023-06-14 10:31:39 +02:00
sch_gred.c
net: sched: gred: prevent races when adding offloads to stats
2023-01-18 20:28:25 -08:00
sch_hfsc.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_hhf.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_htb.c
sch_htb: Allow HTB priority parameter in offload mode
2023-05-15 09:31:07 +01:00
sch_ingress.c
net/sched: Reserve TC_H_INGRESS (TC_H_CLSACT) for ingress (clsact) Qdiscs
2023-05-30 23:31:05 -07:00
sch_mq.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_mqprio_lib.c
net/sched: mqprio: allow per-TC user input of FP adminStatus
2023-04-13 22:22:10 -07:00
sch_mqprio_lib.h
net/sched: mqprio: allow per-TC user input of FP adminStatus
2023-04-13 22:22:10 -07:00
sch_mqprio.c
net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64
2023-07-26 22:08:14 -07:00
sch_multiq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_netem.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2023-06-27 09:45:22 -07:00
sch_pie.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_plug.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_prio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_qfq.c
net/sched: sch_qfq: account for stab overhead in qfq_enqueue
2023-07-13 11:11:59 +02:00
sch_red.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_sfb.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
sch_sfq.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00
sch_skbprio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_taprio.c
net/sched: taprio: Limit TCA_TAPRIO_ATTR_SCHED_CYCLE_TIME to INT_MAX.
2023-07-31 09:12:27 +01:00
sch_tbf.c
net: move gso declarations and functions to their own files
2023-06-10 00:11:41 -07:00
sch_teql.c
net: sched: add rcu annotations around qdisc->qdisc_sleeping
2023-06-07 10:25:39 +01:00