fc7a6209d5
The driver core ignores the return value of this callback because there is only little it can do when a device disappears. This is the final bit of a long lasting cleanup quest where several buses were converted to also return void from their remove callback. Additionally some resource leaks were fixed that were caused by drivers returning an error code in the expectation that the driver won't go away. With struct bus_type::remove returning void it's prevented that newly implemented buses return an ignored error code and so don't anticipate wrong expectations for driver authors. Reviewed-by: Tom Rix <trix@redhat.com> (For fpga) Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Cornelia Huck <cohuck@redhat.com> (For drivers/s390 and drivers/vfio) Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> (For ARM, Amba and related parts) Acked-by: Mark Brown <broonie@kernel.org> Acked-by: Chen-Yu Tsai <wens@csie.org> (for sunxi-rsb) Acked-by: Pali Rohár <pali@kernel.org> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> (for media) Acked-by: Hans de Goede <hdegoede@redhat.com> (For drivers/platform) Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-By: Vinod Koul <vkoul@kernel.org> Acked-by: Juergen Gross <jgross@suse.com> (For xen) Acked-by: Lee Jones <lee.jones@linaro.org> (For mfd) Acked-by: Johannes Thumshirn <jth@kernel.org> (For mcb) Acked-by: Johan Hovold <johan@kernel.org> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (For slimbus) Acked-by: Kirti Wankhede <kwankhede@nvidia.com> (For vfio) Acked-by: Maximilian Luz <luzmaximilian@gmail.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> (For ulpi and typec) Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> (For ipack) Acked-by: Geoff Levand <geoff@infradead.org> (For ps3) Acked-by: Yehezkel Bernat <YehezkelShB@gmail.com> (For thunderbolt) Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> (For intel_th) Acked-by: Dominik Brodowski <linux@dominikbrodowski.net> (For pcmcia) Acked-by: Rafael J. Wysocki <rafael@kernel.org> (For ACPI) Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> (rpmsg and apr) Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> (For intel-ish-hid) Acked-by: Dan Williams <dan.j.williams@intel.com> (For CXL, DAX, and NVDIMM) Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> (For isa) Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (For firewire) Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> (For hid) Acked-by: Thorsten Scherer <t.scherer@eckelmann.de> (For siox) Acked-by: Sven Van Asbroeck <TheSven73@gmail.com> (For anybuss) Acked-by: Ulf Hansson <ulf.hansson@linaro.org> (For MMC) Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C Acked-by: Sudeep Holla <sudeep.holla@arm.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Finn Thain <fthain@linux-m68k.org> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
124 lines
2.5 KiB
C
124 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* MDEV driver
|
|
*
|
|
* Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
|
|
* Author: Neo Jia <cjia@nvidia.com>
|
|
* Kirti Wankhede <kwankhede@nvidia.com>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/iommu.h>
|
|
#include <linux/mdev.h>
|
|
|
|
#include "mdev_private.h"
|
|
|
|
static int mdev_attach_iommu(struct mdev_device *mdev)
|
|
{
|
|
int ret;
|
|
struct iommu_group *group;
|
|
|
|
group = iommu_group_alloc();
|
|
if (IS_ERR(group))
|
|
return PTR_ERR(group);
|
|
|
|
ret = iommu_group_add_device(group, &mdev->dev);
|
|
if (!ret)
|
|
dev_info(&mdev->dev, "MDEV: group_id = %d\n",
|
|
iommu_group_id(group));
|
|
|
|
iommu_group_put(group);
|
|
return ret;
|
|
}
|
|
|
|
static void mdev_detach_iommu(struct mdev_device *mdev)
|
|
{
|
|
iommu_group_remove_device(&mdev->dev);
|
|
dev_info(&mdev->dev, "MDEV: detaching iommu\n");
|
|
}
|
|
|
|
static int mdev_probe(struct device *dev)
|
|
{
|
|
struct mdev_driver *drv =
|
|
container_of(dev->driver, struct mdev_driver, driver);
|
|
struct mdev_device *mdev = to_mdev_device(dev);
|
|
int ret;
|
|
|
|
ret = mdev_attach_iommu(mdev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (drv->probe) {
|
|
ret = drv->probe(mdev);
|
|
if (ret)
|
|
mdev_detach_iommu(mdev);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void mdev_remove(struct device *dev)
|
|
{
|
|
struct mdev_driver *drv =
|
|
container_of(dev->driver, struct mdev_driver, driver);
|
|
struct mdev_device *mdev = to_mdev_device(dev);
|
|
|
|
if (drv->remove)
|
|
drv->remove(mdev);
|
|
|
|
mdev_detach_iommu(mdev);
|
|
}
|
|
|
|
static int mdev_match(struct device *dev, struct device_driver *drv)
|
|
{
|
|
/*
|
|
* No drivers automatically match. Drivers are only bound by explicit
|
|
* device_driver_attach()
|
|
*/
|
|
return 0;
|
|
}
|
|
|
|
struct bus_type mdev_bus_type = {
|
|
.name = "mdev",
|
|
.probe = mdev_probe,
|
|
.remove = mdev_remove,
|
|
.match = mdev_match,
|
|
};
|
|
EXPORT_SYMBOL_GPL(mdev_bus_type);
|
|
|
|
/**
|
|
* mdev_register_driver - register a new MDEV driver
|
|
* @drv: the driver to register
|
|
*
|
|
* Returns a negative value on error, otherwise 0.
|
|
**/
|
|
int mdev_register_driver(struct mdev_driver *drv)
|
|
{
|
|
/* initialize common driver fields */
|
|
drv->driver.bus = &mdev_bus_type;
|
|
|
|
/* register with core */
|
|
return driver_register(&drv->driver);
|
|
}
|
|
EXPORT_SYMBOL(mdev_register_driver);
|
|
|
|
/*
|
|
* mdev_unregister_driver - unregister MDEV driver
|
|
* @drv: the driver to unregister
|
|
*/
|
|
void mdev_unregister_driver(struct mdev_driver *drv)
|
|
{
|
|
driver_unregister(&drv->driver);
|
|
}
|
|
EXPORT_SYMBOL(mdev_unregister_driver);
|
|
|
|
int mdev_bus_register(void)
|
|
{
|
|
return bus_register(&mdev_bus_type);
|
|
}
|
|
|
|
void mdev_bus_unregister(void)
|
|
{
|
|
bus_unregister(&mdev_bus_type);
|
|
}
|