Dave Chinner e2705b0304 xfs: remove xfs_inobp_check()
This debug code is called on every xfs_iflush() call, which then
checks every inode in the buffer for non-zero unlinked list field.
Hence it checks every inode in the cluster buffer every time a
single inode on that cluster it flushed. This is resulting in:

-   38.91%     5.33%  [kernel]  [k] xfs_iflush
   - 17.70% xfs_iflush
      - 9.93% xfs_inobp_check
           4.36% xfs_buf_offset

10% of the CPU time spent flushing inodes is repeatedly checking
unlinked fields in the buffer. We don't need to do this.

The other place we call xfs_inobp_check() is
xfs_iunlink_update_dinode(), and this is after we've done this
assert for the agino we are about to write into that inode:

	ASSERT(xfs_verify_agino_or_null(mp, agno, next_agino));

which means we've already checked that the agino we are about to
write is not 0 on debug kernels. The inode buffer verifiers do
everything else we need, so let's just remove this debug code.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2020-07-07 07:15:09 -07:00
..
2020-07-07 07:15:09 -07:00
2018-06-06 14:17:53 -07:00
2020-03-02 20:55:55 -08:00
2020-06-02 19:21:40 -07:00
2019-10-28 08:37:54 -07:00
2020-07-06 10:46:58 -07:00
2020-07-06 10:46:58 -07:00
2020-03-11 09:11:39 -07:00
2018-06-06 14:17:53 -07:00
2020-07-06 10:46:58 -07:00
2018-06-06 14:17:53 -07:00
2020-05-07 08:27:48 -07:00
2020-07-07 07:15:09 -07:00
2020-07-07 07:15:09 -07:00
2018-06-06 14:17:53 -07:00
2019-07-03 08:21:58 -07:00
2019-07-03 08:21:58 -07:00
2018-06-06 14:17:53 -07:00
2020-05-08 08:51:34 -07:00