linux

iv/linux

History

Will Deacon e2fc6a9f68 KVM: arm64: Fix masks in stage2_pte_cacheable()

stage2_pte_cacheable() tries to figure out whether the mapping installed
in its 'pte' parameter is cacheable or not. Unfortunately, it fails
miserably because it extracts the memory attributes from the entry using
FIELD_GET(), which returns the attributes shifted down to bit 0, but then
compares this with the unshifted value generated by the PAGE_S2_MEMATTR()
macro.

A direct consequence of this bug is that cache maintenance is silently
skipped, which in turn causes 32-bit guests to crash early on when their
set/way maintenance is trapped but not emulated correctly.

Fix the broken masks by avoiding the use of FIELD_GET() altogether.

Fixes: 6d9d2115c480 ("KVM: arm64: Add support for stage-2 map()/unmap() in generic page-table")
Reported-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: Quentin Perret <qperret@google.com>
Link: https://lore.kernel.org/r/20201029144716.30476-1-will@kernel.org

2020-10-29 19:49:03 +00:00

alpha

treewide: Use fallthrough pseudo-keyword

2020-08-23 17:36:59 -05:00

arc

ARC fixes for 5.9-rc4

2020-09-05 13:46:14 -07:00

arm

A set of fixes for lockdep, tracing and RCU:

2020-08-30 11:43:50 -07:00

arm64

KVM: arm64: Fix masks in stage2_pte_cacheable()