NeilBrown e35cb663a4 NFSD: fix possible oops when nfsd/pool_stats is closed.
[ Upstream commit 88956eabfdea7d01d550535af120d4ef265b1d02 ]

If /proc/fs/nfsd/pool_stats is open when the last nfsd thread exits, then
when the file is closed a NULL pointer is dereferenced.
This is because nfsd_pool_stats_release() assumes that the
pointer to the svc_serv cannot become NULL while a reference is held.

This used to be the case but a recent patch split nfsd_last_thread() out
from nfsd_put(), and clearing the pointer is done in nfsd_last_thread().

This is easily reproduced by running
   rpc.nfsd 8 ; ( rpc.nfsd 0;true) < /proc/fs/nfsd/pool_stats

Fortunately nfsd_pool_stats_release() has easy access to the svc_serv
pointer, and so can call svc_put() on it directly.

Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nfsd_put()")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-21 14:54:15 +02:00
..
2021-09-18 13:40:15 +02:00
2024-04-13 12:58:19 +02:00
2024-02-23 08:42:14 +01:00
2024-03-01 13:16:43 +01:00
2023-09-23 11:01:09 +02:00
2024-06-21 14:52:47 +02:00
2022-06-09 10:21:16 +02:00
2024-06-21 14:52:47 +02:00
2023-12-08 08:46:15 +01:00
2024-06-21 14:53:37 +02:00
2023-01-04 11:39:23 +01:00
2024-06-21 14:52:59 +02:00
2023-01-14 10:16:27 +01:00