iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Eric Dumazet be1ab8bf05 ipv6: fix potential NULL deref in fib6_add() 
[ Upstream commit 75475bb51e78a3f54ad2f69380f2a1c985e85f2d ]

If fib6_find_prefix() returns NULL, we should silently fallback
using fib6_null_entry regardless of RT6_DEBUG value.

syzbot reported:

WARNING: CPU: 0 PID: 5477 at net/ipv6/ip6_fib.c:1516 fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516
Modules linked in:
CPU: 0 PID: 5477 Comm: syz-executor.0 Not tainted 6.7.0-rc2-syzkaller-00029-g9b6de136b5f0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023
RIP: 0010:fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516
Code: 00 48 8b 54 24 68 e8 42 22 00 00 48 85 c0 74 14 49 89 c6 e8 d5 d3 c2 f7 eb 5d e8 ce d3 c2 f7 e9 ca 00 00 00 e8 c4 d3 c2 f7 90 <0f> 0b 90 48 b8 00 00 00 00 00 fc ff df 48 8b 4c 24 38 80 3c 01 00
RSP: 0018:ffffc90005067740 EFLAGS: 00010293
RAX: ffffffff89cba5bc RBX: ffffc90005067ab0 RCX: ffff88801a2e9dc0
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90005067980 R08: ffffffff89cbca85 R09: 1ffff110040d4b85
R10: dffffc0000000000 R11: ffffed10040d4b86 R12: 00000000ffffffff
R13: 1ffff110051c3904 R14: ffff8880206a5c00 R15: ffff888028e1c820
FS: 00007f763783c6c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f763783bff8 CR3: 000000007f74d000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__ip6_ins_rt net/ipv6/route.c:1303 [inline]
ip6_route_add+0x88/0x120 net/ipv6/route.c:3847
ipv6_route_ioctl+0x525/0x7b0 net/ipv6/route.c:4467
inet6_ioctl+0x21a/0x270 net/ipv6/af_inet6.c:575
sock_do_ioctl+0x152/0x460 net/socket.c:1220
sock_ioctl+0x615/0x8c0 net/socket.c:1339
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:871 [inline]
__se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82

Fixes: 7bbfe00e0252 ("ipv6: fix general protection fault in fib6_add()")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wei Wang <weiwan@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20231129160630.3509216-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-12-13 18:18:11 +01:00
..
6lowpan
6lowpan: iphc: Fix an off-by-one check of array index
2021-09-15 09:47:31 +02:00
9p
9p: virtio: make sure 'offs' is initialized in zc_request
2023-09-23 10:59:37 +02:00
802
mrp: introduce active flags to prevent UAF when applicant uninit
2023-01-18 11:41:37 +01:00
8021q
vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()
2023-05-30 12:44:06 +01:00
appletalk
appletalk: Fix skb allocation size in loopback case
2021-04-07 14:47:41 +02:00
atm
atm: hide unused procfs functions
2023-06-09 10:28:59 +02:00
ax25
ax25: Fix UAF bugs in ax25 timers
2022-04-20 09:19:40 +02:00
batman-adv
batman-adv: Hold rtnl lock during MTU update via netlink
2023-08-30 16:27:25 +02:00
bluetooth
Bluetooth: Fix double free in hci_conn_cleanup
2023-11-28 16:50:14 +00:00
bpf
bpf: Move skb->len == 0 checks into __bpf_redirect
2023-01-18 11:41:04 +01:00
bpfilter
bpfilter: Specify the log level for the kmsg message
2021-07-14 16:53:33 +02:00
bridge
netfilter: nf_conntrack_bridge: initialize err to 0
2023-11-28 16:50:17 +00:00
caif
net: caif: Fix use-after-free in cfusbl_device_notify()
2023-03-17 08:32:51 +01:00
can
can: bcm: Fix UAF in bcm_proc_show()
2023-07-27 08:37:40 +02:00
ceph
libceph: use kernel_connect()
2023-10-25 11:53:19 +02:00
core
net: annotate data-races around sk->sk_dst_pending_confirm
2023-11-28 16:50:14 +00:00
dcb
net: dcb: choose correct policy to parse DCB_ATTR_BCN
2023-08-11 11:53:57 +02:00
dccp
dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.
2023-11-20 10:30:15 +01:00
decnet
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
dns_resolver
…
dsa
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
2023-07-27 08:37:24 +02:00
ethernet
…
hsr
hsr: Avoid double remove of a node.
2023-01-18 11:41:09 +01:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-11-03 23:56:54 +09:00
ife
…
ipv4
ipv4: igmp: fix refcnt uaf issue when receiving igmp query packet
2023-12-08 08:44:27 +01:00
ipv6
ipv6: fix potential NULL deref in fib6_add()
2023-12-13 18:18:11 +01:00
iucv
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
2023-04-20 12:07:32 +02:00
kcm
kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().
2023-09-23 11:00:02 +02:00
key
net: af_key: fix sadb_x_filter validation
2023-08-30 16:27:16 +02:00
l2tp
ipv4, ipv6: Fix handling of transhdrlen in __ip{,6}_append_data()
2023-10-10 21:46:44 +02:00
l3mdev
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-27 13:50:47 +02:00
lapb
net: lapb: Copy the skb before sending a packet
2021-02-10 09:25:28 +01:00
llc
llc: verify mac len before reading mac header
2023-11-20 10:30:15 +01:00
mac80211
wifi: mac80211: don't return unset power in ieee80211_get_tx_power()
2023-11-28 16:50:13 +00:00
mac802154
mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()
2022-12-14 11:30:45 +01:00
mpls
net: mpls: fix stale pointer if allocation fails during device rename
2023-02-22 12:50:41 +01:00
ncsi
Revert ncsi: Propagate carrier gain/loss events to the NCSI controller
2023-11-28 16:50:21 +00:00
netfilter
netfilter: ipset: fix race condition between swap/destroy and kernel side add/del/test
2023-12-13 18:18:10 +01:00
netlabel
netlabel: fix shift wrapping bug in netlbl_catmap_setlong()
2023-09-23 10:59:39 +02:00
netlink
netlink: Add __sock_i_ino() for __netlink_diag_dump().
2023-07-27 08:37:12 +02:00
netrom
netrom: Deny concurrent connect().
2023-09-23 10:59:43 +02:00
nfc
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
2023-10-25 11:53:20 +02:00
nsh
net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()
2023-05-30 12:44:05 +01:00
openvswitch
net: openvswitch: fix flow memory leak in ovs_flow_cmd_new
2023-02-22 12:50:25 +01:00
packet
net/packet: annotate data-races around tp->status
2023-08-16 18:19:23 +02:00
phonet
phonet: refcount leak in pep_sock_accep
2022-01-11 15:23:33 +01:00
psample
…
qrtr
net: qrtr: fix another OOB Read in qrtr_endpoint_post
2021-09-03 10:08:12 +02:00
rds
net: prevent address rewrite in kernel_bind()
2023-10-25 11:53:18 +02:00
rfkill
net: rfkill: gpio: prevent value glitch during probe
2023-10-25 11:53:21 +02:00
rose
net/rose: Fix to not accept on connected socket
2023-02-22 12:50:34 +01:00
rxrpc
rxrpc: Fix hard call timeout units
2023-05-17 11:35:59 +02:00
sched
net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve
2023-10-25 11:53:21 +02:00
sctp
sctp: update hb timer immediately after users change hb_interval
2023-10-10 21:46:45 +02:00
smc
net/smc: fix dangling sock under state SMC_APPFINCLOSEWAIT
2023-11-20 10:30:16 +01:00
strparser
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-17 09:48:48 +01:00
sunrpc
SUNRPC: Mark the cred for revalidation if the server rejects it
2023-10-10 21:46:35 +02:00
switchdev
net: switchdev: do not propagate bridge updates across bridges
2021-10-27 09:54:24 +02:00
tipc
tipc: Fix kernel-infoleak due to uninitialized TLV value
2023-11-28 16:50:16 +00:00
tls
net/tls: do not free tls_rec on async operation in bpf_exec_tx_verdict()
2023-09-23 11:00:02 +02:00
unix
af_unix: Fix data-race around unix_tot_inflight.
2023-09-23 10:59:58 +02:00
vmw_vsock
vsock: avoid to close connected socket after the timeout
2023-05-30 12:44:05 +01:00
wimax
…
wireless
wifi: cfg80211: avoid leaking stack data into trace
2023-10-25 11:53:23 +02:00
x25
net/x25: Fix to not accept on connected socket
2023-02-22 12:50:26 +01:00
xdp
xsk: Honor SO_BINDTODEVICE on bind
2023-07-27 08:37:23 +02:00
xfrm
xfrm: interface: use DEV_STATS_INC()
2023-10-25 11:53:21 +02:00
compat.c
net: Return the correct errno code
2021-06-18 09:59:00 +02:00
Kconfig
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
Makefile
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
socket.c
net: prevent address rewrite in kernel_bind()
2023-10-25 11:53:18 +02:00
sysctl_net.c
…