Dave Chinner e400d27d16 xfs: fix dir3 freespace block corruption
When the directory freespace index grows to a second block (2017
4k data blocks in the directory), the initialisation of the second
new block header goes wrong. The write verifier fires a corruption
error indicating that the block number in the header is zero. This
was being tripped by xfs/110.

The problem is that the initialisation of the new block is done just
fine in xfs_dir3_free_get_buf(), but the caller then users a dirv2
structure to zero on-disk header fields that xfs_dir3_free_get_buf()
has already zeroed. These lined up with the block number in the dir
v3 header format.

While looking at this, I noticed that the struct xfs_dir3_free_hdr()
had 4 bytes of padding in it that wasn't defined as padding or being
zeroed by the initialisation. Add a pad field declaration and fully
zero the on disk and in-core headers in xfs_dir3_free_get_buf() so
that this is never an issue in the future. Note that this doesn't
change the on-disk layout, just makes the 32 bits of padding in the
layout explicit.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

(cherry picked from commit 5ae6e6a401957698f2bd8c9f4a86d86d02199fea)
2013-05-30 17:22:54 -05:00
..
2013-05-07 20:16:25 -07:00
2013-05-07 20:16:25 -07:00
2013-05-07 20:16:25 -07:00
2013-05-04 22:18:10 -05:00
2013-05-07 20:16:25 -07:00
2013-05-08 15:11:48 -07:00
2013-05-07 20:16:25 -07:00
2013-03-12 18:55:21 -07:00
2013-04-29 15:41:42 -04:00
2013-03-12 18:55:21 -07:00
2013-03-23 14:15:31 -07:00
2013-05-09 10:24:54 -07:00
2013-05-07 20:16:25 -07:00
2013-05-07 20:16:25 -07:00
2013-05-09 16:42:10 -07:00
2013-03-12 18:55:21 -07:00
2013-05-07 20:16:25 -07:00
2013-05-07 20:16:25 -07:00
2013-05-07 19:46:02 -07:00
2013-04-29 15:40:23 -04:00
2012-10-22 08:50:37 +03:00
2013-05-07 20:16:25 -07:00
2013-03-03 23:00:23 -05:00
2013-02-22 23:31:31 -05:00
2013-02-22 23:31:31 -05:00
2013-04-17 13:25:09 +01:00
2012-12-20 18:46:29 -05:00
2013-02-22 23:31:31 -05:00
2013-05-07 20:16:25 -07:00
2013-02-22 23:31:31 -05:00
2013-04-09 14:13:29 -04:00
2013-02-26 02:46:08 -05:00