linux

iv/linux

Files

Lin Ma e418bb556f NFC: reorganize the functions in nci_request

[ Upstream commit 86cdf8e387 ]

There is a possible data race as shown below:

thread-A in nci_request()       | thread-B in nci_close_device()
                                | mutex_lock(&ndev->req_lock);
test_bit(NCI_UP, &ndev->flags); |
...                             | test_and_clear_bit(NCI_UP, &ndev->flags)
mutex_lock(&ndev->req_lock);    |
                                |

This race will allow __nci_request() to be awaked while the device is
getting removed.

Similar to commit e2cb6b891a ("bluetooth: eliminate the potential race
condition when removing the HCI controller"). this patch alters the
function sequence in nci_request() to prevent the data races between the
nci_close_device().

Signed-off-by: Lin Ma <linma@zju.edu.cn>
Fixes: 6a2968aaf5 ("NFC: basic NCI protocol implementation")
Link: https://lore.kernel.org/r/20211115145600.8320-1-linma@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-11-26 10:47:20 +01:00

hci

net: nfc: fix bounds checking bugs on "pipe"

2020-03-18 07:17:41 +01:00

nci

NFC: reorganize the functions in nci_request

2021-11-26 10:47:20 +01:00

af_nfc.c

nfc: fix error handling of nfc_proto_register()

2021-10-20 11:40:16 +02:00

core.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13