52fee5c915
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). The SOF platform drivers all use either sof_of_remove() or sof_acpi_remove() which both return zero unconditionally. Change these functions to return void and the drivers to use .remove_new(). There is no semantical change. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20231009155945.285537-1-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
26 lines
627 B
C
26 lines
627 B
C
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
|
|
/*
|
|
* This file is provided under a dual BSD/GPLv2 license. When using or
|
|
* redistributing this file, you may do so under either license.
|
|
*
|
|
* Copyright 2021 NXP
|
|
*/
|
|
|
|
#ifndef __SOUND_SOC_SOF_OF_H
|
|
#define __SOUND_SOC_SOF_OF_H
|
|
|
|
struct snd_sof_of_mach {
|
|
const char *compatible;
|
|
const char *drv_name;
|
|
const char *fw_filename;
|
|
const char *sof_tplg_filename;
|
|
};
|
|
|
|
extern const struct dev_pm_ops sof_of_pm;
|
|
|
|
int sof_of_probe(struct platform_device *pdev);
|
|
void sof_of_remove(struct platform_device *pdev);
|
|
void sof_of_shutdown(struct platform_device *pdev);
|
|
|
|
#endif
|