Niklas Cassel e5e21f70bf regulator: core: Take lock before applying system load ... Take the regulator lock before applying system load. Fixes the following lockdep splat: [ 5.583581] WARNING: CPU: 1 PID: 16 at drivers/regulator/core.c:925 drms_uA_update+0x114/0x360 [ 5.588467] Modules linked in: [ 5.596833] CPU: 1 PID: 16 Comm: kworker/1:0 Not tainted 5.0.0-rc6-next-20190213-00002-g0fce66ab480f #18 [ 5.599933] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 5.609544] Workqueue: events qcom_channel_state_worker [ 5.616209] pstate: 60000005 (nZCv daif -PAN -UAO) [ 5.621152] pc : drms_uA_update+0x114/0x360 [ 5.626006] lr : drms_uA_update+0x110/0x360 [ 5.630084] sp : ffff0000124b3490 [ 5.634242] x29: ffff0000124b3490 x28: ffff800005326e00 [ 5.637735] x27: ffff0000124b35f8 x26: 000000000032bc48 [ 5.643117] x25: ffff800004c7e800 x24: ffff800004c6d500 [ 5.648411] x23: ffff800004c38a80 x22: 00000000000000d1 [ 5.653706] x21: 00000000001ab3f0 x20: ffff800004c7e800 [ 5.659001] x19: ffff0000114c3000 x18: ffffffffffffffff [ 5.664297] x17: 0000000000000000 x16: 0000000000000000 [ 5.669592] x15: ffff0000114c3808 x14: 0720072007200720 [ 5.674888] x13: 00000000199c9b28 x12: ffff80002bcccc40 [ 5.680183] x11: ffff000012286000 x10: ffff0000114c3808 [ 5.685477] x9 : 0720072007200720 x8 : ffff000010e9e808 [ 5.690772] x7 : ffff0000106da568 x6 : 0000000000000000 [ 5.696067] x5 : 0000000000000000 x4 : 0000000000000000 [ 5.701362] x3 : 0000000000000004 x2 : 0000000000000000 [ 5.706658] x1 : 0000000000000000 x0 : 0000000000000000 [ 5.711952] Call trace: [ 5.717223] drms_uA_update+0x114/0x360 [ 5.719405] regulator_register+0xb30/0x1140 [ 5.723230] devm_regulator_register+0x4c/0xa8 [ 5.727745] rpm_reg_probe+0xfc/0x1b0 [ 5.731992] platform_drv_probe+0x50/0xa0 [ 5.735727] really_probe+0x20c/0x2b8 [ 5.739718] driver_probe_device+0x58/0x100 [ 5.743368] __device_attach_driver+0x90/0xd0 [ 5.747363] bus_for_each_drv+0x64/0xc8 [ 5.751870] __device_attach+0xd8/0x138 [ 5.755516] device_initial_probe+0x10/0x18 [ 5.759341] bus_probe_device+0x98/0xa0 [ 5.763502] device_add+0x3d0/0x640 [ 5.767319] of_device_add+0x48/0x58 [ 5.770793] of_platform_device_create_pdata+0xb0/0x128 [ 5.774629] of_platform_bus_create+0x174/0x370 [ 5.779569] of_platform_populate+0x78/0xe0 [ 5.784082] qcom_smd_rpm_probe+0x80/0xa0 [ 5.788245] rpmsg_dev_probe+0x114/0x1a0 [ 5.792411] really_probe+0x20c/0x2b8 [ 5.796401] driver_probe_device+0x58/0x100 [ 5.799964] __device_attach_driver+0x90/0xd0 [ 5.803960] bus_for_each_drv+0x64/0xc8 [ 5.808468] __device_attach+0xd8/0x138 [ 5.812115] device_initial_probe+0x10/0x18 [ 5.815936] bus_probe_device+0x98/0xa0 [ 5.820099] device_add+0x3d0/0x640 [ 5.823916] device_register+0x1c/0x28 [ 5.827391] rpmsg_register_device+0x4c/0x90 [ 5.831216] qcom_channel_state_worker+0x170/0x298 [ 5.835651] process_one_work+0x294/0x6e8 [ 5.840241] worker_thread+0x40/0x450 [ 5.844318] kthread+0x11c/0x120 [ 5.847961] ret_from_fork+0x10/0x18 [ 5.851260] irq event stamp: 9090 [ 5.854820] hardirqs last enabled at (9089): [<ffff000010160798>] console_unlock+0x3e0/0x5b0 [ 5.858086] hardirqs last disabled at (9090): [<ffff0000100817cc>] do_debug_exception+0x104/0x140 [ 5.866596] softirqs last enabled at (9086): [<ffff000010082024>] __do_softirq+0x474/0x574 [ 5.875446] softirqs last disabled at (9079): [<ffff0000100f2254>] irq_exit+0x13c/0x148 [ 5.883598] ---[ end trace 6984ef7f081afa21 ]--- Fixes: fa94e48e13 ("regulator: core: Apply system load even if no consumer loads") Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> Signed-off-by: Mark Brown <broonie@kernel.org>		2019-02-15 17:45:11 +00:00
..
accessibility
acpi	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
amba
android
ata	for-4.21/libata-20190102	2019-01-02 18:47:56 -08:00
atm
auxdisplay	auxdisplay: charlcd: fix x/y command parsing	2018-12-21 21:27:21 +01:00
base	Merge branch 'mount.part1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-01-05 13:25:58 -08:00
bcma
block	block: sunvdc: don't run hw queue synchronously from irq context	2019-01-03 08:21:47 -07:00
bluetooth
bus	ARM: SoC driver updates	2018-12-31 17:32:35 -08:00
cdrom	gdrom: fix a memory leak bug	2018-12-29 08:20:44 -07:00
char	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
clk	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-01-02 18:56:59 -08:00
clocksource	arch/csky patches for 4.21-rc1	2019-01-05 09:50:07 -08:00
connector
cpufreq	powerpc updates for 4.21	2018-12-27 10:43:24 -08:00
cpuidle	powerpc updates for 4.21	2018-12-27 10:43:24 -08:00
crypto	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
dax	mm, devm_memremap_pages: fix shutdown handling	2018-12-28 12:11:47 -08:00
dca
devfreq
dio
dma	Merge branch 'next/drivers' into next/late	2019-01-04 14:31:38 -08:00
dma-buf	drivers/dma-buf/udmabuf.c: convert to use vm_fault_t	2019-01-04 13:13:46 -08:00
edac
eisa
extcon
firewire	FireWire (IEEE 1394) subsystem patch:	2019-01-05 18:33:21 -08:00
firmware	arm64 fixes for -rc1	2019-01-05 11:28:39 -08:00
fmc
fpga	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
fsi
gnss
gpio	This is the bulk of GPIO changes for the v4.21 kernel series:	2018-12-28 20:00:21 -08:00
gpu	drm i915 gvt, amdgpu, core fixes	2019-01-05 18:25:19 -08:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid	2019-01-05 17:53:40 -08:00
hsi
hv	Char/Misc driver patches for 4.21-rc1	2018-12-28 20:54:57 -08:00
hwmon	Kconfig updates for v4.21	2018-12-29 13:03:29 -08:00
hwspinlock	hwspinlock: fix return value check in stm32_hwspinlock_probe()	2019-01-03 11:42:10 -08:00
hwtracing
i2c	Merge branch 'i2c/for-5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2019-01-05 18:13:35 -08:00
i3c
ide	for-4.21/block-20181221	2018-12-28 13:19:59 -08:00
idle
iio	Staging/IIO driver patches for 4.21-rc1	2018-12-28 20:39:58 -08:00
infiniband	4.21 merge window 2nd pull request	2019-01-05 18:20:51 -08:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-01-02 18:56:59 -08:00
iommu	IOMMU Updates for Linux v4.21	2019-01-01 15:55:29 -08:00
ipack
irqchip	Xtensa updates for v4.21:	2018-12-29 09:40:40 -08:00
isdn	isdn: fix kernel-infoleak in capi_unlocked_ioctl	2019-01-02 10:31:39 -08:00
leds	LEDs for 4.21-rc1	2018-12-25 14:52:50 -08:00
lightnvm	lightnvm: pblk: fix use-after-free bug	2018-12-22 14:45:35 -07:00
macintosh	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
mailbox	mailbox: tegra-hsp: Use device-managed registration API	2018-12-21 22:31:26 -06:00
mcb
md	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md into for-linus	2019-01-03 08:21:02 -07:00
media	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
memory	ARM: SoC: late updates	2019-01-05 11:30:37 -08:00
memstick	MMC core:	2018-12-28 16:52:18 -08:00
message
mfd
misc	Merge branch 'i2c/for-5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2019-01-05 18:13:35 -08:00
mmc	MMC core:	2018-12-28 16:52:18 -08:00
mtd	Kbuild updates for v4.21	2018-12-29 12:03:17 -08:00
mux
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-01-03 12:53:47 -08:00
nfc
ntb
nubus
nvdimm	Merge branch 'akpm' (patches from Andrew)	2018-12-28 16:55:46 -08:00
nvme
nvmem
of	Merge tag 'devicetree-for-4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux	2018-12-28 20:08:34 -08:00
opp
oprofile
parisc	Kconfig file consolidation for v4.21	2018-12-29 13:40:29 -08:00
parport
pci	pci-v4.21-changes	2019-01-05 17:57:34 -08:00
pcmcia	Included in this update:	2019-01-05 11:23:17 -08:00
perf	drivers/perf: hisi: Fixup one DDRC PMU register offset	2019-01-04 10:13:27 +00:00
phy
pinctrl	Pin control bulk changes for the v4.21 kernel cycle:	2019-01-01 13:19:16 -08:00
platform	chrome platform changes for v4.21	2019-01-06 11:40:06 -08:00
pnp	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
power	power supply and reset changes for the v4.21 series	2018-12-28 20:22:45 -08:00
powercap
pps	Kconfig updates for v4.21	2018-12-29 13:03:29 -08:00
ps3
ptp	Char/Misc driver patches for 4.21-rc1	2018-12-28 20:54:57 -08:00
pwm	pwm: imx: Add ipg clock operation	2018-12-24 12:06:56 +01:00
rapidio
ras	treewide: surround Kconfig file paths with double quotes	2018-12-22 00:25:54 +09:00
regulator	regulator: core: Take lock before applying system load	2019-02-15 17:45:11 +00:00
remoteproc
reset
rpmsg
rtc	RTC for 4.21	2019-01-01 13:24:31 -08:00
s390	s390 updates for the 4.21 merge window	2019-01-02 18:37:01 -08:00
sbus	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next	2018-12-26 10:32:18 -08:00
scsi	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
sfi
sh
siox
slimbus
sn
soc	ARM: SoC driver updates	2018-12-31 17:32:35 -08:00
soundwire
spi	spi: Updates for v4.21	2018-12-25 14:43:54 -08:00
spmi
ssb
staging	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
target	SCSI misc on 20181224	2018-12-28 14:48:06 -08:00
tc
tee	OP-TEE dynamic shm log message	2018-12-31 13:06:30 -08:00
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2019-01-05 16:07:28 -08:00
thunderbolt
tty	ARM: SoC: late updates	2019-01-05 11:30:37 -08:00
uio	Char/Misc driver patches for 4.21-rc1	2018-12-28 20:54:57 -08:00
usb	pci-v4.21-changes	2019-01-05 17:57:34 -08:00
uwb
vfio	IOMMU Updates for Linux v4.21	2019-01-01 15:55:29 -08:00
vhost	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
video	fbdev changes for v4.21:	2019-01-05 18:15:37 -08:00
virt
virtio	virtio, vhost: features, fixes, cleanups	2019-01-02 18:54:45 -08:00
visorbus
vlynq
vme
w1	treewide: surround Kconfig file paths with double quotes	2018-12-22 00:25:54 +09:00
watchdog	linux-watchdog 4.21-rc1 tag	2019-01-01 13:16:45 -08:00
xen	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
zorro
Kconfig	Kconfig file consolidation for v4.21	2018-12-29 13:40:29 -08:00
Makefile