Okash Khawaja e5f5d0e20b staging: speakup: fix speakup-r empty line lockup
When cursor is at beginning of an empty or whitespace-only line and
speakup-r typed, kernel locks up. This happens because deadlock of in
input_event function over dev->event_lock, as demonstrated by lockdep
logs. The reason for that is speakup simulates a down arrow - because
cursor is at an empty line - while inside key press notifier handler
which is ultimately triggered from input_event function. The simulated
key press leads to input_event being called again, this time under its
own context. So the spinlock is dev->event_lock is acquired while still
being held.

This patch ensures that key press is not simulated from inside key press
notifier handler. Instead it delegates to cursor_timer. It starts the
timer and passes RA_DOWN_ARROW as argument. When timer handler runs and
sees RA_DOWN_ARROW, it will then call kbd_fakekey2(RA_DOWN_ARROW) which
will correctly simulate the keypress inside timer context.

When not inside key press notifier callback, the behaviour will remain
the same as before this patch.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-09-18 12:25:31 +02:00
..
2017-09-12 20:03:53 -07:00
2017-09-10 20:40:00 -07:00
2017-09-07 14:03:05 -07:00
2017-09-07 14:03:05 -07:00
2017-09-07 13:51:13 -07:00
2017-09-15 17:52:52 -07:00
2017-09-07 12:53:14 -07:00
2017-09-14 17:34:43 +02:00
2017-09-07 13:51:13 -07:00
2017-09-09 15:03:24 -07:00
2017-09-05 11:08:17 -07:00
2017-09-10 20:40:00 -07:00
2017-08-29 13:46:35 +02:00
2017-09-12 13:30:06 -07:00
2017-09-05 11:08:17 -07:00
2017-09-11 13:04:32 -07:00
2017-09-07 13:51:13 -07:00
2017-09-09 14:34:38 -07:00
2017-09-13 10:56:00 -07:00
2017-09-13 10:47:14 -07:00
2017-09-05 12:45:03 -07:00
2017-09-05 12:45:03 -07:00
2017-08-30 14:03:42 -06:00
2017-09-14 13:33:33 -07:00
2017-09-07 21:11:05 -07:00