linux

iv/linux

History

Xuan Zhuo d5c0ed17fe virtio: packed: fix unmap leak for indirect desc table

When use_dma_api and premapped are true, then the do_unmap is false.

Because the do_unmap is false, vring_unmap_extra_packed is not called by
detach_buf_packed.

  if (unlikely(vq->do_unmap)) {
                curr = id;
                for (i = 0; i < state->num; i++) {
                        vring_unmap_extra_packed(vq,
                                                 &vq->packed.desc_extra[curr]);
                        curr = vq->packed.desc_extra[curr].next;
                }
  }

So the indirect desc table is not unmapped. This causes the unmap leak.

So here, we check vq->use_dma_api instead. Synchronously, dma info is
updated based on use_dma_api judgment

This bug does not occur, because no driver use the premapped with
indirect.

Fixes: b319940f83c2 ("virtio_ring: skip unmap for premapped")
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Message-Id: <20240223071833.26095-1-xuanzhuo@linux.alibaba.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

2024-03-19 03:19:22 -04:00

Kconfig

virtio-pci: Initialize the supported admin commands

2023-12-19 11:51:32 -07:00

Makefile

virtio-pci: Introduce APIs to execute legacy IO admin commands

2023-12-19 11:51:33 -07:00

virtio_anchor.c

virtio: replace restricted mem access flag with callback

2022-08-01 07:42:49 +02:00

virtio_balloon.c

virtio: features, fixes