linux

iv/linux

History

Zhang Lei e644fa18e2 KVM: arm64/sve: Fix vq_present() macro to yield a bool

The original implementation of vq_present() relied on aggressive
inlining in order for the compiler to know that the code is
correct, due to some const-casting issues.  This was causing sparse
and clang to complain, while GCC compiled cleanly.

Commit 0c529ff789bc addressed this problem, but since vq_present()
is no longer a function, there is now no implicit casting of the
returned value to the return type (bool).

In set_sve_vls(), this uncast bit value is compared against a bool,
and so may spuriously compare as unequal when both are nonzero.  As
a result, KVM may reject valid SVE vector length configurations as
invalid, and vice versa.

Fix it by forcing the returned value to a bool.

Signed-off-by: Zhang Lei <zhang.lei@jp.fujitsu.com>
Fixes: 0c529ff789bc ("KVM: arm64: Implement vq_present() as a macro")
Signed-off-by: Dave Martin <Dave.Martin@arm.com> [commit message rewrite]
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

2019-07-05 12:07:51 +02:00

hyp

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234

2019-06-19 17:09:07 +02:00

debug.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234

2019-06-19 17:09:07 +02:00

fpsimd.c

KVM: arm64/sve: Context switch the SVE registers

2019-03-29 14:41:53 +00:00

guest.c

KVM: arm64/sve: Fix vq_present() macro to yield a bool