linux

iv/linux

History

Dan Carpenter ccc89737aa scsi: qedf: Fix error codes in qedf_alloc_global_queues()

This driver has some left over "return 1" on failure style code mixed with
"return negative error codes" style code.  The caller doesn't care so we
should just convert everything to return negative error codes.

Then there was a problem that there were two variables used to store error
codes which just resulted in confusion.  If qedf_alloc_bdq() returned a
negative error code, we accidentally returned success instead of
propagating the error code.  So get rid of the "rc" variable and use
"status" every where.

Also remove the "status = 0" initialization so that these sorts of bugs
will be detected by the compiler in the future.

Link: https://lore.kernel.org/r/20210810085023.GA23998@kili
Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

2021-08-16 13:27:57 -04:00

drv_fcoe_fw_funcs.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 440

2019-06-05 17:37:17 +02:00

drv_fcoe_fw_funcs.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 440

2019-06-05 17:37:17 +02:00

drv_scsi_fw_funcs.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 440

2019-06-05 17:37:17 +02:00

drv_scsi_fw_funcs.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 440