Eric Sandeen e6da7c9fed xfs: fix overflow in xfs_growfs_data_private
In the case where growing a filesystem would leave the last AG
too small, the fixup code has an overflow in the calculation
of the new size with one fewer ag, because "nagcount" is a 32
bit number.  If the new filesystem has > 2^32 blocks in it
this causes a problem resulting in an EINVAL return from growfs:

 # xfs_io -f -c "truncate 19998630180864" fsfile
 # mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b fsfile
 # mount -o loop fsfile /mnt
 # xfs_growfs /mnt

meta-data=/dev/loop0             isize=256    agcount=52,
agsize=76288719 blks
         =                       sectsz=512   attr=2
data     =                       bsize=4096   blocks=3905982455, imaxpct=5
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0
log      =internal               bsize=4096   blocks=32768, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=0
realtime =none                   extsz=4096   blocks=0, rtextents=0
xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Invalid argument

Reported-by: richard.ems@cape-horn-eng.com
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
2009-06-01 22:59:38 -05:00
..
2009-03-29 09:51:00 +02:00
2009-03-30 10:21:31 +02:00
2009-03-29 19:26:46 +02:00
2008-07-28 16:58:35 +10:00
2009-04-30 00:29:02 -05:00
2009-03-29 19:26:46 +02:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:55:42 +02:00
2008-02-07 18:14:38 +11:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:51:14 +02:00
2009-03-29 09:51:08 +02:00
2007-10-15 16:49:49 +10:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:51:08 +02:00
2007-10-15 16:49:49 +10:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:51:08 +02:00
2008-12-01 11:37:35 +11:00
2008-10-30 17:53:24 +11:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:55:42 +02:00
2009-04-06 18:40:17 +02:00
2009-03-29 09:55:42 +02:00
2009-04-06 18:49:12 +02:00
2009-04-06 18:49:12 +02:00
2009-03-29 09:55:42 +02:00
2009-03-16 08:24:13 +01:00
2009-03-16 08:24:13 +01:00
2009-03-16 08:19:29 +01:00
2009-03-29 09:55:42 +02:00
2008-12-11 13:13:33 +11:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:55:42 +02:00
2009-03-29 09:55:42 +02:00
2008-10-30 16:55:13 +11:00