iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/mm
History
Linus Torvalds 69bf4b6b54 Revert "mm: page cache: store only head pages in i_pages" 
This reverts commit 5fd4ca2d84b249f0858ce28cf637cf25b61a398f.

Mikhail Gavrilov reports that it causes the VM_BUG_ON_PAGE() in
__delete_from_swap_cache() to trigger:

   page:ffffd6d34dff0000 refcount:1 mapcount:1 mapping:ffff97812323a689 index:0xfecec363
   anon
   flags: 0x17fffe00080034(uptodate|lru|active|swapbacked)
   raw: 0017fffe00080034 ffffd6d34c67c508 ffffd6d3504b8d48 ffff97812323a689
   raw: 00000000fecec363 0000000000000000 0000000100000000 ffff978433ace000
   page dumped because: VM_BUG_ON_PAGE(entry != page)
   page->mem_cgroup:ffff978433ace000
   ------------[ cut here ]------------
   kernel BUG at mm/swap_state.c:170!
   invalid opcode: 0000 [#1] SMP NOPTI
   CPU: 1 PID: 221 Comm: kswapd0 Not tainted 5.2.0-0.rc2.git0.1.fc31.x86_64 #1
   Hardware name: System manufacturer System Product Name/ROG STRIX X470-I GAMING, BIOS 2202 04/11/2019
   RIP: 0010:__delete_from_swap_cache+0x20d/0x240
   Code: 30 65 48 33 04 25 28 00 00 00 75 4a 48 83 c4 38 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 c7 c6 2f dc 0f 8a 48 89 c7 e8 93 1b fd ff <0f> 0b 48 c7 c6 a8 74 0f 8a e8 85 1b fd ff 0f 0b 48 c7 c6 a8 7d 0f
   RSP: 0018:ffffa982036e7980 EFLAGS: 00010046
   RAX: 0000000000000021 RBX: 0000000000000040 RCX: 0000000000000006
   RDX: 0000000000000000 RSI: 0000000000000086 RDI: ffff97843d657900
   RBP: 0000000000000001 R08: ffffa982036e7835 R09: 0000000000000535
   R10: ffff97845e21a46c R11: ffffa982036e7835 R12: ffff978426387120
   R13: 0000000000000000 R14: ffffd6d34dff0040 R15: ffffd6d34dff0000
   FS:  0000000000000000(0000) GS:ffff97843d640000(0000) knlGS:0000000000000000
   CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
   CR2: 00002cba88ef5000 CR3: 000000078a97c000 CR4: 00000000003406e0
   Call Trace:
    delete_from_swap_cache+0x46/0xa0
    try_to_free_swap+0xbc/0x110
    swap_writepage+0x13/0x70
    pageout.isra.0+0x13c/0x350
    shrink_page_list+0xc14/0xdf0
    shrink_inactive_list+0x1e5/0x3c0
    shrink_node_memcg+0x202/0x760
    shrink_node+0xe0/0x470
    balance_pgdat+0x2d1/0x510
    kswapd+0x220/0x420
    kthread+0xfb/0x130
    ret_from_fork+0x22/0x40

and it's not immediately obvious why it happens.  It's too late in the
rc cycle to do anything but revert for now.

Link: https://lore.kernel.org/lkml/CABXGCsN9mYmBD-4GaaeW_NrDu+FDXLzr_6x+XNxfmFV6QkYCDg@mail.gmail.com/
Reported-and-bisected-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Suggested-by: Jan Kara <jack@suse.cz>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Kirill Shutemov <kirill@shutemov.name>
Cc: William Kucharski <william.kucharski@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-07-05 19:55:18 -07:00
..
kasan
kasan: initialize tag to 0xff in __kasan_kmalloc
2019-06-01 15:51:31 -07:00
backing-dev.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
balloon_compaction.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
cleancache.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482
2019-06-19 17:09:52 +02:00
cma_debug.c
mm/cma_debug.c: fix the break condition in cma_maxchunk_get()
2019-05-14 09:47:45 -07:00
cma.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 98
2019-05-24 17:37:54 +02:00
cma.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compaction.c
mm, compaction: make sure we isolate a valid PFN
2019-06-01 15:51:32 -07:00
debug_page_ref.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debug.c
mm: update references to page _refcount
2019-05-14 19:52:47 -07:00
dmapool.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 403
2019-06-05 17:37:13 +02:00
early_ioremap.c
mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep
2017-12-11 14:54:44 +01:00
fadvise.c
vfs: implement readahead(2) using POSIX_FADV_WILLNEED
2018-08-30 20:01:32 +02:00
failslab.c
mm: no need to check return value of debugfs_create functions
2019-03-05 21:07:17 -08:00
filemap.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
frame_vector.c
mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'
2017-12-14 16:00:48 -08:00
frontswap.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482
2019-06-19 17:09:52 +02:00
gup_benchmark.c
mm/gup: replace get_user_pages_longterm() with FOLL_LONGTERM
2019-05-14 09:47:45 -07:00
gup.c
mm/gup: continue VM_FAULT_RETRY processing even for pre-faults
2019-06-01 15:51:31 -07:00
highmem.c
mm: convert totalram_pages and totalhigh_pages variables to atomic
2018-12-28 12:11:47 -08:00
hmm.c
mm/devm_memremap_pages: fix final page put race
2019-06-13 17:34:56 -10:00
huge_memory.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
hugetlb_cgroup.c
mm: rename page_counter's count/limit into usage/max
2018-06-07 17:34:35 -07:00
hugetlb.c
mm: hugetlb: soft-offline: dissolve_free_huge_page() return zero on !PageHuge
2019-06-29 16:43:45 +08:00
hwpoison-inject.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
init-mm.c
mm: Allocate the mm_cpumask (mm->cpu_bitmap[]) dynamically based on nr_cpu_ids
2018-07-17 09:35:30 +02:00
internal.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
interval_tree.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 248
2019-06-19 17:09:08 +02:00
Kconfig
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
Kconfig.debug
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
khugepaged.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
kmemleak-test.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
kmemleak.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
ksm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482
2019-06-19 17:09:52 +02:00
list_lru.c
mm/list_lru.c: fix memory leak in __memcg_init_list_lru_node
2019-06-13 17:34:56 -10:00
maccess.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
madvise.c
mm/mmu_notifier: use correct mmu_notifier events for each invalidation
2019-05-14 09:47:49 -07:00
Makefile
mm: shuffle initial free memory to improve memory-side-cache utilization
2019-05-14 19:52:48 -07:00
memblock.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
memcontrol.c
mm: memcontrol: don't batch updates of local VM stats and events
2019-06-13 17:34:56 -10:00
memfd.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
memory_hotplug.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
memory-failure.c
mm: hugetlb: soft-offline: dissolve_free_huge_page() return zero on !PageHuge
2019-06-29 16:43:45 +08:00
memory.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
mempolicy.c
mm/mempolicy.c: fix an incorrect rebind node in mpol_rebind_nodemask
2019-06-29 16:43:44 +08:00
mempool.c
docs/core-api/mm: fix return value descriptions in mm/
2019-03-05 21:07:20 -08:00
memtest.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
migrate.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
mincore.c
mm/mincore.c: make mincore() more conservative
2019-05-14 19:52:48 -07:00
mlock.c
mm/mlock.c: change count_mm_mlocked_page_nr return type
2019-06-13 17:34:56 -10:00
mm_init.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
mmap.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
mmu_context.c
sched/headers: Prepare to move the task_lock()/unlock() APIs to <linux/sched/task.h>
2017-03-02 08:42:38 +01:00
mmu_gather.c
mm: mmu_gather: remove __tlb_reset_range() for force flush
2019-06-13 17:34:56 -10:00
mmu_notifier.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 499
2019-06-19 17:09:53 +02:00
mmzone.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mprotect.c
mm/mprotect.c: fix compilation warning because of unused 'mm' variable
2019-05-14 09:47:51 -07:00
mremap.c
mm/mmu_notifier: contextual information for event triggering invalidation
2019-05-14 09:47:49 -07:00
msync.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nommu.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
oom_kill.c
mm/oom_kill.c: fix uninitialized oc->constraint
2019-06-29 16:43:45 +08:00
page_alloc.c
mm/page_alloc.c: fix regression with deferred struct page init
2019-07-05 11:12:07 +09:00
page_counter.c
memcg: introduce memory.min
2018-06-07 17:34:36 -07:00
page_ext.c
memblock: drop memblock_alloc_*_nopanic() variants
2019-03-12 10:04:02 -07:00
page_idle.c
mm/page_idle.c: fix oops because end_pfn is larger than max_pfn
2019-06-29 16:43:45 +08:00
page_io.c
swap_readpage(): avoid blk_wake_io_task() if !synchronous
2019-07-05 11:12:07 +09:00
page_isolation.c
mm/page_isolation.c: remove redundant pfn_valid_within() in __first_valid_page()
2019-05-14 09:47:46 -07:00
page_owner.c
mm/page_owner: Simplify stack trace handling
2019-04-29 12:37:50 +02:00
page_poison.c
page_poison: play nicely with KASAN
2019-03-05 21:07:13 -08:00
page_vma_mapped.c
mm/rmap: map_pte() was not handling private ZONE_DEVICE page properly
2018-10-31 08:54:11 -07:00
page-writeback.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
pagewalk.c
mm: kernel-doc: add missing parameter descriptions
2018-04-05 21:36:27 -07:00
percpu-internal.h
percpu: convert chunk hints to be based on pcpu_block_md
2019-03-13 12:25:31 -07:00
percpu-km.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
percpu-stats.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
percpu-vm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
percpu.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
pgtable-generic.c
x86/mm: Page size aware flush_tlb_mm_range()
2018-10-09 16:51:11 +02:00
process_vm_access.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
quicklist.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
readahead.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
rmap.c
mm/rmap.c: use the pra.mapcount to do the check
2019-05-14 09:47:49 -07:00
rodata_test.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
shmem.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
shuffle.c
mm: maintain randomization of page free lists
2019-05-14 19:52:48 -07:00
shuffle.h
mm: maintain randomization of page free lists
2019-05-14 19:52:48 -07:00
slab_common.c
mm: add support for kmem caches in DMA32 zone
2019-03-29 10:01:37 -07:00
slab.c
slab: remove /proc/slab_allocators
2019-05-16 15:51:55 -07:00
slab.h
mm: add support for kmem caches in DMA32 zone
2019-03-29 10:01:37 -07:00
slob.c
slob: use slab_list instead of lru
2019-05-14 09:47:44 -07:00
slub.c
mm/slub.c: update the comment about slab frozen
2019-05-14 09:47:45 -07:00
sparse-vmemmap.c
mm: remove include/linux/bootmem.h
2018-10-31 08:54:16 -07:00
sparse.c
mm/sparse.c: clean up obsolete code comment
2019-05-14 09:47:48 -07:00
swap_cgroup.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
swap_slots.c
mm, swap, get_swap_pages: use entry_size instead of cluster in parameter
2018-08-22 10:52:44 -07:00
swap_state.c
Revert "mm: page cache: store only head pages in i_pages"
2019-07-05 19:55:18 -07:00
swap.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
swapfile.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
truncate.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
usercopy.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
userfaultfd.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 499
2019-06-19 17:09:53 +02:00
util.c
prctl_set_mm: downgrade mmap_sem to read lock
2019-06-01 15:51:31 -07:00
vmacache.c
mm: get rid of vmacache_flush_all() entirely
2018-09-13 15:18:04 -10:00
vmalloc.c
mm/vmalloc.c: avoid bogus -Wmaybe-uninitialized warning
2019-06-29 16:43:45 +08:00
vmpressure.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
vmscan.c
mm/vmscan.c: prevent useless kswapd loops
2019-07-05 11:12:07 +09:00
vmstat.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
workingset.c
mm: memcontrol: make cgroup stats and events query API explicitly local
2019-05-14 19:52:53 -07:00
z3fold.c
z3fold: fix sheduling while atomic
2019-06-01 15:51:31 -07:00
zbud.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
zpool.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
zsmalloc.c
mm/zsmalloc.c: fix fall-through annotation
2018-10-26 16:26:35 -07:00
zswap.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00