iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
e78f6046937441a0fb6f482b286c1f77df5eda0c
linux/net/core
History
Eric Dumazet 84c510411e packet: annotate data-races around ignore_outgoing 
[ Upstream commit 6ebfad3316 ]

ignore_outgoing is read locklessly from dev_queue_xmit_nit()
and packet_getsockopt()

Add appropriate READ_ONCE()/WRITE_ONCE() annotations.

syzbot reported:

BUG: KCSAN: data-race in dev_queue_xmit_nit / packet_setsockopt

write to 0xffff888107804542 of 1 bytes by task 22618 on cpu 0:
 packet_setsockopt+0xd83/0xfd0 net/packet/af_packet.c:4003
 do_sock_setsockopt net/socket.c:2311 [inline]
 __sys_setsockopt+0x1d8/0x250 net/socket.c:2334
 __do_sys_setsockopt net/socket.c:2343 [inline]
 __se_sys_setsockopt net/socket.c:2340 [inline]
 __x64_sys_setsockopt+0x66/0x80 net/socket.c:2340
 do_syscall_64+0xd3/0x1d0
 entry_SYSCALL_64_after_hwframe+0x6d/0x75

read to 0xffff888107804542 of 1 bytes by task 27 on cpu 1:
 dev_queue_xmit_nit+0x82/0x620 net/core/dev.c:2248
 xmit_one net/core/dev.c:3527 [inline]
 dev_hard_start_xmit+0xcc/0x3f0 net/core/dev.c:3547
 __dev_queue_xmit+0xf24/0x1dd0 net/core/dev.c:4335
 dev_queue_xmit include/linux/netdevice.h:3091 [inline]
 batadv_send_skb_packet+0x264/0x300 net/batman-adv/send.c:108
 batadv_send_broadcast_skb+0x24/0x30 net/batman-adv/send.c:127
 batadv_iv_ogm_send_to_if net/batman-adv/bat_iv_ogm.c:392 [inline]
 batadv_iv_ogm_emit net/batman-adv/bat_iv_ogm.c:420 [inline]
 batadv_iv_send_outstanding_bat_ogm_packet+0x3f0/0x4b0 net/batman-adv/bat_iv_ogm.c:1700
 process_one_work kernel/workqueue.c:3254 [inline]
 process_scheduled_works+0x465/0x990 kernel/workqueue.c:3335
 worker_thread+0x526/0x730 kernel/workqueue.c:3416
 kthread+0x1d1/0x210 kernel/kthread.c:388
 ret_from_fork+0x4b/0x60 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:243

value changed: 0x00 -> 0x01

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 27 Comm: kworker/u8:1 Tainted: G        W          6.8.0-syzkaller-08073-g480e035fc4c7 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet

Fixes: fa788d986a ("packet: add sockopt to ignore outgoing packets")
Reported-by: syzbot+c669c1136495a2e7c31f@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/CANn89i+Z7MfbkBLOv=p7KZ7=K1rKHO4P1OL5LYDCtBiyqsa9oQ@mail.gmail.com/T/#t
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-03-26 18:22:25 -04:00
..
bpf_sk_storage.c
bpf: Improve bucket_log calculation logic
2020-02-14 16:34:10 -05:00
datagram.c
net: datagram: fix data-races in datagram_poll()
2023-05-30 12:44:02 +01:00
datagram.h
…
dev_addr_lists.c
net: remove unnecessary variables and callback
2019-10-24 14:53:49 -07:00
dev_ioctl.c
net: fix dev_ifsioc_locked() race condition
2021-03-07 12:20:43 +01:00
dev.c
packet: annotate data-races around ignore_outgoing
2024-03-26 18:22:25 -04:00
devlink.c
devlink: remove reload failed checks in params get/set callbacks
2023-09-23 11:00:03 +02:00
drop_monitor.c
drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group
2023-12-13 18:18:17 +01:00
dst_cache.c
…
dst.c
ipv6: remove max_size check inline with ipv4
2024-01-15 18:25:29 +01:00
ethtool.c
net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats
2023-01-24 07:17:58 +01:00
failover.c
…
fib_notifier.c
net: fib_notifier: move fib_notifier_ops from struct net into per-net struct
2019-09-07 17:28:22 +02:00
fib_rules.c
ipv6: fix memory leak in fib6_rule_suppress
2021-12-08 09:01:13 +01:00
filter.c
bpf: sockmap, updating the sg structure should also update curr
2023-12-13 18:18:13 +01:00
flow_dissector.c
net/ipv6: SKB symmetric hash should incorporate transport ports
2023-09-23 10:59:56 +02:00
flow_offload.c
net: core: rename indirect block ingress cb function
2019-12-18 16:08:47 +01:00
gen_estimator.c
net_sched: gen_estimator: support large ewma log
2021-02-07 15:35:47 +01:00
gen_stats.c
…
gro_cells.c
…
hwbm.c
…
link_watch.c
net: linkwatch: fix failure to restore device state across suspend/resume
2021-08-18 08:57:00 +02:00
lwt_bpf.c
lwt: Fix return values of BPF xmit ops
2023-09-23 10:59:42 +02:00
lwtunnel.c
lwtunnel: Validate RTA_ENCAP_TYPE attribute length
2022-01-11 15:23:32 +01:00
Makefile
…
neighbour.c
neighbour: Don't let neigh_forced_gc() disable preemption for long
2024-01-25 14:34:20 -08:00
net_namespace.c
net: fix UaF in netns ops registration error path
2023-02-06 07:52:45 +01:00
net-procfs.c
net-procfs: show net devices bound packet types
2022-02-01 17:24:37 +01:00
net-sysfs.c
net-sysfs: add check for netdevice being present to speed_show
2022-03-16 13:21:46 +01:00
net-sysfs.h
…
net-traces.c
…
netclassid_cgroup.c
cgroup, netclassid: remove double cond_resched
2020-05-10 10:31:32 +02:00
netevent.c
…
netpoll.c
net: don't let netpoll invoke NAPI if in xmit context
2023-04-20 12:07:33 +02:00
netprio_cgroup.c
netprio_cgroup: Fix unlimited memory leak of v2 cgroups
2020-05-20 08:20:12 +02:00
page_pool.c
mm: fix struct page layout on 32-bit systems
2021-05-19 10:08:31 +02:00
pktgen.c
net: pktgen: Fix interface flags printing
2023-10-25 11:53:22 +02:00
ptp_classifier.c
…
request_sock.c
tcp: add rcu protection around tp->fastopen_rsk
2019-10-13 10:13:08 -07:00
rtnetlink.c
rtnetlink: fix error logic of IFLA_BRIDGE_FLAGS writing back
2024-03-06 14:36:09 +00:00
scm.c
io_uring/unix: drop usage of io_uring socket
2024-03-26 18:22:12 -04:00
secure_seq.c
tcp: Fix data-races around sysctl knobs related to SYN option.
2022-07-29 17:14:14 +02:00
skbuff.c
net: prevent mss overflow in skb_segment()
2024-02-23 08:25:14 +01:00
skmsg.c
bpf, sockmap: Fix memleak in tcp_bpf_sendmsg while sk msg is full
2022-04-15 14:18:16 +02:00
sock_diag.c
sock_diag: annotate data-races around sock_diag_handlers[family]
2024-03-26 18:22:14 -04:00
sock_map.c
bpf: sockmap: Remove preempt_disable in sock_map_sk_acquire
2023-08-11 11:53:57 +02:00
sock_reuseport.c
udp: Prevent reuseport_select_sock from reading uninitialized socks
2021-01-23 15:57:56 +01:00
sock.c
net: Implement missing SO_TIMESTAMPING_NEW cmsg support
2024-01-15 18:25:27 +01:00
stream.c
net: Remove WARN_ON_ONCE(sk->sk_forward_alloc) from sk_stream_kill_queues().
2023-03-03 11:41:48 +01:00
sysctl_net_core.c
net: Fix data-races around weight_p and dev_weight_[rt]x_bias.
2022-09-05 10:27:41 +02:00
timestamping.c
…
tso.c
net: Use skb accessors in network core
2019-07-22 20:47:56 -07:00
utils.c
net: Fix skb->csum update in inet_proto_csum_replace16().
2020-02-05 21:22:52 +00:00
xdp.c
xdp: obtain the mem_id mutex before trying to remove an entry.
2019-12-18 16:09:10 +01:00