Miklos Szeredi 8110e16d42 vfs: dcache: fix deadlock in tree traversal
IBM reported a deadlock in select_parent().  This was found to be caused
by taking rename_lock when already locked when restarting the tree
traversal.

There are two cases when the traversal needs to be restarted:

 1) concurrent d_move(); this can only happen when not already locked,
    since taking rename_lock protects against concurrent d_move().

 2) racing with final d_put() on child just at the moment of ascending
    to parent; rename_lock doesn't protect against this rare race, so it
    can happen when already locked.

Because of case 2, we need to be able to handle restarting the traversal
when rename_lock is already held.  This patch fixes all three callers of
try_to_ascend().

IBM reported that the deadlock is gone with this patch.

[ I rewrote the patch to be smaller and just do the "goto again" if the
  lock was already held, but credit goes to Miklos for the real work.
   - Linus ]

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-09-29 17:41:40 -07:00
..
2012-07-14 16:34:32 +04:00
2012-07-30 17:25:16 -07:00
2012-07-14 16:38:34 +04:00
2012-08-17 06:56:39 -07:00
2012-07-14 16:34:32 +04:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:38:34 +04:00
2012-07-16 14:24:43 -05:00
2012-07-14 16:34:32 +04:00
2012-09-04 18:45:54 +02:00
2012-08-04 12:15:38 +04:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:34:47 +04:00
2012-07-30 17:25:19 -07:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:34:47 +04:00
2012-07-30 17:25:16 -07:00
2012-07-14 16:34:32 +04:00
2012-07-14 16:34:47 +04:00
2012-08-22 17:41:09 +03:00
2012-07-22 23:58:16 +04:00
2012-07-14 16:34:47 +04:00
2012-08-20 10:11:47 -07:00
2012-07-30 17:25:21 -07:00
2012-07-14 16:32:47 +04:00
2012-07-14 16:38:34 +04:00
2012-07-14 16:32:48 +04:00
2012-08-22 10:30:10 -04:00
2012-09-22 20:48:18 -04:00
2012-08-04 01:24:44 +04:00