Eric Dumazet
a0c2dc1fe6
nfc: fix memory leak in llcp_sock_bind() ...
sysbot reported a memory leak after a bind() has failed.
While we are at it, abort the operation if kmemdup() has failed.
BUG: memory leak
unreferenced object 0xffff888105d83ec0 (size 32):
comm "syz-executor067", pid 7207, jiffies 4294956228 (age 19.430s)
hex dump (first 32 bytes):
00 69 6c 65 20 72 65 61 64 00 6e 65 74 3a 5b 34 .ile read.net:[4
30 32 36 35 33 33 30 39 37 5d 00 00 00 00 00 00 026533097]......
backtrace:
[<0000000036bac473>] kmemleak_alloc_recursive /./include/linux/kmemleak.h:43 [inline]
[<0000000036bac473>] slab_post_alloc_hook /mm/slab.h:522 [inline]
[<0000000036bac473>] slab_alloc /mm/slab.c:3319 [inline]
[<0000000036bac473>] __do_kmalloc /mm/slab.c:3653 [inline]
[<0000000036bac473>] __kmalloc_track_caller+0x169/0x2d0 /mm/slab.c:3670
[<000000000cd39d07>] kmemdup+0x27/0x60 /mm/util.c:120
[<000000008e57e5fc>] kmemdup /./include/linux/string.h:432 [inline]
[<000000008e57e5fc>] llcp_sock_bind+0x1b3/0x230 /net/nfc/llcp_sock.c:107
[<000000009cb0b5d3>] __sys_bind+0x11c/0x140 /net/socket.c:1647
[<00000000492c3bbc>] __do_sys_bind /net/socket.c:1658 [inline]
[<00000000492c3bbc>] __se_sys_bind /net/socket.c:1656 [inline]
[<00000000492c3bbc>] __x64_sys_bind+0x1e/0x30 /net/socket.c:1656
[<0000000008704b2a>] do_syscall_64+0x76/0x1a0 /arch/x86/entry/common.c:296
[<000000009f4c57a4>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: 30cc4587659e ("NFC: Move LLCP code to the NFC top level diirectory")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-10-04 18:31:36 -07:00
2019-07-06 12:50:01 +02:00
2019-09-27 15:10:34 -07:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-09-24 16:37:18 +02:00
2019-09-05 12:33:28 +02:00
2019-09-24 16:37:18 +02:00
2019-10-01 18:42:15 +02:00
2019-09-18 12:34:53 -07:00
2019-07-25 18:00:41 -07:00
2019-07-12 16:03:16 -07:00
2019-09-15 14:17:27 +02:00
2019-05-30 11:29:22 -07:00
2019-09-04 14:22:33 +02:00
2019-09-16 12:06:25 +02:00
2019-10-04 14:30:23 -07:00
2019-05-30 11:29:52 -07:00
2019-10-01 18:42:15 +02:00
2019-05-24 17:36:42 +02:00
2019-07-10 18:43:43 -07:00
2019-10-02 12:19:53 -04:00
2019-06-07 11:00:14 -07:00
2019-07-11 14:37:45 -07:00
2019-09-24 16:37:18 +02:00
2019-09-26 08:56:17 +02:00
2019-10-04 17:27:04 -07:00
2019-10-04 18:08:58 -07:00
2019-07-29 10:26:14 -07:00
2019-09-27 10:27:14 +02:00
2019-07-08 19:48:57 -07:00
2019-10-01 18:42:15 +02:00
2019-06-23 13:24:17 -07:00
2019-06-17 20:20:36 -07:00
2019-06-05 17:36:36 +02:00
2019-10-01 17:56:19 +02:00
2019-05-30 11:26:41 -07:00
2019-08-25 14:34:08 -07:00
2019-09-19 18:04:40 -07:00
2019-10-01 18:42:15 +02:00
2019-09-01 11:45:02 -07:00
2019-06-14 19:50:33 -07:00
2019-07-24 15:49:05 -07:00
2019-10-04 18:31:36 -07:00
2019-06-19 17:09:55 +02:00
2019-10-01 18:42:15 +02:00
2019-10-01 18:42:15 +02:00
2019-06-05 17:37:07 +02:00
2019-09-16 09:18:03 +02:00
2019-09-21 18:45:46 -07:00
2019-10-02 12:16:57 -04:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2019-09-15 14:17:27 +02:00
2019-10-04 18:28:30 -07:00
2019-10-01 18:42:15 +02:00
2019-08-20 12:25:14 -07:00
2019-06-22 08:59:24 -04:00
2019-09-27 17:00:27 -07:00
2019-05-30 11:26:32 -07:00
2019-10-02 11:02:05 -04:00
2019-09-07 18:10:34 +02:00
2019-06-07 11:00:14 -07:00
2019-10-01 21:23:35 -04:00
2019-08-10 15:25:47 -07:00
2019-10-01 17:56:19 +02:00
2019-05-24 17:27:12 +02:00
2019-09-28 17:47:33 -07:00
2019-10-01 18:42:15 +02:00
2019-05-31 15:30:03 -06:00
2019-08-17 12:40:08 -07:00
2019-07-19 10:42:02 -07:00
2019-05-21 10:50:45 +02:00
a0c2dc1fe6