Remi Pommarel
ea38c0d9aa
batman-adv: Fix batadv_v_ogm_aggr_send memory leak ...
commit 421d467dc2d483175bad4fb76a31b9e5a3d744cf upstream.
When batadv_v_ogm_aggr_send is called for an inactive interface, the skb
is silently dropped by batadv_v_ogm_send_to_if() but never freed causing
the following memory leak:
unreferenced object 0xffff00000c164800 (size 512):
comm "kworker/u8:1", pid 2648, jiffies 4295122303 (age 97.656s)
hex dump (first 32 bytes):
00 80 af 09 00 00 ff ff e1 09 00 00 75 01 60 83 ............u.`.
1f 00 00 00 b8 00 00 00 15 00 05 00 da e3 d3 64 ...............d
backtrace:
[<0000000007ad20f6>] __kmalloc_track_caller+0x1a8/0x310
[<00000000d1029e55>] kmalloc_reserve.constprop.0+0x70/0x13c
[<000000008b9d4183>] __alloc_skb+0xec/0x1fc
[<00000000c7af5051>] __netdev_alloc_skb+0x48/0x23c
[<00000000642ee5f5>] batadv_v_ogm_aggr_send+0x50/0x36c
[<0000000088660bd7>] batadv_v_ogm_aggr_work+0x24/0x40
[<0000000042fc2606>] process_one_work+0x3b0/0x610
[<000000002f2a0b1c>] worker_thread+0xa0/0x690
[<0000000059fae5d4>] kthread+0x1fc/0x210
[<000000000c587d3a>] ret_from_fork+0x10/0x20
Free the skb in that case to fix this leak.
Cc: stable@vger.kernel.org
Fixes: 0da0035942d4 ("batman-adv: OGMv2 - add basic infrastructure")
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-30 16:18:17 +02:00
2023-04-20 12:13:53 +02:00
2022-12-31 13:14:42 +01:00
2023-05-24 17:36:52 +01:00
2023-06-09 10:32:26 +02:00
2022-06-22 14:22:01 +02:00
2023-08-30 16:18:17 +02:00
2023-08-26 14:23:25 +02:00
2022-12-31 13:14:11 +01:00
2023-07-27 08:46:59 +02:00
2023-03-17 08:48:54 +01:00
2023-08-30 16:18:13 +02:00
2023-08-11 15:13:55 +02:00
2023-08-30 16:18:15 +02:00
2023-08-11 15:13:53 +02:00
2023-08-30 16:18:14 +02:00
2023-07-23 13:47:30 +02:00
2023-05-17 11:50:18 +02:00
2023-04-05 11:25:02 +02:00
2022-11-03 23:59:14 +09:00
2023-08-26 14:23:38 +02:00
2023-08-26 14:23:32 +02:00
2023-03-22 13:31:28 +01:00
2022-11-26 09:24:50 +01:00
2023-08-26 14:23:32 +02:00
2023-04-26 13:51:54 +02:00
2022-04-27 14:38:53 +02:00
2023-07-27 08:47:02 +02:00
2023-06-09 10:32:25 +02:00
2022-12-14 11:37:25 +01:00
2023-02-06 07:59:02 +01:00
2023-02-22 12:57:09 +01:00
2023-07-05 18:25:04 +01:00
2023-08-30 16:18:16 +02:00
2023-08-30 16:18:15 +02:00
2022-04-13 20:59:10 +02:00
2023-07-23 13:46:56 +02:00
2023-06-09 10:32:16 +02:00
2023-07-23 13:46:56 +02:00
2023-05-24 17:36:51 +01:00
2023-02-22 12:57:09 +01:00
2023-08-16 18:22:01 +02:00
2022-01-11 15:35:16 +01:00
2023-04-20 12:13:53 +02:00
2023-03-10 09:39:16 +01:00
2022-04-08 14:23:00 +02:00
2023-02-22 12:57:02 +01:00
2023-05-17 11:50:17 +02:00
2023-08-30 16:18:15 +02:00
2023-08-30 16:18:13 +02:00
2023-06-14 11:13:01 +02:00
2021-11-18 19:17:11 +01:00
2023-08-30 16:18:10 +02:00
2023-08-03 10:22:37 +02:00
2023-08-26 14:23:22 +02:00
2023-08-26 14:23:38 +02:00
2023-05-24 17:36:49 +01:00
2023-08-11 15:13:49 +02:00
2023-02-09 11:26:40 +01:00
2023-08-16 18:22:01 +02:00
2023-08-26 14:23:33 +02:00
2023-06-21 15:59:15 +02:00
2023-06-21 15:59:15 +02:00
2023-05-24 17:36:42 +01:00
ea38c0d9aa