eb929a91b2
The current criteria for returning POLLOUT from a group member socket is too simplistic. It basically returns POLLOUT as soon as the group has external destinations, something obviously leading to a lot of spinning during destination congestion situations. At the same time, the internal congestion handling is unnecessarily complex. We now change this as follows. - We introduce an 'open' flag in struct tipc_group. This flag is used only to help poll() get the setting of POLLOUT right, and *not* for congeston handling as such. This means that a user can choose to ignore an EAGAIN for a destination and go on sending messages to other destinations in the group if he wants to. - The flag is set to false every time we return EAGAIN on a send call. - The flag is set to true every time any member, i.e., not necessarily the member that caused EAGAIN, is removed from the small_win list. - We remove the group member 'usr_pending' flag. The size of the send window and presence in the 'small_win' list is sufficient criteria for recognizing congestion. This solution seems to be a reasonable compromise between 'anycast', which is normally not waiting for POLLOUT for a specific destination, and the other three send modes, which are. Acked-by: Ying Xue <ying.xue@windriver.com> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
76 lines
3.4 KiB
C
76 lines
3.4 KiB
C
/*
|
|
* net/tipc/group.h: Include file for TIPC group unicast/multicast functions
|
|
*
|
|
* Copyright (c) 2017, Ericsson AB
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the names of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
* Software Foundation.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef _TIPC_GROUP_H
|
|
#define _TIPC_GROUP_H
|
|
|
|
#include "core.h"
|
|
|
|
struct tipc_group;
|
|
struct tipc_member;
|
|
struct tipc_msg;
|
|
|
|
struct tipc_group *tipc_group_create(struct net *net, u32 portid,
|
|
struct tipc_group_req *mreq);
|
|
void tipc_group_join(struct net *net, struct tipc_group *grp, int *sk_rcv_buf);
|
|
void tipc_group_delete(struct net *net, struct tipc_group *grp);
|
|
void tipc_group_add_member(struct tipc_group *grp, u32 node,
|
|
u32 port, u32 instance);
|
|
struct tipc_nlist *tipc_group_dests(struct tipc_group *grp);
|
|
void tipc_group_self(struct tipc_group *grp, struct tipc_name_seq *seq,
|
|
int *scope);
|
|
u32 tipc_group_exclude(struct tipc_group *grp);
|
|
void tipc_group_filter_msg(struct tipc_group *grp,
|
|
struct sk_buff_head *inputq,
|
|
struct sk_buff_head *xmitq);
|
|
void tipc_group_member_evt(struct tipc_group *grp, bool *wakeup,
|
|
int *sk_rcvbuf, struct tipc_msg *hdr,
|
|
struct sk_buff_head *inputq,
|
|
struct sk_buff_head *xmitq);
|
|
void tipc_group_proto_rcv(struct tipc_group *grp, bool *wakeup,
|
|
struct tipc_msg *hdr,
|
|
struct sk_buff_head *inputq,
|
|
struct sk_buff_head *xmitq);
|
|
void tipc_group_update_bc_members(struct tipc_group *grp, int len, bool ack);
|
|
bool tipc_group_cong(struct tipc_group *grp, u32 dnode, u32 dport,
|
|
int len, struct tipc_member **m);
|
|
bool tipc_group_bc_cong(struct tipc_group *grp, int len);
|
|
bool tipc_group_is_open(struct tipc_group *grp);
|
|
void tipc_group_update_rcv_win(struct tipc_group *grp, int blks, u32 node,
|
|
u32 port, struct sk_buff_head *xmitq);
|
|
u16 tipc_group_bc_snd_nxt(struct tipc_group *grp);
|
|
void tipc_group_update_member(struct tipc_member *m, int len);
|
|
#endif
|