Ryan Roberts ec056cef76 mm/readahead: do not allow order-1 folio
The THP machinery does not support order-1 folios because it requires meta
data spanning the first 3 `struct page`s.  So order-2 is the smallest
large folio that we can safely create.

There was a theoretical bug whereby if ra->size was 2 or 3 pages (due to
the device-specific bdi->ra_pages being set that way), we could end up
with order = 1.  Fix this by unconditionally checking if the preferred
order is 1 and if so, set it to 0.  Previously this was done in a few
specific places, but with this refactoring it is done just once,
unconditionally, at the end of the calculation.

This is a theoretical bug found during review of the code; I have no
evidence to suggest this manifests in the real world (I expect all
device-specific ra_pages values are much bigger than 3).

Link: https://lkml.kernel.org/r/20231201161045.3962614-1-ryan.roberts@arm.com
Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2023-12-12 10:57:06 -08:00
..
2023-09-08 12:16:52 -07:00
2023-06-09 16:25:17 -07:00
2023-06-19 16:19:25 -07:00
2023-04-12 17:36:23 -07:00
2023-08-31 12:20:12 -07:00
2022-10-03 14:02:43 -07:00
2023-10-04 10:32:19 -07:00
2023-10-30 18:01:41 -10:00
2023-07-18 10:07:47 +02:00
2023-10-25 16:47:11 -07:00
2023-06-23 16:59:30 -07:00
2023-12-12 10:57:01 -08:00
2023-04-12 17:36:23 -07:00
2023-11-15 15:30:09 -08:00