54d7989f47
Looks like a quiet cycle for vhost/virtio, just a couple of minor tweaks. Most notable is automatic interrupt affinity for blk and scsi. Hopefully other devices are not far behind. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> -----BEGIN PGP SIGNATURE----- iQEcBAABAgAGBQJYt1rRAAoJECgfDbjSjVRpEZsIALSHevdXWtRHBZUb0ZkqPLQb /x2Vn49CcALS1p7iSuP9L027MPeaLKyr0NBT9hptBChp/4b9lnZWyyAo6vYQrzfx Ia/hLBYsK4ml6lEwbyfLwqkF2cmYCrZhBSVAILifn84lTPoN7CT0PlYDfA+OCaNR geo75qF8KR+AUO0aqchwMRL3RV3OxZKxQr2AR6LttCuhiBgnV3Xqxffg/M3x6ONM 0ffFFdodm6slem3hIEiGUMwKj4NKQhcOleV+y0fVBzWfLQG9210pZbQyRBRikIL0 7IsaarpaUr7OrLAZFMGF6nJnyRAaRrt6WknTHZkyvyggrePrGcmGgPm4jrODwY4= =2zwv -----END PGP SIGNATURE----- Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost Pull vhost updates from Michael Tsirkin: "virtio, vhost: optimizations, fixes Looks like a quiet cycle for vhost/virtio, just a couple of minor tweaks. Most notable is automatic interrupt affinity for blk and scsi. Hopefully other devices are not far behind" * tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost: virtio-console: avoid DMA from stack vhost: introduce O(1) vq metadata cache virtio_scsi: use virtio IRQ affinity virtio_blk: use virtio IRQ affinity blk-mq: provide a default queue mapping for virtio device virtio: provide a method to get the IRQ affinity mask for a virtqueue virtio: allow drivers to request IRQ affinity when creating VQs virtio_pci: simplify MSI-X setup virtio_pci: don't duplicate the msix_enable flag in struct pci_dev virtio_pci: use shared interrupts for virtqueues virtio_pci: remove struct virtio_pci_vq_info vhost: try avoiding avail index access when getting descriptor virtio_mmio: expose header to userspace
541 lines
12 KiB
C
541 lines
12 KiB
C
/* Driver for Virtio crypto device.
|
|
*
|
|
* Copyright 2016 HUAWEI TECHNOLOGIES CO., LTD.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/module.h>
|
|
#include <linux/virtio_config.h>
|
|
#include <linux/cpu.h>
|
|
|
|
#include <uapi/linux/virtio_crypto.h>
|
|
#include "virtio_crypto_common.h"
|
|
|
|
|
|
void
|
|
virtcrypto_clear_request(struct virtio_crypto_request *vc_req)
|
|
{
|
|
if (vc_req) {
|
|
kzfree(vc_req->iv);
|
|
kzfree(vc_req->req_data);
|
|
kfree(vc_req->sgs);
|
|
}
|
|
}
|
|
|
|
static void virtcrypto_dataq_callback(struct virtqueue *vq)
|
|
{
|
|
struct virtio_crypto *vcrypto = vq->vdev->priv;
|
|
struct virtio_crypto_request *vc_req;
|
|
unsigned long flags;
|
|
unsigned int len;
|
|
struct ablkcipher_request *ablk_req;
|
|
int error;
|
|
unsigned int qid = vq->index;
|
|
|
|
spin_lock_irqsave(&vcrypto->data_vq[qid].lock, flags);
|
|
do {
|
|
virtqueue_disable_cb(vq);
|
|
while ((vc_req = virtqueue_get_buf(vq, &len)) != NULL) {
|
|
if (vc_req->type == VIRTIO_CRYPTO_SYM_OP_CIPHER) {
|
|
switch (vc_req->status) {
|
|
case VIRTIO_CRYPTO_OK:
|
|
error = 0;
|
|
break;
|
|
case VIRTIO_CRYPTO_INVSESS:
|
|
case VIRTIO_CRYPTO_ERR:
|
|
error = -EINVAL;
|
|
break;
|
|
case VIRTIO_CRYPTO_BADMSG:
|
|
error = -EBADMSG;
|
|
break;
|
|
default:
|
|
error = -EIO;
|
|
break;
|
|
}
|
|
ablk_req = vc_req->ablkcipher_req;
|
|
|
|
spin_unlock_irqrestore(
|
|
&vcrypto->data_vq[qid].lock, flags);
|
|
/* Finish the encrypt or decrypt process */
|
|
virtio_crypto_ablkcipher_finalize_req(vc_req,
|
|
ablk_req, error);
|
|
spin_lock_irqsave(
|
|
&vcrypto->data_vq[qid].lock, flags);
|
|
}
|
|
}
|
|
} while (!virtqueue_enable_cb(vq));
|
|
spin_unlock_irqrestore(&vcrypto->data_vq[qid].lock, flags);
|
|
}
|
|
|
|
static int virtcrypto_find_vqs(struct virtio_crypto *vi)
|
|
{
|
|
vq_callback_t **callbacks;
|
|
struct virtqueue **vqs;
|
|
int ret = -ENOMEM;
|
|
int i, total_vqs;
|
|
const char **names;
|
|
struct device *dev = &vi->vdev->dev;
|
|
|
|
/*
|
|
* We expect 1 data virtqueue, followed by
|
|
* possible N-1 data queues used in multiqueue mode,
|
|
* followed by control vq.
|
|
*/
|
|
total_vqs = vi->max_data_queues + 1;
|
|
|
|
/* Allocate space for find_vqs parameters */
|
|
vqs = kcalloc(total_vqs, sizeof(*vqs), GFP_KERNEL);
|
|
if (!vqs)
|
|
goto err_vq;
|
|
callbacks = kcalloc(total_vqs, sizeof(*callbacks), GFP_KERNEL);
|
|
if (!callbacks)
|
|
goto err_callback;
|
|
names = kcalloc(total_vqs, sizeof(*names), GFP_KERNEL);
|
|
if (!names)
|
|
goto err_names;
|
|
|
|
/* Parameters for control virtqueue */
|
|
callbacks[total_vqs - 1] = NULL;
|
|
names[total_vqs - 1] = "controlq";
|
|
|
|
/* Allocate/initialize parameters for data virtqueues */
|
|
for (i = 0; i < vi->max_data_queues; i++) {
|
|
callbacks[i] = virtcrypto_dataq_callback;
|
|
snprintf(vi->data_vq[i].name, sizeof(vi->data_vq[i].name),
|
|
"dataq.%d", i);
|
|
names[i] = vi->data_vq[i].name;
|
|
}
|
|
|
|
ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks,
|
|
names, NULL);
|
|
if (ret)
|
|
goto err_find;
|
|
|
|
vi->ctrl_vq = vqs[total_vqs - 1];
|
|
|
|
for (i = 0; i < vi->max_data_queues; i++) {
|
|
spin_lock_init(&vi->data_vq[i].lock);
|
|
vi->data_vq[i].vq = vqs[i];
|
|
/* Initialize crypto engine */
|
|
vi->data_vq[i].engine = crypto_engine_alloc_init(dev, 1);
|
|
if (!vi->data_vq[i].engine) {
|
|
ret = -ENOMEM;
|
|
goto err_engine;
|
|
}
|
|
|
|
vi->data_vq[i].engine->cipher_one_request =
|
|
virtio_crypto_ablkcipher_crypt_req;
|
|
}
|
|
|
|
kfree(names);
|
|
kfree(callbacks);
|
|
kfree(vqs);
|
|
|
|
return 0;
|
|
|
|
err_engine:
|
|
err_find:
|
|
kfree(names);
|
|
err_names:
|
|
kfree(callbacks);
|
|
err_callback:
|
|
kfree(vqs);
|
|
err_vq:
|
|
return ret;
|
|
}
|
|
|
|
static int virtcrypto_alloc_queues(struct virtio_crypto *vi)
|
|
{
|
|
vi->data_vq = kcalloc(vi->max_data_queues, sizeof(*vi->data_vq),
|
|
GFP_KERNEL);
|
|
if (!vi->data_vq)
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void virtcrypto_clean_affinity(struct virtio_crypto *vi, long hcpu)
|
|
{
|
|
int i;
|
|
|
|
if (vi->affinity_hint_set) {
|
|
for (i = 0; i < vi->max_data_queues; i++)
|
|
virtqueue_set_affinity(vi->data_vq[i].vq, -1);
|
|
|
|
vi->affinity_hint_set = false;
|
|
}
|
|
}
|
|
|
|
static void virtcrypto_set_affinity(struct virtio_crypto *vcrypto)
|
|
{
|
|
int i = 0;
|
|
int cpu;
|
|
|
|
/*
|
|
* In single queue mode, we don't set the cpu affinity.
|
|
*/
|
|
if (vcrypto->curr_queue == 1 || vcrypto->max_data_queues == 1) {
|
|
virtcrypto_clean_affinity(vcrypto, -1);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* In multiqueue mode, we let the queue to be private to one cpu
|
|
* by setting the affinity hint to eliminate the contention.
|
|
*
|
|
* TODO: adds cpu hotplug support by register cpu notifier.
|
|
*
|
|
*/
|
|
for_each_online_cpu(cpu) {
|
|
virtqueue_set_affinity(vcrypto->data_vq[i].vq, cpu);
|
|
if (++i >= vcrypto->max_data_queues)
|
|
break;
|
|
}
|
|
|
|
vcrypto->affinity_hint_set = true;
|
|
}
|
|
|
|
static void virtcrypto_free_queues(struct virtio_crypto *vi)
|
|
{
|
|
kfree(vi->data_vq);
|
|
}
|
|
|
|
static int virtcrypto_init_vqs(struct virtio_crypto *vi)
|
|
{
|
|
int ret;
|
|
|
|
/* Allocate send & receive queues */
|
|
ret = virtcrypto_alloc_queues(vi);
|
|
if (ret)
|
|
goto err;
|
|
|
|
ret = virtcrypto_find_vqs(vi);
|
|
if (ret)
|
|
goto err_free;
|
|
|
|
get_online_cpus();
|
|
virtcrypto_set_affinity(vi);
|
|
put_online_cpus();
|
|
|
|
return 0;
|
|
|
|
err_free:
|
|
virtcrypto_free_queues(vi);
|
|
err:
|
|
return ret;
|
|
}
|
|
|
|
static int virtcrypto_update_status(struct virtio_crypto *vcrypto)
|
|
{
|
|
u32 status;
|
|
int err;
|
|
|
|
virtio_cread(vcrypto->vdev,
|
|
struct virtio_crypto_config, status, &status);
|
|
|
|
/*
|
|
* Unknown status bits would be a host error and the driver
|
|
* should consider the device to be broken.
|
|
*/
|
|
if (status & (~VIRTIO_CRYPTO_S_HW_READY)) {
|
|
dev_warn(&vcrypto->vdev->dev,
|
|
"Unknown status bits: 0x%x\n", status);
|
|
|
|
virtio_break_device(vcrypto->vdev);
|
|
return -EPERM;
|
|
}
|
|
|
|
if (vcrypto->status == status)
|
|
return 0;
|
|
|
|
vcrypto->status = status;
|
|
|
|
if (vcrypto->status & VIRTIO_CRYPTO_S_HW_READY) {
|
|
err = virtcrypto_dev_start(vcrypto);
|
|
if (err) {
|
|
dev_err(&vcrypto->vdev->dev,
|
|
"Failed to start virtio crypto device.\n");
|
|
|
|
return -EPERM;
|
|
}
|
|
dev_info(&vcrypto->vdev->dev, "Accelerator is ready\n");
|
|
} else {
|
|
virtcrypto_dev_stop(vcrypto);
|
|
dev_info(&vcrypto->vdev->dev, "Accelerator is not ready\n");
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int virtcrypto_start_crypto_engines(struct virtio_crypto *vcrypto)
|
|
{
|
|
int32_t i;
|
|
int ret;
|
|
|
|
for (i = 0; i < vcrypto->max_data_queues; i++) {
|
|
if (vcrypto->data_vq[i].engine) {
|
|
ret = crypto_engine_start(vcrypto->data_vq[i].engine);
|
|
if (ret)
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
|
|
err:
|
|
while (--i >= 0)
|
|
if (vcrypto->data_vq[i].engine)
|
|
crypto_engine_exit(vcrypto->data_vq[i].engine);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void virtcrypto_clear_crypto_engines(struct virtio_crypto *vcrypto)
|
|
{
|
|
u32 i;
|
|
|
|
for (i = 0; i < vcrypto->max_data_queues; i++)
|
|
if (vcrypto->data_vq[i].engine)
|
|
crypto_engine_exit(vcrypto->data_vq[i].engine);
|
|
}
|
|
|
|
static void virtcrypto_del_vqs(struct virtio_crypto *vcrypto)
|
|
{
|
|
struct virtio_device *vdev = vcrypto->vdev;
|
|
|
|
virtcrypto_clean_affinity(vcrypto, -1);
|
|
|
|
vdev->config->del_vqs(vdev);
|
|
|
|
virtcrypto_free_queues(vcrypto);
|
|
}
|
|
|
|
static int virtcrypto_probe(struct virtio_device *vdev)
|
|
{
|
|
int err = -EFAULT;
|
|
struct virtio_crypto *vcrypto;
|
|
u32 max_data_queues = 0, max_cipher_key_len = 0;
|
|
u32 max_auth_key_len = 0;
|
|
u64 max_size = 0;
|
|
|
|
if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
|
|
return -ENODEV;
|
|
|
|
if (!vdev->config->get) {
|
|
dev_err(&vdev->dev, "%s failure: config access disabled\n",
|
|
__func__);
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (num_possible_nodes() > 1 && dev_to_node(&vdev->dev) < 0) {
|
|
/*
|
|
* If the accelerator is connected to a node with no memory
|
|
* there is no point in using the accelerator since the remote
|
|
* memory transaction will be very slow.
|
|
*/
|
|
dev_err(&vdev->dev, "Invalid NUMA configuration.\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
vcrypto = kzalloc_node(sizeof(*vcrypto), GFP_KERNEL,
|
|
dev_to_node(&vdev->dev));
|
|
if (!vcrypto)
|
|
return -ENOMEM;
|
|
|
|
virtio_cread(vdev, struct virtio_crypto_config,
|
|
max_dataqueues, &max_data_queues);
|
|
if (max_data_queues < 1)
|
|
max_data_queues = 1;
|
|
|
|
virtio_cread(vdev, struct virtio_crypto_config,
|
|
max_cipher_key_len, &max_cipher_key_len);
|
|
virtio_cread(vdev, struct virtio_crypto_config,
|
|
max_auth_key_len, &max_auth_key_len);
|
|
virtio_cread(vdev, struct virtio_crypto_config,
|
|
max_size, &max_size);
|
|
|
|
/* Add virtio crypto device to global table */
|
|
err = virtcrypto_devmgr_add_dev(vcrypto);
|
|
if (err) {
|
|
dev_err(&vdev->dev, "Failed to add new virtio crypto device.\n");
|
|
goto free;
|
|
}
|
|
vcrypto->owner = THIS_MODULE;
|
|
vcrypto = vdev->priv = vcrypto;
|
|
vcrypto->vdev = vdev;
|
|
|
|
spin_lock_init(&vcrypto->ctrl_lock);
|
|
|
|
/* Use single data queue as default */
|
|
vcrypto->curr_queue = 1;
|
|
vcrypto->max_data_queues = max_data_queues;
|
|
vcrypto->max_cipher_key_len = max_cipher_key_len;
|
|
vcrypto->max_auth_key_len = max_auth_key_len;
|
|
vcrypto->max_size = max_size;
|
|
|
|
dev_info(&vdev->dev,
|
|
"max_queues: %u, max_cipher_key_len: %u, max_auth_key_len: %u, max_size 0x%llx\n",
|
|
vcrypto->max_data_queues,
|
|
vcrypto->max_cipher_key_len,
|
|
vcrypto->max_auth_key_len,
|
|
vcrypto->max_size);
|
|
|
|
err = virtcrypto_init_vqs(vcrypto);
|
|
if (err) {
|
|
dev_err(&vdev->dev, "Failed to initialize vqs.\n");
|
|
goto free_dev;
|
|
}
|
|
|
|
err = virtcrypto_start_crypto_engines(vcrypto);
|
|
if (err)
|
|
goto free_vqs;
|
|
|
|
virtio_device_ready(vdev);
|
|
|
|
err = virtcrypto_update_status(vcrypto);
|
|
if (err)
|
|
goto free_engines;
|
|
|
|
return 0;
|
|
|
|
free_engines:
|
|
virtcrypto_clear_crypto_engines(vcrypto);
|
|
free_vqs:
|
|
vcrypto->vdev->config->reset(vdev);
|
|
virtcrypto_del_vqs(vcrypto);
|
|
free_dev:
|
|
virtcrypto_devmgr_rm_dev(vcrypto);
|
|
free:
|
|
kfree(vcrypto);
|
|
return err;
|
|
}
|
|
|
|
static void virtcrypto_free_unused_reqs(struct virtio_crypto *vcrypto)
|
|
{
|
|
struct virtio_crypto_request *vc_req;
|
|
int i;
|
|
struct virtqueue *vq;
|
|
|
|
for (i = 0; i < vcrypto->max_data_queues; i++) {
|
|
vq = vcrypto->data_vq[i].vq;
|
|
while ((vc_req = virtqueue_detach_unused_buf(vq)) != NULL) {
|
|
kfree(vc_req->req_data);
|
|
kfree(vc_req->sgs);
|
|
}
|
|
}
|
|
}
|
|
|
|
static void virtcrypto_remove(struct virtio_device *vdev)
|
|
{
|
|
struct virtio_crypto *vcrypto = vdev->priv;
|
|
|
|
dev_info(&vdev->dev, "Start virtcrypto_remove.\n");
|
|
|
|
if (virtcrypto_dev_started(vcrypto))
|
|
virtcrypto_dev_stop(vcrypto);
|
|
vdev->config->reset(vdev);
|
|
virtcrypto_free_unused_reqs(vcrypto);
|
|
virtcrypto_clear_crypto_engines(vcrypto);
|
|
virtcrypto_del_vqs(vcrypto);
|
|
virtcrypto_devmgr_rm_dev(vcrypto);
|
|
kfree(vcrypto);
|
|
}
|
|
|
|
static void virtcrypto_config_changed(struct virtio_device *vdev)
|
|
{
|
|
struct virtio_crypto *vcrypto = vdev->priv;
|
|
|
|
virtcrypto_update_status(vcrypto);
|
|
}
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
static int virtcrypto_freeze(struct virtio_device *vdev)
|
|
{
|
|
struct virtio_crypto *vcrypto = vdev->priv;
|
|
|
|
vdev->config->reset(vdev);
|
|
virtcrypto_free_unused_reqs(vcrypto);
|
|
if (virtcrypto_dev_started(vcrypto))
|
|
virtcrypto_dev_stop(vcrypto);
|
|
|
|
virtcrypto_clear_crypto_engines(vcrypto);
|
|
virtcrypto_del_vqs(vcrypto);
|
|
return 0;
|
|
}
|
|
|
|
static int virtcrypto_restore(struct virtio_device *vdev)
|
|
{
|
|
struct virtio_crypto *vcrypto = vdev->priv;
|
|
int err;
|
|
|
|
err = virtcrypto_init_vqs(vcrypto);
|
|
if (err)
|
|
return err;
|
|
|
|
err = virtcrypto_start_crypto_engines(vcrypto);
|
|
if (err)
|
|
goto free_vqs;
|
|
|
|
virtio_device_ready(vdev);
|
|
|
|
err = virtcrypto_dev_start(vcrypto);
|
|
if (err) {
|
|
dev_err(&vdev->dev, "Failed to start virtio crypto device.\n");
|
|
goto free_engines;
|
|
}
|
|
|
|
return 0;
|
|
|
|
free_engines:
|
|
virtcrypto_clear_crypto_engines(vcrypto);
|
|
free_vqs:
|
|
vcrypto->vdev->config->reset(vdev);
|
|
virtcrypto_del_vqs(vcrypto);
|
|
return err;
|
|
}
|
|
#endif
|
|
|
|
static unsigned int features[] = {
|
|
/* none */
|
|
};
|
|
|
|
static struct virtio_device_id id_table[] = {
|
|
{ VIRTIO_ID_CRYPTO, VIRTIO_DEV_ANY_ID },
|
|
{ 0 },
|
|
};
|
|
|
|
static struct virtio_driver virtio_crypto_driver = {
|
|
.driver.name = KBUILD_MODNAME,
|
|
.driver.owner = THIS_MODULE,
|
|
.feature_table = features,
|
|
.feature_table_size = ARRAY_SIZE(features),
|
|
.id_table = id_table,
|
|
.probe = virtcrypto_probe,
|
|
.remove = virtcrypto_remove,
|
|
.config_changed = virtcrypto_config_changed,
|
|
#ifdef CONFIG_PM_SLEEP
|
|
.freeze = virtcrypto_freeze,
|
|
.restore = virtcrypto_restore,
|
|
#endif
|
|
};
|
|
|
|
module_virtio_driver(virtio_crypto_driver);
|
|
|
|
MODULE_DEVICE_TABLE(virtio, id_table);
|
|
MODULE_DESCRIPTION("virtio crypto device driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Gonglei <arei.gonglei@huawei.com>");
|