linux

iv/linux

History

Hans Verkuil 89c08aef8f media: videobuf2: set q->streaming later

Commit a10b21532574 ("media: vb2: add (un)prepare_streaming queue ops") moved
up the q->streaming = 1 assignment to before the call to vb2_start_streaming().

This does make sense since q->streaming indicates that VIDIOC_STREAMON is called,
and the call to start_streaming happens either at that time or later if
q->min_buffers_needed > 0. So q->streaming should be 1 before start_streaming
is called.

However, it turned out that some drivers use vb2_is_streaming() in buf_queue,
and if q->min_buffers_needed == 0, then that will now return true instead of
false.

So for the time being revert to the original behavior.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: a10b21532574 ("media: vb2: add (un)prepare_streaming queue ops")
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

2023-01-24 16:34:06 +01:00

cec

media: Switch to use dev_err_probe() helper

2022-12-07 17:58:46 +01:00

common

media: videobuf2: set q->streaming later

2023-01-24 16:34:06 +01:00

dvb-core

Driver Core changes for 6.2-rc1

2022-12-16 03:54:54 -08:00

dvb-frontends

media updates for v6.2-rc1