iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
eda5ecc0a6
linux/drivers/input/misc
History
Stephen Boyd eda5ecc0a6 Input: pmic8xxx-pwrkey - fix algorithm for converting trigger delay 
The trigger delay algorithm that converts from microseconds to
the register value looks incorrect. According to most of the PMIC
documentation, the equation is

	delay (Seconds) = (1 / 1024) * 2 ^ (x + 4)

except for one case where the documentation looks to have a
formatting issue and the equation looks like

	delay (Seconds) = (1 / 1024) * 2 x + 4

Most likely this driver was written with the improper
documentation to begin with. According to the downstream sources
the valid delays are from 2 seconds to 1/64 second, and the
latter equation just doesn't make sense for that. Let's fix the
algorithm and the range check to match the documentation and the
downstream sources.

Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Fixes: 92d57a73e4 ("input: Add support for Qualcomm PMIC8XXX power key")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2016-04-17 05:24:53 -07:00
..
88pm80x_onkey.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
88pm860x_onkey.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2014-12-17 10:06:02 -08:00
ab8500-ponkey.c Input: ab8500-ponkey - Fix module autoload for OF platform driver 2015-09-03 10:56:19 -07:00
ad714x-i2c.c Input: ad714x - convert to using managed resources 2015-09-19 11:42:39 -07:00
ad714x-spi.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2015-11-06 11:57:41 -08:00
ad714x.c Input: ad714x - convert to using managed resources 2015-09-19 11:42:39 -07:00
ad714x.h Input: ad714x - convert to using managed resources 2015-09-19 11:42:39 -07:00
adxl34x-i2c.c Input: drop owner assignment from i2c_driver 2015-07-17 16:57:00 -07:00
adxl34x-spi.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
adxl34x.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
adxl34x.h
apanel.c
arizona-haptics.c Input: arizona-haptic - don't assign input_dev parent 2016-04-17 05:24:52 -07:00
ati_remote2.c Input: ati_remote2 - fix crashes on detecting device with invalid descriptor 2016-03-23 17:29:29 -07:00
atlas_btns.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2014-01-24 17:17:30 -08:00
axp20x-pek.c Input: axp20x-pek - add module alias 2015-08-03 14:11:46 -07:00
bfin_rotary.c Input: bfin_rotary - introduce open and close methods 2015-02-15 16:06:29 -08:00
bma150.c Input: bma150 - constify bma150_cfg structure 2016-01-02 21:08:52 -08:00
cm109.c Input: cm109 - convert high volume dev_err() to dev_err_ratelimited() 2013-10-06 01:23:41 -07:00
cma3000_d0x_i2c.c Input: drop owner assignment from i2c_driver 2015-07-17 16:57:00 -07:00
cma3000_d0x.c Input: use dev_get_platdata() 2013-12-06 02:06:29 -08:00
cma3000_d0x.h
cobalt_btns.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
da9052_onkey.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
da9055_onkey.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
da9063_onkey.c Input: da9063 - report KEY_POWER instead of KEY_SLEEP during power key-press 2015-12-12 21:05:09 -08:00
dm355evm_keys.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
drv260x.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2015-09-04 12:02:11 -07:00
drv2665.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2015-09-04 12:02:11 -07:00
drv2667.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2015-09-04 12:02:11 -07:00
e3x0-button.c Input: add support for NI Ettus Research USRP E3x0 button 2015-01-10 14:17:10 -08:00
gp2ap002a00f.c Input: export I2C module alias information in missing drivers 2015-07-30 11:05:37 -07:00
gpio_tilt_polled.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
gpio-beeper.c Input: improve usage of gpiod API 2015-06-16 17:09:14 -07:00
hp_sdc_rtc.c Input: hp_sdc_rtc - fix y2038 problem in proc_show 2015-10-22 23:31:28 -07:00
ideapad_slidebar.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
ims-pcu.c Input: ims-pcu - sanity check against missing interfaces 2016-03-17 14:16:57 -07:00
ixp4xx-beeper.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
Kconfig Input: sirfsoc-onkey - allow modular build 2016-01-27 15:55:14 -08:00
keyspan_remote.c Input: keyspan_remote - remove unnecessary break after goto 2014-07-18 10:53:27 -07:00
kxtj9.c Input: kxtj9 - remove unneeded retval variable 2015-10-02 11:44:17 -07:00
m68kspkr.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
Makefile Input: Remove the max77843 haptic driver 2015-08-07 14:57:25 +01:00
max8925_onkey.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2014-12-17 10:06:02 -08:00
max8997_haptic.c Input: max8997_haptic - fix module alias 2015-08-28 17:46:25 -07:00
max77693-haptic.c Input: max77693: Add support for Maxim 77843 2015-08-07 14:57:25 +01:00
mc13783-pwrbutton.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
mma8450.c Input: mma8450 - convert to using managed resources 2015-03-24 11:35:06 -07:00
mpu3050.c Input: drop owner assignment from i2c_driver 2015-07-17 16:57:00 -07:00
palmas-pwrbutton.c Input: constify of_device_id arrays 2015-03-19 12:16:18 -07:00
pcap_keys.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
pcf8574_keypad.c Input: drop owner assignment from i2c_driver 2015-07-17 16:57:00 -07:00
pcf50633-input.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
pcspkr.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
pm8xxx-vibrator.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2014-12-17 10:06:02 -08:00
pm8941-pwrkey.c Input: pm8941-pwrkey - remove unneded semicolon 2015-09-19 11:39:03 -07:00
pmic8xxx-pwrkey.c Input: pmic8xxx-pwrkey - fix algorithm for converting trigger delay 2016-04-17 05:24:53 -07:00
powermate.c Input: powermate - fix oops with malicious USB descriptors 2016-03-14 09:36:49 -07:00
pwm-beeper.c Input: pwm-beeper - fix module autoload for OF platform driver 2015-09-03 10:56:20 -07:00
rb532_button.c MIPS: Remove all the uses of custom gpio.h 2015-09-03 12:08:02 +02:00
regulator-haptic.c Input: regulator-haptic - fix module autoload for OF platform driver 2015-09-03 10:56:20 -07:00
retu-pwrbutton.c Input: retu-pwrbutton - pass the IRQF_ONESHOT flag 2015-05-15 15:58:41 -07:00
rotary_encoder.c Input: rotary-encoder - support more than 2 gpios as input 2016-03-02 15:48:05 -08:00
sgi_btns.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
sirfsoc-onkey.c Input: sirfsoc-onkey - allow modular build 2016-01-27 15:55:14 -08:00
soc_button_array.c Input: soc_button_array - remove duplicated include 2015-05-13 10:30:18 -07:00
sparcspkr.c Input: sparcspkr - use platform_register/unregister_drivers() 2015-12-02 10:02:50 -08:00
tps65218-pwrbutton.c Input: constify of_device_id arrays 2015-03-19 12:16:18 -07:00
twl4030-pwrbutton.c Input: twl4030-pwrbutton - pass the IRQF_ONESHOT flag 2015-05-15 15:58:40 -07:00
twl4030-vibra.c Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning 2015-08-05 11:11:37 -07:00
twl6040-vibra.c Input: twl6040-vibra - pass the IRQF_ONESHOT flag 2015-05-15 15:58:41 -07:00
uinput.c Input: uinput - sanity check on ff_effects_max and EV_FF 2015-12-18 17:48:52 -08:00
wistron_btns.c input: misc: drop owner assignment from platform_drivers 2014-10-20 16:20:40 +02:00
wm831x-on.c Input: wm831x-on - pass the IRQF_ONESHOT flag 2015-05-15 15:58:42 -07:00
xen-kbdfront.c Input: xen - check return value of xenbus_printf 2015-10-22 23:32:01 -07:00
yealink.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
yealink.h