Jean Delvare 3482124a6a tools / power: turbostat: Drop temperature checks ... The Intel 64 and IA-32 Architectures Software Developer's Manual says that TjMax is stored in bits 23:16 of MSR_TEMPERATURE TARGET (0x1a2). That's 8 bits, not 7, so it must be masked with 0xFF rather than 0x7F. The manual has no mention of which values should be considered valid, which kind of implies that they all are. Arbitrarily discarding values outside a specific range is wrong. The upper range check had to be fixed recently (commit 144b44b1) and the lower range check is just as wrong. See bug #75071: https://bugzilla.kernel.org/show_bug.cgi?id=75071 There are many Xeon processor series with TjMax of 70, 71 or 80 degrees Celsius, way below the arbitrary 85 degrees Celsius limit. There may be other (past or future) models with even lower limits. So drop this arbitrary check. The only value that would be clearly invalid is 0. Everything else should be accepted. After these changes, turbostat is aligned with what the coretemp driver does. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Len Brown <len.brown@intel.com> Acked-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>		2014-05-07 00:14:46 +02:00
..
.gitignore	turbostat: Add a .gitignore to ignore the compiled turbostat binary	2014-01-18 22:34:10 -05:00
Makefile	turbostat: Don't put unprocessed uapi headers in the include path	2014-01-18 22:34:07 -05:00
turbostat.8	tools/power turbostat: simplify output, add Avg_MHz	2014-03-05 22:19:55 -05:00
turbostat.c	tools / power: turbostat: Drop temperature checks	2014-05-07 00:14:46 +02:00