0b20933d8c
Reliably remove all the type modifiers from read-only (.rodata) global
variable definitions, including cases of inner field const modifiers and
arrays of const values.
Also modify one of selftests to ensure that const volatile struct doesn't
prevent user-space from modifying .rodata variable.
Fixes: 985ead416df3 ("bpftool: Add skeleton codegen command")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200713232409.3062144-3-andriin@fb.com
99 lines
3.3 KiB
C
99 lines
3.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Copyright (c) 2019 Facebook */
|
|
|
|
#include <test_progs.h>
|
|
|
|
struct s {
|
|
int a;
|
|
long long b;
|
|
} __attribute__((packed));
|
|
|
|
#include "test_skeleton.skel.h"
|
|
|
|
void test_skeleton(void)
|
|
{
|
|
int duration = 0, err;
|
|
struct test_skeleton* skel;
|
|
struct test_skeleton__bss *bss;
|
|
struct test_skeleton__data *data;
|
|
struct test_skeleton__rodata *rodata;
|
|
struct test_skeleton__kconfig *kcfg;
|
|
|
|
skel = test_skeleton__open();
|
|
if (CHECK(!skel, "skel_open", "failed to open skeleton\n"))
|
|
return;
|
|
|
|
if (CHECK(skel->kconfig, "skel_kconfig", "kconfig is mmaped()!\n"))
|
|
goto cleanup;
|
|
|
|
bss = skel->bss;
|
|
data = skel->data;
|
|
rodata = skel->rodata;
|
|
|
|
/* validate values are pre-initialized correctly */
|
|
CHECK(data->in1 != -1, "in1", "got %d != exp %d\n", data->in1, -1);
|
|
CHECK(data->out1 != -1, "out1", "got %d != exp %d\n", data->out1, -1);
|
|
CHECK(data->in2 != -1, "in2", "got %lld != exp %lld\n", data->in2, -1LL);
|
|
CHECK(data->out2 != -1, "out2", "got %lld != exp %lld\n", data->out2, -1LL);
|
|
|
|
CHECK(bss->in3 != 0, "in3", "got %d != exp %d\n", bss->in3, 0);
|
|
CHECK(bss->out3 != 0, "out3", "got %d != exp %d\n", bss->out3, 0);
|
|
CHECK(bss->in4 != 0, "in4", "got %lld != exp %lld\n", bss->in4, 0LL);
|
|
CHECK(bss->out4 != 0, "out4", "got %lld != exp %lld\n", bss->out4, 0LL);
|
|
|
|
CHECK(rodata->in.in6 != 0, "in6", "got %d != exp %d\n", rodata->in.in6, 0);
|
|
CHECK(bss->out6 != 0, "out6", "got %d != exp %d\n", bss->out6, 0);
|
|
|
|
/* validate we can pre-setup global variables, even in .bss */
|
|
data->in1 = 10;
|
|
data->in2 = 11;
|
|
bss->in3 = 12;
|
|
bss->in4 = 13;
|
|
rodata->in.in6 = 14;
|
|
|
|
err = test_skeleton__load(skel);
|
|
if (CHECK(err, "skel_load", "failed to load skeleton: %d\n", err))
|
|
goto cleanup;
|
|
|
|
/* validate pre-setup values are still there */
|
|
CHECK(data->in1 != 10, "in1", "got %d != exp %d\n", data->in1, 10);
|
|
CHECK(data->in2 != 11, "in2", "got %lld != exp %lld\n", data->in2, 11LL);
|
|
CHECK(bss->in3 != 12, "in3", "got %d != exp %d\n", bss->in3, 12);
|
|
CHECK(bss->in4 != 13, "in4", "got %lld != exp %lld\n", bss->in4, 13LL);
|
|
CHECK(rodata->in.in6 != 14, "in6", "got %d != exp %d\n", rodata->in.in6, 14);
|
|
|
|
/* now set new values and attach to get them into outX variables */
|
|
data->in1 = 1;
|
|
data->in2 = 2;
|
|
bss->in3 = 3;
|
|
bss->in4 = 4;
|
|
bss->in5.a = 5;
|
|
bss->in5.b = 6;
|
|
kcfg = skel->kconfig;
|
|
|
|
err = test_skeleton__attach(skel);
|
|
if (CHECK(err, "skel_attach", "skeleton attach failed: %d\n", err))
|
|
goto cleanup;
|
|
|
|
/* trigger tracepoint */
|
|
usleep(1);
|
|
|
|
CHECK(data->out1 != 1, "res1", "got %d != exp %d\n", data->out1, 1);
|
|
CHECK(data->out2 != 2, "res2", "got %lld != exp %d\n", data->out2, 2);
|
|
CHECK(bss->out3 != 3, "res3", "got %d != exp %d\n", (int)bss->out3, 3);
|
|
CHECK(bss->out4 != 4, "res4", "got %lld != exp %d\n", bss->out4, 4);
|
|
CHECK(bss->handler_out5.a != 5, "res5", "got %d != exp %d\n",
|
|
bss->handler_out5.a, 5);
|
|
CHECK(bss->handler_out5.b != 6, "res6", "got %lld != exp %d\n",
|
|
bss->handler_out5.b, 6);
|
|
CHECK(bss->out6 != 14, "res7", "got %d != exp %d\n", bss->out6, 14);
|
|
|
|
CHECK(bss->bpf_syscall != kcfg->CONFIG_BPF_SYSCALL, "ext1",
|
|
"got %d != exp %d\n", bss->bpf_syscall, kcfg->CONFIG_BPF_SYSCALL);
|
|
CHECK(bss->kern_ver != kcfg->LINUX_KERNEL_VERSION, "ext2",
|
|
"got %d != exp %d\n", bss->kern_ver, kcfg->LINUX_KERNEL_VERSION);
|
|
|
|
cleanup:
|
|
test_skeleton__destroy(skel);
|
|
}
|