e5f3155267
The 'imply' keyword does not do what most people think it does, it only
politely asks Kconfig to turn on another symbol, but does not prevent
it from being disabled manually or built as a loadable module when the
user is built-in. In the ICE driver, the latter now causes a link failure:
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':
ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'
aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'
ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':
ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':
This is a recurring problem in many drivers, and we have discussed
it several times befores, without reaching a consensus. I'm providing
a link to the previous email thread for reference, which discusses
some related problems.
To solve the dependency issue better than the 'imply' keyword, introduce a
separate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any driver
can depend on if it is able to use PTP support when available, but works
fine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers are
then prevented from being built-in, the same way as with a 'depends on
PTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,
but that can be rather confusing when you first see it.
Since this should cover the dependencies correctly, the IS_REACHABLE()
hack in the header is no longer needed now, and can be turned back
into a normal IS_ENABLED() check. Any driver that gets the dependency
wrong will now cause a link time failure rather than being unable to use
PTP support when that is in a loadable module.
However, the two recently added ptp_get_vclocks_index() and
ptp_convert_timestamp() interfaces are only called from builtin code with
ethtool and socket timestamps, so keep the current behavior by stubbing
those out completely when PTP is in a loadable module. This should be
addressed properly in a follow-up.
As Richard suggested, we may want to actually turn PTP support into a
'bool' option later on, preventing it from being a loadable module
altogether, which would be one way to solve the problem with the ethtool
interface.
Fixes: 06c16d89d2cb ("ice: register 1588 PTP clock device object for E810 devices")
Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/
Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/
Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/
Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/
Acked-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
123 lines
3.0 KiB
Plaintext
123 lines
3.0 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# QLogic network device configuration
|
|
#
|
|
|
|
config NET_VENDOR_QLOGIC
|
|
bool "QLogic devices"
|
|
default y
|
|
depends on PCI
|
|
help
|
|
If you have a network (Ethernet) card belonging to this class, say Y.
|
|
|
|
Note that the answer to this question doesn't directly affect the
|
|
kernel: saying N will just cause the configurator to skip all
|
|
the questions about QLogic cards. If you say Y, you will be asked for
|
|
your specific card in the following questions.
|
|
|
|
if NET_VENDOR_QLOGIC
|
|
|
|
config QLA3XXX
|
|
tristate "QLogic QLA3XXX Network Driver Support"
|
|
depends on PCI
|
|
help
|
|
This driver supports QLogic ISP3XXX gigabit Ethernet cards.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called qla3xxx.
|
|
|
|
config QLCNIC
|
|
tristate "QLOGIC QLCNIC 1/10Gb Converged Ethernet NIC Support"
|
|
depends on PCI
|
|
select FW_LOADER
|
|
help
|
|
This driver supports QLogic QLE8240 and QLE8242 Converged Ethernet
|
|
devices.
|
|
|
|
config QLCNIC_SRIOV
|
|
bool "QLOGIC QLCNIC 83XX family SR-IOV Support"
|
|
depends on QLCNIC && PCI_IOV
|
|
default y
|
|
help
|
|
This configuration parameter enables Single Root Input Output
|
|
Virtualization support for QLE83XX Converged Ethernet devices.
|
|
This allows for virtual function acceleration in virtualized
|
|
environments.
|
|
|
|
config QLCNIC_DCB
|
|
bool "QLOGIC QLCNIC 82XX and 83XX family DCB Support"
|
|
depends on QLCNIC && DCB
|
|
default y
|
|
help
|
|
This configuration parameter enables DCB support in QLE83XX
|
|
and QLE82XX Converged Ethernet devices. This allows for DCB
|
|
get operations support through rtNetlink interface. Only CEE
|
|
mode of DCB is supported. PG and PFC values are related only
|
|
to Tx.
|
|
|
|
config QLCNIC_HWMON
|
|
bool "QLOGIC QLCNIC 82XX and 83XX family HWMON support"
|
|
depends on QLCNIC && HWMON && !(QLCNIC=y && HWMON=m)
|
|
default y
|
|
help
|
|
This configuration parameter can be used to read the
|
|
board temperature in Converged Ethernet devices
|
|
supported by qlcnic.
|
|
|
|
This data is available via the hwmon sysfs interface.
|
|
|
|
config NETXEN_NIC
|
|
tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC"
|
|
depends on PCI
|
|
select FW_LOADER
|
|
help
|
|
This enables the support for NetXen's Gigabit Ethernet card.
|
|
|
|
config QED
|
|
tristate "QLogic QED 25/40/100Gb core driver"
|
|
depends on PCI
|
|
select ZLIB_INFLATE
|
|
select CRC8
|
|
select CRC32
|
|
select NET_DEVLINK
|
|
help
|
|
This enables the support for Marvell FastLinQ adapters family.
|
|
|
|
config QED_LL2
|
|
bool
|
|
|
|
config QED_SRIOV
|
|
bool "QLogic QED 25/40/100Gb SR-IOV support"
|
|
depends on QED && PCI_IOV
|
|
default y
|
|
help
|
|
This configuration parameter enables Single Root Input Output
|
|
Virtualization support for QED devices.
|
|
This allows for virtual function acceleration in virtualized
|
|
environments.
|
|
|
|
config QEDE
|
|
tristate "QLogic QED 25/40/100Gb Ethernet NIC"
|
|
depends on QED
|
|
depends on PTP_1588_CLOCK_OPTIONAL
|
|
help
|
|
This enables the support for Marvell FastLinQ adapters family,
|
|
ethernet driver.
|
|
|
|
config QED_RDMA
|
|
bool
|
|
|
|
config QED_ISCSI
|
|
bool
|
|
|
|
config QED_NVMETCP
|
|
bool
|
|
|
|
config QED_FCOE
|
|
bool
|
|
|
|
config QED_OOO
|
|
bool
|
|
|
|
endif # NET_VENDOR_QLOGIC
|