linux/arch/arm/mach-omap1
Paul Walmsley eeb3711b89 ARM: OMAP2+: clean up some cppcheck warnings
Resolve some warnings identified by cppcheck in arch/arm/mach-omap2:

    [arch/arm/mach-omap2/usb-tusb6010.c:129]: (style) Checking if unsigned variable 'tmp' is less than zero.
    [arch/arm/mach-omap2/prm_common.c:241]: (error) Possible null pointer dereference: irq_setup - otherwise it is redundant to check if irq_setup is null at line 247
    [arch/arm/mach-omap2/pm34xx.c:790]: (style) Variable 'per_clkdm' is assigned a value that is never used
    [arch/arm/mach-omap2/pm34xx.c:790]: (style) Variable 'core_clkdm' is assigned a value that is never used
    [arch/arm/mach-omap2/pm24xx.c:185]: (style) Variable 'only_idle' is assigned a value that is never used
    [arch/arm/mach-omap2/mux.c:254]: (error) Possible null pointer dereference: mux
    [arch/arm/mach-omap2/mux.c:258]: (error) Possible null pointer dereference: mux
    [arch/arm/mach-omap2/gpmc-onenand.c:178]: (style) Variable 'tick_ns' is assigned a value that is never used
    [arch/arm/mach-omap2/gpio.c:56]: (error) Possible null pointer dereference: pdata - otherwise it is redundant to check if pdata is null at line 57
    [arch/arm/mach-omap2/devices.c:45]: (style) Variable 'l' is assigned a value that is never used
    [arch/arm/mach-omap2/board-omap3evm.c:641] -> [arch/arm/mach-omap2/board-omap3evm.c:639]: (style) Found duplicate branches for if and else.
    [arch/arm/mach-omap2/am35xx-emac.c:95]: (style) Variable 'regval' is assigned a value that is never used
    [arch/arm/mach-omap2/devices.c:74]: (style) Variable 'l' is assigned a value that is never used
    [arch/arm/mach-omap2/pm34xx.c:277]: (style) Variable 'per_prev_state' is assigned a value that is never used
    [arch/arm/plat-omap/dmtimer.c:352]: (error) Possible null pointer dereference: timer - otherwise it is redundant to check if timer is null at line 354
    [arch/arm/plat-omap/omap_device.c:478]: (style) Variable 'c' is assigned a value that is never used
    [arch/arm/plat-omap/usb.c:42]: (style) Variable 'status' is assigned a value that is never used
    [arch/arm/mach-omap1/clock.c:197]: (style) Variable 'dpll1_rate' is assigned a value that is never used
    [arch/arm/mach-omap1/lcd_dma.c:60]: (style) struct or union member 'lcd_dma_info::size' is never used
    [arch/arm/mach-omap1/pm.c:572]: (style) Variable 'entry' is assigned a value that is never used

Some of them are pretty good catches, such as gpio.c:56 and
usb-tusb6010.c:129.

Thanks to Jarkko Nikula for some comments on the sscanf() warnings.
It seems that the kernel sscanf() ignores the field width anyway for the
%d format, so those changes have been dropped from this second version.

Thanks to Daniel Marjamäki <daniel.marjamaki@gmail.com> for pointing
out that a variable was unnecessarily marked static in the
board-omap3evm.c change.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Charulatha Varadarajan <charu@ti.com>
Cc: Daniel Marjamäki <daniel.marjamaki@gmail.com>
Cc: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Reviewed-by: Charulatha Varadarajan <charu@ti.com> # for gpio.c
2012-04-17 15:50:47 -06:00
..
include/mach ARM: fix __io macro for PCMCIA 2012-04-05 11:29:55 -07:00
ams-delta-fiq-handler.S ARM: create a common IOMEM definition 2012-03-13 21:22:09 -05:00
ams-delta-fiq.c ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warnings 2012-04-13 06:34:28 -06:00
board-ams-delta.c ARM: board specific updates 2012-03-27 16:27:28 -07:00
board-fsample.c ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
board-generic.c ARM: restart: omap: use new restart hook 2012-01-05 12:57:16 +00:00
board-h2-mmc.c ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h 2011-08-08 14:27:41 +01:00
board-h2.c ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
board-h2.h
board-h3-mmc.c ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h 2011-08-08 14:27:41 +01:00
board-h3.c ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
board-h3.h
board-htcherald.c Merge branch 'fixes-gpio-to-irq' into fixes 2012-03-29 10:16:04 -07:00
board-innovator.c Merge branch 'fixes-gpio-to-irq' into fixes 2012-03-29 10:16:04 -07:00
board-nand.c ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
board-nokia770.c Merge branch 'fixes-gpio-to-irq' into fixes 2012-03-29 10:16:04 -07:00
board-osk.c Merge branch 'fixes-gpio-to-irq' into fixes 2012-03-29 10:16:04 -07:00
board-palmte.c Merge branch 'fixes-gpio-to-irq' into fixes 2012-03-29 10:16:04 -07:00
board-palmtt.c Merge branch 'fixes-gpio-to-irq' into fixes 2012-03-29 10:16:04 -07:00
board-palmz71.c ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warnings 2012-04-13 06:34:28 -06:00
board-perseus2.c ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
board-sx1-mmc.c ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h 2011-08-08 14:27:41 +01:00
board-sx1.c ARM: global cleanups 2012-03-27 16:03:32 -07:00
board-voiceblue.c ARM: OMAP: boards: Fix OMAP_GPIO_IRQ usage with gpio_to_irq() 2012-03-29 08:41:01 -07:00
clock_data.c ARM: OMAP: Remove plat/io.h by splitting it into mach/io.h and mach/hardware.h 2012-02-24 10:34:35 -08:00
clock.c ARM: OMAP2+: clean up some cppcheck warnings 2012-04-17 15:50:47 -06:00
clock.h ARM: OMAP1: Move dpll1 rates selection from config to runtime 2011-12-08 18:02:23 -08:00
common.h ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
devices.c ARM: global cleanups 2012-03-27 16:03:32 -07:00
dma.c ARM: OMAP1: Move most of plat/io.h into local iomap.h 2012-02-24 10:34:34 -08:00
flash.c MTD merge for 3.4 2012-03-30 17:31:56 -07:00
fpga.c ARM: OMAP2+: declare file-local functions as static 2012-04-13 06:34:26 -06:00
gpio7xx.c gpio/omap: fix bankwidth for OMAP7xx MPUIO 2012-02-06 14:13:44 +05:30
gpio15xx.c gpio/omap: remove bank->method & METHOD_* macros 2012-02-06 14:13:43 +05:30
gpio16xx.c Merge branch 'depends/omap/gpio/runtime-pm-cleanup' into next/cleanup 2012-03-02 13:05:00 +00:00
i2c.c
id.c ARM: OMAP: add includes for missing prototypes 2012-04-13 06:34:26 -06:00
io.c ARM: OMAP: add includes for missing prototypes 2012-04-13 06:34:26 -06:00
iomap.h ARM: create a common IOMEM definition 2012-03-13 21:22:09 -05:00
irq.c ARM: OMAP: add includes for missing prototypes 2012-04-13 06:34:26 -06:00
Kconfig ARM: board specific updates 2012-03-27 16:27:28 -07:00
lcd_dma.c ARM: OMAP2+: clean up some cppcheck warnings 2012-04-17 15:50:47 -06:00
leds-h2p2-debug.c Disintegrate asm/system.h for ARM 2012-03-28 18:30:01 +01:00
leds-innovator.c Disintegrate asm/system.h for ARM 2012-03-28 18:30:01 +01:00
leds-osk.c Disintegrate asm/system.h for ARM 2012-03-28 18:30:01 +01:00
leds.c ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h 2011-08-08 14:27:41 +01:00
leds.h
mailbox.c arm: fix implicit module.h users by adding it to arch/arm as required. 2011-10-31 19:30:50 -04:00
Makefile ARM: OMAP1: board files: deduplicate and clean some NAND-related code 2012-04-13 06:34:31 -06:00
Makefile.boot ARM: 7022/1: allow to detect conflicting zreladdrs 2011-10-17 09:12:40 +01:00
mcbsp.c ARM: global cleanups 2012-03-27 16:03:32 -07:00
mux.c Disintegrate asm/system.h for ARM 2012-03-28 18:30:01 +01:00
ocpi.c ARM: OMAP1: OCPI: move to mach-omap1/ 2012-04-13 06:34:27 -06:00
opp_data.c ARM: OMAP1: Move dpll1 rates selection from config to runtime 2011-12-08 18:02:23 -08:00
opp.h ARM: OMAP1: Move dpll1 rates selection from config to runtime 2011-12-08 18:02:23 -08:00
pm_bus.c PM: Move clock-related definitions and headers to separate file 2011-08-25 15:34:19 +02:00
pm.c ARM: OMAP2+: clean up some cppcheck warnings 2012-04-17 15:50:47 -06:00
pm.h
reset.c ARM: OMAP: add includes for missing prototypes 2012-04-13 06:34:26 -06:00
serial.c ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h 2011-08-08 14:27:41 +01:00
sleep.S ARM: OMAP: Remove remaining includes for mach/io.h 2012-03-06 21:34:38 -06:00
sram.S ARM: OMAP: Remove remaining includes for mach/io.h 2012-03-06 21:34:38 -06:00
time.c Disintegrate and delete asm/system.h 2012-03-28 15:58:21 -07:00
timer32k.c Disintegrate and delete asm/system.h 2012-03-28 15:58:21 -07:00
timer.c ARM: OMAP2+: declare file-local functions as static 2012-04-13 06:34:26 -06:00
usb.c ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus 2012-04-13 06:34:27 -06:00