iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
eeca958dce
linux/fs/ceph
History
Luis Henriques eeca958dce ceph: fix memory leak in __ceph_setxattr() 
The ceph_inode_xattr needs to be released when removing an xattr.  Easily
reproducible running the 'generic/020' test from xfstests or simply by
doing:

  attr -s attr0 -V 0 /mnt/test && attr -r attr0 /mnt/test

While there, also fix the error path.

Here's the kmemleak splat:

unreferenced object 0xffff88001f86fbc0 (size 64):
  comm "attr", pid 244, jiffies 4294904246 (age 98.464s)
  hex dump (first 32 bytes):
    40 fa 86 1f 00 88 ff ff 80 32 38 1f 00 88 ff ff  @........28.....
    00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de  ................
  backtrace:
    [<ffffffff81560199>] kmemleak_alloc+0x49/0xa0
    [<ffffffff810f3e5b>] kmem_cache_alloc+0x9b/0xf0
    [<ffffffff812b157e>] __ceph_setxattr+0x17e/0x820
    [<ffffffff812b1c57>] ceph_set_xattr_handler+0x37/0x40
    [<ffffffff8111fb4b>] __vfs_removexattr+0x4b/0x60
    [<ffffffff8111fd37>] vfs_removexattr+0x77/0xd0
    [<ffffffff8111fdd1>] removexattr+0x41/0x60
    [<ffffffff8111fe65>] path_removexattr+0x75/0xa0
    [<ffffffff81120aeb>] SyS_lremovexattr+0xb/0x10
    [<ffffffff81564b20>] entry_SYSCALL_64_fastpath+0x13/0x94
    [<ffffffffffffffff>] 0xffffffffffffffff

Cc: stable@vger.kernel.org
Signed-off-by: Luis Henriques <lhenriques@suse.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2017-05-04 09:19:24 +02:00
..
acl.c ceph: Propagate dentry down to inode_change_ok() 2016-09-22 10:56:19 +02:00
addr.c ceph: when seeing write errors on an inode, switch to sync writes 2017-05-04 09:19:22 +02:00
cache.c ceph: fix spelling mistake: "enabing" -> "enabling" 2017-02-20 12:16:05 +01:00
cache.h ceph: improve fscache revalidation 2016-06-01 10:31:50 +02:00
caps.c ceph: handle epoch barriers in cap messages 2017-05-04 09:19:21 +02:00
ceph_frag.c
debugfs.c ceph: allow connecting to mds whose rank >= mdsmap::m_max_mds 2017-05-04 09:19:20 +02:00
dir.c ceph: choose readdir frag based on previous readdir reply 2017-05-04 09:19:24 +02:00
export.c ceph: add a new flag to indicate whether parent is locked 2017-02-20 12:16:08 +01:00
file.c ceph: fix file open flags on ppc64 2017-05-04 09:19:24 +02:00
inode.c ceph: make seeky readdir more efficient 2017-05-04 09:19:20 +02:00
ioctl.c ceph: fix bogus endianness change in ceph_ioctl_set_layout 2017-02-20 12:16:07 +01:00
ioctl.h ceph: fully initialize new layout 2012-05-16 14:28:27 -05:00
Kconfig ceph: add acl for cephfs 2013-12-31 20:32:01 +02:00
locks.c ceph: fix mandatory flock check 2016-10-03 16:13:49 +02:00
Makefile ceph: add acl for cephfs 2013-12-31 20:32:01 +02:00
mds_client.c ceph: handle epoch barriers in cap messages 2017-05-04 09:19:21 +02:00
mds_client.h ceph: handle epoch barriers in cap messages 2017-05-04 09:19:21 +02:00
mdsmap.c ceph: allow connecting to mds whose rank >= mdsmap::m_max_mds 2017-05-04 09:19:20 +02:00
snap.c ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t 2017-05-04 09:19:18 +02:00
strings.c ceph: handle CEPH_SESSION_REJECT message 2016-10-03 16:13:50 +02:00
super.c libceph, ceph: always advertise all supported features 2017-05-04 09:19:18 +02:00
super.h ceph: when seeing write errors on an inode, switch to sync writes 2017-05-04 09:19:22 +02:00
xattr.c ceph: fix memory leak in __ceph_setxattr() 2017-05-04 09:19:24 +02:00