Geliang Tang eef0532e90 selftests/bpf: Null checks for links in bpf_tcp_ca ... Run bpf_tcp_ca selftests (./test_progs -t bpf_tcp_ca) on a Loongarch platform, some "Segmentation fault" errors occur: ''' test_dctcp:PASS:bpf_dctcp__open_and_load 0 nsec test_dctcp:FAIL:bpf_map__attach_struct_ops unexpected error: -524 #29/1 bpf_tcp_ca/dctcp:FAIL test_cubic:PASS:bpf_cubic__open_and_load 0 nsec test_cubic:FAIL:bpf_map__attach_struct_ops unexpected error: -524 #29/2 bpf_tcp_ca/cubic:FAIL test_dctcp_fallback:PASS:dctcp_skel 0 nsec test_dctcp_fallback:PASS:bpf_dctcp__load 0 nsec test_dctcp_fallback:FAIL:dctcp link unexpected error: -524 #29/4 bpf_tcp_ca/dctcp_fallback:FAIL test_write_sk_pacing:PASS:open_and_load 0 nsec test_write_sk_pacing:FAIL:attach_struct_ops unexpected error: -524 #29/6 bpf_tcp_ca/write_sk_pacing:FAIL test_update_ca:PASS:open 0 nsec test_update_ca:FAIL:attach_struct_ops unexpected error: -524 settcpca:FAIL:setsockopt unexpected setsockopt: \ actual -1 == expected -1 (network_helpers.c:99: errno: No such file or directory) \ Failed to call post_socket_cb start_test:FAIL:start_server_str unexpected start_server_str: \ actual -1 == expected -1 test_update_ca:FAIL:ca1_ca1_cnt unexpected ca1_ca1_cnt: \ actual 0 <= expected 0 #29/9 bpf_tcp_ca/update_ca:FAIL #29 bpf_tcp_ca:FAIL Caught signal #11! Stack trace: ./test_progs(crash_handler+0x28)[0x5555567ed91c] linux-vdso.so.1(__vdso_rt_sigreturn+0x0)[0x7ffffee408b0] ./test_progs(bpf_link__update_map+0x80)[0x555556824a78] ./test_progs(+0x94d68)[0x5555564c4d68] ./test_progs(test_bpf_tcp_ca+0xe8)[0x5555564c6a88] ./test_progs(+0x3bde54)[0x5555567ede54] ./test_progs(main+0x61c)[0x5555567efd54] /usr/lib64/libc.so.6(+0x22208)[0x7ffff2aaa208] /usr/lib64/libc.so.6(__libc_start_main+0xac)[0x7ffff2aaa30c] ./test_progs(_start+0x48)[0x55555646bca8] Segmentation fault ''' This is because BPF trampoline is not implemented on Loongarch yet, "link" returned by bpf_map__attach_struct_ops() is NULL. test_progs crashs when this NULL link passes to bpf_link__update_map(). This patch adds NULL checks for all links in bpf_tcp_ca to fix these errors. If "link" is NULL, goto the newly added label "out" to destroy the skel. v2: - use "goto out" instead of "return" as Eduard suggested. Fixes: 06da9f3bd6 ("selftests/bpf: Test switching TCP Congestion Control algorithms.") Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn> Reviewed-by: Alan Maguire <alan.maguire@oracle.com> Link: https://lore.kernel.org/r/b4c841492bd4ed97964e4e61e92827ce51bf1dc9.1720615848.git.tanggeliang@kylinos.cn Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>		2024-07-10 12:35:18 -07:00
..
accounting
arch	tools headers arm64: Sync arm64's cputype.h with the kernel sources	2024-06-04 16:46:40 -03:00
bootconfig
bpf	bpftool: improve skeleton backwards compat with old buggy libbpfs	2024-07-09 19:03:05 -07:00
build
certs
cgroup	proc: rewrite stable_page_flags()	2024-04-25 20:56:15 -07:00
counter
crypto
debugging
firewire
firmware
gpio
hv	tools: hv: suppress the invalid warning for packed member alignment	2024-05-28 05:27:35 +00:00
iio
include	bpf-next-for-netdev	2024-07-09 17:01:46 +02:00
kvm/kvm_stat
laptop
leds
lib	libbpf: improve old BPF skeleton handling for map auto-attach	2024-07-09 19:03:36 -07:00
memory-model
mm
net/ynl	tools: ynl: use ident name for Family, too.	2024-07-03 19:13:20 -07:00
objtool
pci
pcmcia
perf	perf bpf: Fix handling of minimal vmlinux.h file when interrupting the build	2024-06-05 11:33:00 -03:00
power	tools/power turbostat: Add local build_bug.h header for snapshot target	2024-06-27 23:53:27 -04:00
rcu
scripts
sound	ASoC: dapm-graph: new tool to visualize DAPM state	2024-04-21 09:58:17 +09:00
spi
testing	selftests/bpf: Null checks for links in bpf_tcp_ca	2024-07-10 12:35:18 -07:00
thermal
time
tracing	tools/latency-collector: Fix -Wformat-security compile warns	2024-05-23 10:46:01 -04:00
usb
verification
virtio
wmi
workqueue
writeback	writeback: add wb_monitor.py script to monitor writeback info on bdi	2024-05-05 17:53:51 -07:00
Makefile