linux

iv/linux

History

Geert Uytterhoeven 144345a4a8 soc: bcm2835: Make !RASPBERRYPI_FIRMWARE dummies return failure

If CONFIG_RASPBERRYPI_FIRMWARE=n:

    drivers/gpio/gpio-raspberrypi-exp.c: In function ‘rpi_exp_gpio_get_polarity’:
    drivers/gpio/gpio-raspberrypi-exp.c:71: warning: ‘get.polarity’ is used uninitialized in this function
    drivers/gpio/gpio-raspberrypi-exp.c: In function ‘rpi_exp_gpio_get_direction’:
    drivers/gpio/gpio-raspberrypi-exp.c:150: warning: ‘get.direction’ is used uninitialized in this function

The dummy firmware interface functions return 0, which means success,
causing subsequent code to make use of the never initialized output
parameter.

Fix this by making the dummy functions return an error code (-ENOSYS)
instead.

Note that this assumes the firmware always fills in the requested data
in the CONFIG_RASPBERRYPI_FIRMWARE=y case.

Fixes: d45f1a563b92dac7 ("staging: vc04_services: fix up rpi firmware functions")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

2018-04-16 15:15:23 -07:00

arc

ARC: mcip: update MCIP debug mask when the new cpu came online

2018-02-28 10:45:31 -08:00

at91

clk: at91: utmi: set the mainck rate

2017-11-01 23:39:49 -07:00

bcm2835

soc: bcm2835: Make !RASPBERRYPI_FIRMWARE dummies return failure

2018-04-16 15:15:23 -07:00

brcmstb

soc: add stubs for brcmstb SoC's