iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
NeilBrown 52d3370e80 nfsd: drop st_mutex before calling move_to_close_lru() 
[ Upstream commit 56c35f43eef013579c76c007ba1f386d8c2cac14 ]

move_to_close_lru() is currently called with ->st_mutex held.
This can lead to a deadlock as move_to_close_lru() waits for sc_count to
drop to 2, and some threads holding a reference might be waiting for the
mutex.  These references will never be dropped so sc_count will never
reach 2.

There can be no harm in dropping ->st_mutex before
move_to_close_lru() because the only place that takes the mutex is
nfsd4_lock_ol_stateid(), and it quickly aborts if sc_type is
NFS4_CLOSED_STID, which it will be before move_to_close_lru() is called.

See also
 https://lore.kernel.org/lkml/4dd1fe21e11344e5969bb112e954affb@jd.com/T/
where this problem was raised but not successfully resolved.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-16 13:23:25 +02:00
..
9p
fs/9p: drop inodes immediately on non-.L too
2024-05-17 11:42:41 +02:00
adfs
…
affs
affs: initialize fsdata in affs_truncate()
2023-02-06 07:49:38 +01:00
afs
afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*()
2024-02-23 08:12:45 +01:00
autofs
autofs: fix memory leak of waitqueues in autofs_catatonic_mode
2023-09-23 10:48:15 +02:00
befs
…
bfs
…
btrfs
btrfs: add missing mutex_unlock in btrfs_relocate_sys_chunks()
2024-05-25 16:16:18 +02:00
cachefiles
cachefiles: fix memory leak in cachefiles_add_cache()
2024-03-06 14:35:23 +00:00
ceph
ceph: fix deadlock or deadcode of misusing dget()
2024-02-23 08:12:51 +01:00
cifs
smb: client: fix OOB in smbCalcSize()
2024-01-08 11:27:37 +01:00
coda
…
configfs
configfs: fix a race in configfs_{,un}register_subsystem()
2022-03-02 11:38:13 +01:00
cramfs
…
crypto
fscrypt: add fscrypt_symlink_getattr() for computing st_size
2021-09-22 11:47:56 +02:00
debugfs
new helper: lookup_positive_unlocked()
2023-09-23 10:47:59 +02:00
devpts
…
dlm
dlm: fix plock lookup when using multiple lockspaces
2023-09-23 10:48:11 +02:00
ecryptfs
ecryptfs: Fix buffer size for tag 66 packet
2024-06-16 13:23:24 +02:00
efivarfs
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:48:12 +01:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 09:20:32 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:50:02 +01:00
ext2
ext2: fix datatype of block number in ext2_xattr_set2()
2023-09-23 10:48:16 +02:00
ext4
ext4: fix corruption during on-line resize
2024-04-13 12:50:06 +02:00
f2fs
f2fs: fix to check return value of f2fs_reserve_new_block()
2024-02-23 08:12:48 +01:00
fat
fat: fix uninitialized field in nostale filehandles
2024-04-13 12:50:04 +02:00
freevxfs
…
fscache
fscache: Fix cookie key hashing
2021-09-22 11:48:02 +02:00
fuse
fuse: don't unhash root
2024-04-13 12:50:05 +02:00
gfs2
gfs2: Fix invalid metadata access in punch_hole
2024-05-17 11:42:39 +02:00
hfs
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-11 16:31:49 +01:00
hfsplus
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
hostfs
…
hpfs
…
hugetlbfs
hugetlbfs: hugetlb_fault_mutex_hash() cleanup
2021-06-03 08:38:12 +02:00
isofs
isofs: handle CDs with bad root inode but good Joliet root directory
2024-04-13 12:50:15 +02:00
jbd2
jbd2: correct the printing of write_flags in jbd2_write_superblock()
2024-01-25 14:33:29 -08:00
jffs2
jffs2: prevent xattr node from overflowing the eraseblock
2024-06-16 13:23:25 +02:00
jfs
jfs: fix array-index-out-of-bounds in diNewExt
2024-02-23 08:12:45 +01:00
kernfs
new helper: lookup_positive_unlocked()
2023-09-23 10:47:59 +02:00
lockd
fs: lockd: avoid possible wrong NULL parameter
2023-09-23 10:48:06 +02:00
minix
minix: fix bug when opening a file with O_DIRECT
2022-04-15 14:15:03 +02:00
nfs
NFS: Fix an off by one in root_nfs_cat()
2024-03-26 18:22:42 -04:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:26:02 +01:00
nfsd
nfsd: drop st_mutex before calling move_to_close_lru()
2024-06-16 13:23:25 +02:00
nilfs2
nilfs2: fix out-of-range warning
2024-06-16 13:23:24 +02:00
nls
fs/nls: make load_nls() take a const parameter
2023-09-23 10:47:58 +02:00
notify
fsnotify: fix wrong lockdep annotations
2022-06-14 16:59:20 +02:00
ntfs
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-25 17:40:30 +01:00
ocfs2
fs: ocfs2: namei: check return value of ocfs2_add_entry()
2023-09-23 10:48:01 +02:00
omfs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
openpromfs
…
orangefs
orangefs: Fix kmemleak in orangefs_prepare_debugfs_help_string()
2023-01-18 11:30:37 +01:00
overlayfs
ovl: skip overlayfs superblocks at global sync
2023-12-08 08:43:26 +01:00
proc
procfs: block chmod on /proc/thread-self/comm
2023-09-23 10:48:11 +02:00
pstore
pstore/ram: Fix crash when setting number of cpus to an odd number
2024-02-23 08:12:45 +01:00
qnx4
qnx4: work around gcc false positive warning bug
2021-10-06 15:31:20 +02:00
qnx6
…
quota
quota: Fix rcu annotations of inode dquot pointers
2024-03-26 18:22:39 -04:00
ramfs
ramfs: fix nommu mmap with gaps in the page cache
2020-10-30 10:38:21 +01:00
reiserfs
reiserfs: Check the return value from __getblk()
2023-09-23 10:47:59 +02:00
romfs
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:30:59 +02:00
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:47:20 +01:00
sysfs
fs: sysfs: Fix reference leak in sysfs_break_active_protection()
2024-05-02 16:17:10 +02:00
sysv
sysv: don't call sb_bread() with pointers_lock held
2024-04-13 12:50:15 +02:00
tracefs
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-20 12:26:48 +02:00
ubifs
ubifs: Set page uptodate in the correct place
2024-04-13 12:50:04 +02:00
udf
udf: initialize newblock to 0
2023-09-23 10:48:12 +02:00
ufs
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 11:05:38 +02:00
xfs
treewide: Remove uninitialized_var() usage
2023-08-11 11:45:01 +02:00
aio.c
fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion
2024-04-13 12:50:09 +02:00
anon_inodes.c
…
attr.c
attr: block mode changes of symlinks
2023-09-23 10:48:17 +02:00
bad_inode.c
…
binfmt_aout.c
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:30:42 +01:00
binfmt_elf_fdpic.c
fs: binfmt_elf_efpic: fix personality for ELF-FDPIC
2023-10-10 21:45:00 +02:00
binfmt_elf.c
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-06 15:31:24 +02:00
binfmt_em86.c
…
binfmt_flat.c
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:30:42 +01:00
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2023-01-18 11:30:33 +01:00
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block_dev.c
block: Don't invalidate pagecache for invalid falloc modes
2024-01-08 11:27:37 +01:00
buffer.c
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-25 17:40:29 +01:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2023-01-18 11:30:27 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
lsm: new security_file_ioctl_compat() hook
2024-02-23 08:12:58 +01:00
compat.c
…
coredump.c
coredump: fix crash when umh is disabled
2020-05-14 07:57:21 +02:00
d_path.c
…
dax.c
dax: fix cache flush on PMD-mapped pages
2022-06-14 16:59:24 +02:00
dcache.c
fast_dput(): handle underflows gracefully
2024-02-23 08:12:48 +01:00
dcookies.c
…
direct-io.c
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:22:32 +02:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
eventfd.c
eventfd: prevent underflow for eventfd semaphores
2023-09-23 10:47:59 +02:00
eventpoll.c
ep_create_wakeup_source(): dentry name can change under you...
2020-10-07 08:00:09 +02:00
exec.c
exec: Fix NOMMU linux_binprm::exec in transfer_args_to_stack()
2024-04-13 12:50:09 +02:00
fcntl.c
fcntl: fix potential deadlock for &fasync_struct.fa_lock
2021-09-22 11:47:50 +02:00
fhandle.c
do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak
2024-03-26 18:22:34 -04:00
file_table.c
fs: add fget_many() and fput_many()
2021-12-08 08:50:13 +01:00
file.c
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:31:41 +01:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:48:51 +02:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
writeback: fix call of incorrect macro
2023-05-17 11:13:23 +02:00
inode.c
fs: fix UAF/GPF bug in nilfs_mdt_destroy
2022-10-26 13:19:16 +02:00
internal.h
…
ioctl.c
…
iomap.c
iomap: Set all uptodate bits for an Uptodate page
2023-11-28 16:46:36 +00:00
Kconfig
…
Kconfig.binfmt
…
libfs.c
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2023-01-18 11:30:06 +01:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:19:00 +01:00
Makefile
…
mbcache.c
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-18 11:30:51 +01:00
mount.h
…
mpage.c
…
namei.c
fs: Fix error checking for d_hash_and_lookup()
2023-09-23 10:47:59 +02:00
namespace.c
VFS: Fix memory leak caused by concurrently mounting fs with subtype
2022-05-15 19:41:59 +02:00
no-block.c
…
nsfs.c
…
open.c
fs: add a vfs_fchmod helper
2024-04-13 12:50:14 +02:00
pipe.c
pipe: increase minimum default pipe size to 2 pages
2021-08-12 13:19:43 +02:00
pnode.c
pnode: terminate at peers of source
2023-01-18 11:30:40 +01:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:17:04 +01:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-28 13:16:50 +02:00
select.c
fs/select: rework stack allocation hack for clang
2024-03-26 18:22:34 -04:00
seq_file.c
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:16:16 +02:00
signalfd.c
signalfd: use wake_up_pollfree()
2021-12-14 10:18:07 +01:00
splice.c
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-26 13:19:21 +02:00
stack.c
…
stat.c
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 13:39:44 +02:00
statfs.c
statfs: enforce statfs[64] structure initialization
2023-05-30 12:42:11 +01:00
super.c
vfs: make freeze_super abort when sync_filesystem returns error
2022-02-23 11:58:38 +01:00
sync.c
ovl: skip overlayfs superblocks at global sync
2023-12-08 08:43:26 +01:00
timerfd.c
…
userfaultfd.c
userfaultfd: prevent concurrent API initialization
2021-09-22 11:48:02 +02:00
utimes.c
…
xattr.c
fs: don't audit the capability check in simple_xattr_list()
2023-01-18 11:30:04 +01:00