Chuck Lever
18c40a1cc1
net/handshake: Fix sock->file allocation ...
sock->file = sock_alloc_file(sock, O_NONBLOCK, NULL);
^^^^ ^^^^
sock_alloc_file() calls release_sock() on error but the left hand
side of the assignment dereferences "sock". This isn't the bug and
I didn't report this earlier because there is an assert that it
doesn't fail.
net/handshake/handshake-test.c:221 handshake_req_submit_test4() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:233 handshake_req_submit_test4() warn: 'req' was already freed.
net/handshake/handshake-test.c:254 handshake_req_submit_test5() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:290 handshake_req_submit_test6() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:321 handshake_req_cancel_test1() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:355 handshake_req_cancel_test2() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:367 handshake_req_cancel_test2() warn: 'req' was already freed.
net/handshake/handshake-test.c:395 handshake_req_cancel_test3() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:407 handshake_req_cancel_test3() warn: 'req' was already freed.
net/handshake/handshake-test.c:451 handshake_req_destroy_test1() error: dereferencing freed memory 'sock'
net/handshake/handshake-test.c:463 handshake_req_destroy_test1() warn: 'req' was already freed.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 88232ec1ec5e ("net/handshake: Add Kunit tests for the handshake consumer API")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Link: https://lore.kernel.org/r/168451609436.45209.15407022385441542980.stgit@oracle-102.nfsv4bat.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-05-22 19:25:24 -07:00
2023-03-29 08:22:52 +01:00
2023-05-05 19:12:01 -07:00
2023-05-17 12:55:39 +01:00
2023-05-17 21:27:30 -07:00
2023-04-23 14:16:44 +01:00
2023-05-19 15:37:45 -07:00
2023-04-21 11:34:50 -07:00
2023-05-17 21:28:58 -07:00
2023-03-02 22:22:07 -08:00
2023-05-15 22:24:46 +02:00
2023-02-21 18:24:12 -08:00
2023-05-10 19:06:49 -07:00
2023-03-22 21:50:23 +01:00
2023-05-16 19:57:52 -07:00
2023-04-23 14:16:45 +01:00
2023-05-03 09:13:20 +01:00
2023-05-22 19:25:24 -07:00
2023-03-16 21:11:03 -07:00
2023-03-17 09:13:53 +01:00
2023-05-12 10:05:50 +01:00
2023-05-13 16:58:58 +01:00
2023-03-16 17:34:40 -07:00
2023-05-10 07:04:51 +02:00
2023-03-31 09:25:12 +01:00
2023-05-10 10:03:32 +01:00
2023-05-16 10:26:00 -07:00
2023-04-05 13:48:04 +00:00
2023-03-09 23:06:21 -08:00
2023-02-15 10:26:37 +00:00
2023-04-20 16:29:51 -07:00
2023-04-28 09:35:33 +01:00
2023-05-17 14:18:28 +02:00
2023-05-10 09:28:38 +01:00
2023-01-30 07:30:47 +00:00
2023-03-07 13:37:05 -08:00
2023-05-15 08:40:27 +01:00
2023-04-07 19:42:53 -07:00
2023-05-10 10:25:55 +01:00
2023-04-13 09:35:30 +02:00
2023-02-13 09:33:39 +00:00
2023-04-06 20:36:27 +02:00
2023-01-28 00:19:57 -08:00
2023-05-05 19:12:01 -07:00
2023-05-05 10:01:31 +01:00
2023-05-22 11:05:20 +01:00
2023-05-19 08:54:04 +01:00
2023-05-17 09:56:01 -07:00
2023-05-15 10:21:20 +01:00
2023-05-19 08:37:37 +01:00
2023-05-10 19:06:53 -07:00
2023-05-12 10:04:10 +01:00
2023-05-16 10:09:50 -07:00
2023-01-25 09:51:04 +00:00
2023-04-13 16:43:38 -07:00
2023-05-16 20:52:35 -07:00
2023-04-14 11:09:27 +01:00
2023-04-19 18:48:48 -07:00
2023-04-19 18:48:48 -07:00
2023-05-10 09:58:29 +01:00
18c40a1cc1