iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/scsi
History
Linus Torvalds f075dce66c scsi sg: remove incorrect scsi command checking logic 
The SCSI_IOCTL_SEND_COMMAND ioctl has interesting scsi command
"security" checking.

If the file was opened read-only (but only in that case), it will
fetch the first byte of the command from user space, and do
"sg_allow_access()" on it.  That, in turn, will check that
"blk_verify_command()" is ok with that command byte.

If that passes, it will then do call "sg_scsi_ioctl()" to execute
the command.

This is entirely nonsensical for several reasons.

It's nonsensical simply because it's racy: after it copies the command
byte from user mode to check it, user mode could just change the byte
before it is actually submitted later by "sg_scsi_ioctl()".

But it is nonsensical also because "sg_scsi_ioctl()" itself already does
blk_verify_command() on the command properly after it has been copied
from user space.

So it is an incorrect implementation of a pointless check. Remove it.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-07-10 17:02:17 -07:00
..
aacraid
scsi: aacraid: Fix PD performance regression over incorrect qd being set
2018-06-26 12:06:09 -04:00
aic7xxx
SCSI fixes on 20180613
2018-06-14 16:35:32 +09:00
aic94xx
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
arcmsr
scsi: arcmsr: Change driver version to v1.40.00.05-20180309
2018-03-21 18:46:30 -04:00
arm
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
be2iscsi
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
bfa
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
bnx2fc
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
bnx2i
scsi: bnx2i: Use zeroing allocator rather than allocator/memset
2018-01-04 01:13:28 -05:00
csiostor
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
cxgbi
scsi: cxgb4i: silence overflow warning in t4_uld_rx_handler()
2018-04-09 21:32:45 -04:00
cxlflash
scsi: cxlflash: Isolate external module dependencies
2018-05-18 11:22:10 -04:00
device_handler
Merge branch 'fixes' into misc
2018-04-03 17:38:39 -07:00
dpt
sched/wait: Rename wait_queue_t => wait_queue_entry_t
2017-06-20 12:18:27 +02:00
esas2r
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
fcoe
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
fnic
treewide: Use array_size() in vmalloc()
2018-06-12 16:19:22 -07:00
hisi_sas
scsi: hisi_sas: Mark PHY as in reset for nexus reset
2018-05-28 22:40:32 -04:00
ibmvscsi
scsi: ibmvfc: Avoid unnecessary port relogin
2018-03-15 00:52:33 -04:00
ibmvscsi_tgt
scsi: ibmvscsis: add DRC indices to debug statements
2017-12-04 22:56:04 -05:00
isci
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
libfc
scsi: libfc: remove redundant initialization of 'disc'
2018-02-13 21:37:01 -05:00
libsas
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
lpfc
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
megaraid
treewide: Use array_size() in vzalloc()
2018-06-12 16:19:22 -07:00
mpt3sas
SCSI fixes on 20180613
2018-06-14 16:35:32 +09:00
mvsas
scsi: mvsas: fix wrong endianness of sgpio api
2018-03-01 21:07:48 -05:00
osd
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
pcmcia
scsi: remove the fdomain and fdomain_cs drivers
2018-03-19 22:54:47 -04:00
pm8001
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
qedf
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
qedi
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
qla2xxx
scsi: qla2xxx: Spinlock recursion in qla_target
2018-06-18 21:02:52 -04:00
qla4xxx
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
smartpqi
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
snic
scsi: snic: fix a couple of spelling mistakes: "COMPLETE"
2018-05-18 12:22:49 -04:00
sym53c8xx_2
treewide: Align function definition open/close braces
2018-03-26 11:13:09 +02:00
ufs
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
.gitignore
scsi: scsi_devinfo: Add scsi_devinfo_tbl.c
2017-10-25 05:40:22 -04:00
3w-9xxx.c
scsi: 3w-9xxx: fix a missing-check bug
2018-05-08 01:32:18 -04:00
3w-9xxx.h
scsi: 3w-9xxx: rework lock timeouts
2017-12-04 20:32:53 -05:00
3w-sas.c
scsi: 3ware: use 64-bit times for FW time sync
2017-12-04 20:32:53 -05:00
3w-sas.h
…
3w-xxxx.c
scsi: 3w-xxxx: fix a missing-check bug
2018-05-08 01:32:43 -04:00
3w-xxxx.h
…
53c700_d.h_shipped
…
53c700.c
scsi: 53c700: move bus reset to host reset
2017-08-25 17:21:11 -04:00
53c700.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
53c700.scr
…
a100u2w.c
scsi: a100u2w: Use module_pci_driver
2018-05-01 23:31:40 -04:00
a100u2w.h
…
a2091.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
a2091.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
a3000.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
a3000.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
a4000t.c
…
advansys.c
scsi: advansys: fix uninitialized data access
2017-04-04 19:39:39 -04:00
aha152x.c
scsi: aha152x: drop host reset
2017-08-25 17:21:11 -04:00
aha152x.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
aha1542.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
aha1542.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
aha1740.c
scsi: aha1740: stop using scsi_unregister
2018-03-15 00:26:54 -04:00
aha1740.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
am53c974.c
scsi: am53c974: Use module_pci_driver
2018-05-01 23:29:41 -04:00
atari_scsi.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
atp870u.c
scsi: atp870u: 64 bit bug in atp885_init()
2018-03-01 21:10:36 -05:00
atp870u.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
BusLogic.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
BusLogic.h
scsi: BusLogic: fix incorrect spelling of adatper_reset_req
2017-04-21 10:31:33 -04:00
bvme6000_scsi.c
…
ch.c
scsi: ch: add refcounting
2017-08-24 22:29:06 -04:00
constants.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dc395x.c
scsi: dc395x: Convert timers to use timer_setup()
2017-10-27 02:22:00 -07:00
dc395x.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dmx3191d.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
dpt_i2o.c
scsi: dpt_i2o: Remove VLA usage
2018-05-18 12:03:51 -04:00
dpti.h
scsi: dpt_i2o: stop using scsi_unregister
2018-03-15 00:25:37 -04:00
esp_scsi.c
scsi: esp_scsi: Always clear msg_out_len after MESSAGE OUT phase
2017-08-10 19:55:35 -04:00
esp_scsi.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
FlashPoint.c
…
g_NCR5380.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
gdth_ioctl.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gdth_proc.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gdth_proc.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gdth.c
block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE
2018-05-29 08:59:21 -06:00
gdth.h
block: Move SECTOR_SIZE and SECTOR_SHIFT definitions into <linux/blkdev.h>
2018-03-17 14:45:23 -06:00
gvp11.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
gvp11.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hosts.c
scsi: core: remove redundant assignment to shost->use_blk_mq
2018-04-09 16:34:41 -04:00
hpsa_cmd.h
scsi: hpsa: update discovery polling
2017-10-25 04:55:18 -04:00
hpsa.c
SCSI fixes on 20180613
2018-06-14 16:35:32 +09:00
hpsa.h
scsi: hpsa: fix selection of reply queue
2018-03-14 23:31:13 -04:00
hptiop.c
scsi: hptiop: Simplify reset handling
2017-08-25 17:21:10 -04:00
hptiop.h
…
imm.c
scsi: imm: drop duplicate bus_reset handler
2017-08-25 17:21:11 -04:00
imm.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
initio.c
…
initio.h
…
ipr.c
scsi: ipr: Eliminate duplicate barriers
2018-06-18 21:02:52 -04:00
ipr.h
scsi: ipr: Use sgl_alloc_order() and sgl_free_order()
2018-02-13 21:49:14 -05:00
ips.c
scsi: ips: fix firmware timestamps for 32-bit
2018-04-20 19:40:17 -04:00
ips.h
scsi: ips: fix firmware timestamps for 32-bit
2018-04-20 19:40:17 -04:00
iscsi_boot_sysfs.c
…
iscsi_tcp.c
scsi: iscsi_tcp: don't set a bounce limit
2018-04-19 00:00:44 -04:00
iscsi_tcp.h
…
jazz_esp.c
scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls
2018-03-12 22:05:43 -04:00
Kconfig
scsi: zorro_esp: New driver for Amiga Zorro NCR53C9x boards
2018-04-19 00:00:44 -04:00
lasi700.c
parisc/scsi/lasi700: Fix section mismatches
2017-08-22 16:34:36 +02:00
libiscsi_tcp.c
scsi: doc: fix iscsi-related kernel-doc warnings
2018-01-03 23:10:06 -05:00
libiscsi.c
treewide: kvzalloc() -> kvcalloc()
2018-06-12 16:19:22 -07:00
mac53c94.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
mac53c94.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mac_esp.c
scsi: mac_esp: Fix PIO transfers for MESSAGE IN phase
2017-08-10 19:55:34 -04:00
mac_scsi.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
Makefile
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
megaraid.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
megaraid.h
megaraid: simplify procfs code
2018-05-16 07:24:30 +02:00
mesh.c
…
mesh.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mvme16x_scsi.c
…
mvme147.c
scsi: mvme147: stop using scsi_module.c
2018-03-19 22:54:47 -04:00
mvme147.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mvumi.c
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
mvumi.h
…
ncr53c8xx.c
treewide: setup_timer() -> timer_setup()
2017-11-21 15:57:07 -08:00
ncr53c8xx.h
…
NCR5380.c
SCSI misc on 20171114
2017-11-14 16:23:44 -08:00
NCR5380.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
NCR_D700.c
…
NCR_D700.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
NCR_Q720.c
dma-coherent: remove the DMA_MEMORY_MAP and DMA_MEMORY_IO flags
2017-09-01 11:59:17 +02:00
NCR_Q720.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nsp32_debug.c
…
nsp32_io.h
…
nsp32.c
scsi: nsp32: fix logic bug in error handling
2017-10-16 22:38:44 -04:00
nsp32.h
…
osst_detect.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
osst_options.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
osst.c
treewide: Use array_size() in vmalloc()
2018-06-12 16:19:22 -07:00
osst.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pmcraid.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
pmcraid.h
scsi: pmcraid: Use sgl_alloc_order() and sgl_free_order()
2018-02-13 21:49:15 -05:00
ppa.c
scsi: ppa: mark expected switch fall-throughs
2017-12-04 20:32:52 -05:00
ppa.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ps3rom.c
…
qla1280.c
timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()
2017-10-05 15:01:17 +02:00
qla1280.h
timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()
2017-10-05 15:01:17 +02:00
qlogicfas408.c
scsi: qlogicfas: move bus_reset to host_reset
2017-08-25 17:21:11 -04:00
qlogicfas408.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
qlogicfas.c
scsi: qlogicfas: move bus_reset to host_reset
2017-08-25 17:21:11 -04:00
qlogicpti.c
scsi: qlogicpti: Fix an error handling path in 'qpti_sbus_probe()'
2018-05-18 12:22:48 -04:00
qlogicpti.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
raid_class.c
scsi: raid_class: Add 'JBOD' RAID level
2018-02-12 11:43:25 -05:00
script_asm.pl
…
scsi_common.c
scsi: core: doc. fixes to scsi_common.c
2017-12-11 21:39:39 -05:00
scsi_debug.c
scsi: scsi_debug: Fix memory leak on module unload
2018-06-18 22:16:13 -04:00
scsi_debugfs.c
scsi: devinfo: use const_ilog2 for array indices
2018-04-20 19:14:28 -04:00
scsi_debugfs.h
scsi: Implement blk_mq_ops.show_rq()
2017-04-26 15:09:04 -06:00
scsi_devinfo.c
scsi: devinfo: BLIST_RETRY_ASC_C1 for Fujitsu ETERNUS
2018-04-20 19:14:36 -04:00
scsi_dh.c
scsi: scsi_dh: replace too broad "TP9" string with the exact models
2018-04-18 19:34:08 -04:00
scsi_error.c
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
scsi_ioctl.c
scsi: Suppress gcc 7 fall-through warnings reported with W=1
2017-08-25 17:08:07 -04:00
scsi_lib_dma.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_lib.c
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
scsi_logging.c
…
scsi_logging.h
SCSI misc on 20171114
2017-11-14 16:23:44 -08:00
scsi_netlink.c
netlink: extended ACK reporting
2017-04-13 13:58:20 -04:00
scsi_pm.c
…
scsi_priv.h
scsi: dh: Remove scsi_dh_remove_device()
2017-12-07 21:13:45 -05:00
scsi_proc.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_sas_internal.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_scan.c
scsi: core: Use blist_flags_t consistently
2017-12-14 22:30:24 -05:00
scsi_sysctl.c
…
scsi_sysfs.c
scsi: devinfo: change blist_flag_t to 64bit
2018-04-20 19:14:35 -04:00
scsi_trace.c
…
scsi_transport_api.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_transport_fc.c
block: fix timeout changes for legacy request drivers
2018-06-19 11:27:18 -06:00
scsi_transport_iscsi.c
block: remove parent device reference from struct bsg_class_device
2018-05-29 13:00:25 -06:00
scsi_transport_sas.c
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
scsi_transport_spi.c
scsi: scsi_transport_spi: make two const arrays static, shrinks object size
2018-02-15 18:20:14 -05:00
scsi_transport_srp.c
for-4.18/block-20180603
2018-06-04 07:58:06 -07:00
scsi_typedefs.h
…
scsi.c
scsi: core: fix two wrong indentation cases
2018-02-27 22:26:12 -05:00
scsi.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsicam.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sd_dif.c
…
sd_zbc.c
SCSI fixes on 20180613
2018-06-14 16:35:32 +09:00
sd.c
scsi: sd: Defer spinning up drive while SANITIZE is in progress
2018-04-18 23:37:40 -04:00
sd.h
scsi: sd_zbc: Change the type of the ZBC fields into u32
2018-04-19 00:00:44 -04:00
sense_codes.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ses.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
sg.c
scsi sg: remove incorrect scsi command checking logic
2018-07-10 17:02:17 -07:00
sgiwd93.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
sim710.c
…
sni_53c710.c
scsi: remove incorrect __exit markups
2017-03-15 19:27:46 -04:00
sr_ioctl.c
sr: pass down correctly sized SCSI sense buffer
2018-05-21 12:21:14 -06:00
sr_vendor.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sr.c
sr: get/drop reference to device in revalidate and check_events
2018-04-11 11:26:09 -06:00
sr.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
st_options.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
st.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
st.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
stex.c
scsi: stex: make S6flag static
2017-04-26 18:32:29 -04:00
storvsc_drv.c
SCSI misc on 20180610
2018-06-10 13:01:12 -07:00
sun3_scsi_vme.c
…
sun3_scsi.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
sun3x_esp.c
scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls
2018-03-12 22:05:43 -04:00
sun_esp.c
scsi: sun_esp: fix device reference leaks
2017-06-27 21:46:55 -04:00
virtio_scsi.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
vmw_pvscsi.c
scsi: vmw-pvscsi: return DID_BUS_BUSY for adapter-initated aborts
2018-05-01 23:15:40 -04:00
vmw_pvscsi.h
…
wd33c93.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
wd33c93.h
…
wd719x.c
scsi: wd719x: Use module_pci_driver
2018-05-01 23:30:12 -04:00
wd719x.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xen-scsifront.c
scsi: xen-scsifront: add error handling for xenbus_printf
2018-06-19 14:54:41 +02:00
zalon.c
parisc/scsi/zalon: Fix section mismatches
2017-08-22 16:34:36 +02:00
zorro7xx.c
…
zorro_esp.c
scsi: zorro_esp: New driver for Amiga Zorro NCR53C9x boards
2018-04-19 00:00:44 -04:00