ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
113 lines
2.8 KiB
C
113 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* I2C driver for the X-Powers' Power Management ICs
|
|
*
|
|
* AXP20x typically comprises an adaptive USB-Compatible PWM charger, BUCK DC-DC
|
|
* converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature
|
|
* as well as configurable GPIOs.
|
|
*
|
|
* This driver supports the I2C variants.
|
|
*
|
|
* Copyright (C) 2014 Carlo Caione
|
|
*
|
|
* Author: Carlo Caione <carlo@caione.org>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/err.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/module.h>
|
|
#include <linux/mfd/axp20x.h>
|
|
#include <linux/of.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
|
|
static int axp20x_i2c_probe(struct i2c_client *i2c,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct axp20x_dev *axp20x;
|
|
int ret;
|
|
|
|
axp20x = devm_kzalloc(&i2c->dev, sizeof(*axp20x), GFP_KERNEL);
|
|
if (!axp20x)
|
|
return -ENOMEM;
|
|
|
|
axp20x->dev = &i2c->dev;
|
|
axp20x->irq = i2c->irq;
|
|
dev_set_drvdata(axp20x->dev, axp20x);
|
|
|
|
ret = axp20x_match_device(axp20x);
|
|
if (ret)
|
|
return ret;
|
|
|
|
axp20x->regmap = devm_regmap_init_i2c(i2c, axp20x->regmap_cfg);
|
|
if (IS_ERR(axp20x->regmap)) {
|
|
ret = PTR_ERR(axp20x->regmap);
|
|
dev_err(&i2c->dev, "regmap init failed: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return axp20x_device_probe(axp20x);
|
|
}
|
|
|
|
static void axp20x_i2c_remove(struct i2c_client *i2c)
|
|
{
|
|
struct axp20x_dev *axp20x = i2c_get_clientdata(i2c);
|
|
|
|
axp20x_device_remove(axp20x);
|
|
}
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id axp20x_i2c_of_match[] = {
|
|
{ .compatible = "x-powers,axp152", .data = (void *)AXP152_ID },
|
|
{ .compatible = "x-powers,axp202", .data = (void *)AXP202_ID },
|
|
{ .compatible = "x-powers,axp209", .data = (void *)AXP209_ID },
|
|
{ .compatible = "x-powers,axp221", .data = (void *)AXP221_ID },
|
|
{ .compatible = "x-powers,axp223", .data = (void *)AXP223_ID },
|
|
{ .compatible = "x-powers,axp803", .data = (void *)AXP803_ID },
|
|
{ .compatible = "x-powers,axp806", .data = (void *)AXP806_ID },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
|
|
#endif
|
|
|
|
static const struct i2c_device_id axp20x_i2c_id[] = {
|
|
{ "axp152", 0 },
|
|
{ "axp202", 0 },
|
|
{ "axp209", 0 },
|
|
{ "axp221", 0 },
|
|
{ "axp223", 0 },
|
|
{ "axp803", 0 },
|
|
{ "axp806", 0 },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
|
|
|
|
#ifdef CONFIG_ACPI
|
|
static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
|
|
{
|
|
.id = "INT33F4",
|
|
.driver_data = AXP288_ID,
|
|
},
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, axp20x_i2c_acpi_match);
|
|
#endif
|
|
|
|
static struct i2c_driver axp20x_i2c_driver = {
|
|
.driver = {
|
|
.name = "axp20x-i2c",
|
|
.of_match_table = of_match_ptr(axp20x_i2c_of_match),
|
|
.acpi_match_table = ACPI_PTR(axp20x_i2c_acpi_match),
|
|
},
|
|
.probe = axp20x_i2c_probe,
|
|
.remove = axp20x_i2c_remove,
|
|
.id_table = axp20x_i2c_id,
|
|
};
|
|
|
|
module_i2c_driver(axp20x_i2c_driver);
|
|
|
|
MODULE_DESCRIPTION("PMIC MFD I2C driver for AXP20X");
|
|
MODULE_AUTHOR("Carlo Caione <carlo@caione.org>");
|
|
MODULE_LICENSE("GPL");
|